Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEFERRED replacement mode #1751

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Add DEFERRED replacement mode #1751

merged 2 commits into from
Jun 27, 2024

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Jun 12, 2024

Description

Deferred replacement mode was removed in V7 of the SDK. This brings it back.

@tonidero tonidero added the pr:feat A new feature label Jun 12, 2024
@tonidero tonidero changed the title Add DEFERRED replacement mode Add DEFERRED replacement mode Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.31%. Comparing base (76724cf) to head (027b3cf).
Report is 2 commits behind head on main.

Files Patch % Lines
.../kotlin/com/revenuecat/purchases/common/Backend.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
- Coverage   83.32%   83.31%   -0.01%     
==========================================
  Files         222      222              
  Lines        7550     7553       +3     
  Branches     1060     1060              
==========================================
+ Hits         6291     6293       +2     
- Misses        845      846       +1     
  Partials      414      414              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero added the HOLD label Jun 17, 2024
@tonidero tonidero marked this pull request as ready for review June 17, 2024 12:49
@tonidero tonidero requested a review from a team June 17, 2024 12:49
Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonidero tonidero removed the HOLD label Jun 27, 2024
@tonidero tonidero merged commit 36ddd19 into main Jun 27, 2024
9 checks passed
@tonidero tonidero deleted the add-deferred-replacement-mode branch June 27, 2024 10:21
tonidero added a commit that referenced this pull request Jun 27, 2024
### Description
Followup to #1751.

We were not calling the callbacks on DEFERRED purchases. This fixes that
so DEFERRED purchases work correctly
tonidero added a commit that referenced this pull request Jun 28, 2024
### Description
Another followup to #1751 and #1764 

When making `DEFERRED` purchases, Google returns the result using the
old product id. We need to cache all the context information using the
old product id so we can attribute it correctly.
@tonidero tonidero mentioned this pull request Jul 1, 2024
tonidero added a commit that referenced this pull request Jul 1, 2024
Deferred replacement mode was removed in V7 of the SDK. This brings it
back.
tonidero added a commit that referenced this pull request Jul 1, 2024
### Description
Followup to #1751.

We were not calling the callbacks on DEFERRED purchases. This fixes that
so DEFERRED purchases work correctly
tonidero added a commit that referenced this pull request Jul 1, 2024
### Description
Another followup to #1751 and #1764 

When making `DEFERRED` purchases, Google returns the result using the
old product id. We need to cache all the context information using the
old product id so we can attribute it correctly.
tonidero pushed a commit that referenced this pull request Jul 1, 2024
**This is an automatic release.**

### New Features
* Add `DEFERRED` replacement mode (#1751) via Toni Rico (@tonidero)
### Bugfixes
* Use correct product context with `DEFERRED` purchases (#1766) via Toni
Rico (@tonidero)
* Call callbacks on `DEFERRED` purchases (#1764) via Toni Rico
(@tonidero)
### Dependency Updates
* Bump fastlane from 2.221.0 to 2.221.1 (#1758) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Adds .aiexclude (#1762) via JayShortway (@JayShortway)

Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants