Use correct product context with DEFERRED purchases
#1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Jun 27, 2024
| @@ -92,7 +92,8 @@ internal class BillingWrapper( | |||
| @Volatile | |||
| var billingClient: BillingClient? = null | |||
|
|
|||
| private val purchaseContext = mutableMapOf<String, PurchaseContext>() | |||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | |||
| internal val purchaseContext = mutableMapOf<String, PurchaseContext>() | |||
There was a problem hiding this comment.
Testing this using Google's callback was trickier, since we would need to use Jsons to create a google Purchase object. This is easier and allows to verify this behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1766 +/- ##
=======================================
Coverage 83.25% 83.26%
=======================================
Files 223 223
Lines 7614 7617 +3
Branches 1070 1071 +1
=======================================
+ Hits 6339 6342 +3
Misses 854 854
Partials 421 421 ☔ View full report in Codecov by Sentry. |
Closed
tonidero
pushed a commit
that referenced
this pull request
Jul 1, 2024
**This is an automatic release.** ### New Features * Add `DEFERRED` replacement mode (#1751) via Toni Rico (@tonidero) ### Bugfixes * Use correct product context with `DEFERRED` purchases (#1766) via Toni Rico (@tonidero) * Call callbacks on `DEFERRED` purchases (#1764) via Toni Rico (@tonidero) ### Dependency Updates * Bump fastlane from 2.221.0 to 2.221.1 (#1758) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Adds .aiexclude (#1762) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another followup to #1751 and #1764
When making
DEFERREDpurchases, Google returns the result using the old product id. We need to cache all the context information using the old product id so we can attribute it correctly.