Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: Archive size of v3.4.0 is 110MB #10000

Closed
EricCousineau-TRI opened this issue Nov 12, 2018 · 8 comments
Closed

json: Archive size of v3.4.0 is 110MB #10000

EricCousineau-TRI opened this issue Nov 12, 2018 · 8 comments

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Nov 12, 2018

When building on my laptop at home, I noticed a large download for json, and just tried downloading the archive:

wget https://github.com/nlohmann/json/archive/v3.4.0.tar.gz

Ends up, this is ~110MB compressed; uncompressed, a majority of the data resides in /test and /benchmark, neither of which seem important to us. If you strip out /doc as well, the resulting uncompressed files are 1.6MB.

It'd be nice to get a version of the code that doesn't have that much uneeded bloat, but I don't know of any simple solutions aside from forking (yuck).

EDIT: Seems like they offer downloads, and there's an offering of json.hpp:
https://github.com/nlohmann/json/releases/tag/v3.4.0

Will just switch to this.

\cc @jwnimmer-tri @jamiesnape

@EricCousineau-TRI EricCousineau-TRI self-assigned this Nov 12, 2018
@EricCousineau-TRI EricCousineau-TRI changed the title json: Archive of v3.2.0 is 110M json: Archive size of v3.2.0 is 110MB Nov 12, 2018
@EricCousineau-TRI EricCousineau-TRI changed the title json: Archive size of v3.2.0 is 110MB json: Archive size of v3.4.0 is 110MB Nov 12, 2018
@SeanCurtis-TRI
Copy link
Contributor

For the record, today I spent 15 minutes downloading json. This is despite the fact that speedtest.net reported download speeds from my computer at 500 Mbps. If the server is being slow, then the 110 Mb is punishing.

@jwnimmer-tri
Copy link
Collaborator

Well, the Drake mirrors don't have json v3.4.0 cached yet, so I guess for you github.com was slow today. More of a #8595 automation problem than a large file problem -- @jamiesnape FYI.

@jamiesnape
Copy link
Contributor

jamiesnape commented Nov 15, 2018

As much as I would like to be the solution to all slower downloads, the mirrors aren't going to help much unless we make them the primaries, and the download for JSON has always been large (it grew about 800 KB between versions), so not sure why it is now such an issue. And yes, it is mirrored, though CloudFront does need to propagate the packages to its edges.

@jwnimmer-tri
Copy link
Collaborator

Ah. I was thinking that Bazel tried all mirrors concurrently, but saying it out loud that would be silly.

In any case, I wholeheartedly endorse closing this issue as "not even worth the time investment in discussing".

@EricCousineau-TRI
Copy link
Contributor Author

Following endorsement; closing.
Can re-open if anyone feels horribly pained by this.

@EricCousineau-TRI
Copy link
Contributor Author

FTR This is effectively captured by this issue (and its duplicates):
nlohmann/json#96

@nlohmann
Copy link

nlohmann commented May 4, 2020

FYI: nlohmann/json#96 is solved now and the next release will exclude test data and will be much smaller (~ 7 MB).

@jwnimmer-tri
Copy link
Collaborator

Thank you! In the meantime, Drake has dropped its direct use of nlohmann/json, but we still have other projects that use it. \CC @soonho-tri FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants