json: Use direct file to avoid testing bloat from repo #10001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
+@jwnimmer-tri for review, please. (uber low priority)
Reviewable status: all discussions resolved, platform LGTM missing
|
110MB is chump change. I don't think this is worth any time at all. |
|
I agree this is not worth solving. Took me longer to write this than download the file. Also, I don't really want to have to handle another mirror type either since automating the mirroring is still buried deep in my backlog. |
|
FWIW, I do think the existing download is obnoxious, but I at least agree with Eric that doing something about it is low priority. |
|
K, all sounds good. It did take about 10min to write up, and clearly isn't fully debugged. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10000
This is one option; if we deem it too complex to support other mirrors then I guess that's fine, but at some point it would be nice to trim some of the excess.
This change is