-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fishy-looking math in AutoDiffScalar atan() #14051
Comments
Assigned to @mitiguy for a look. Can you tell if the Eigen atan/asin/etc derivatives are correct for all scalar types? The implementations seem inconsistent. |
The file in that review is only used with |
No, I think it is just inconsistently implemented in that case. |
So @rpoyner-tri how about you change |
Closes RobotLocomotion#14051. This is mostly to answer complaints about inconsistencies with similar functions.
Per discussion in #16075 I believe the implementation with abs2() is incorrect, though the error would only be apparent for complex numbers. Other uses of abs2() there also seem wrong to me. If we want consistency, we should fix the ones that use abs2() to use plain old square instead of absolute square. |
Closes RobotLocomotion#14051. This is mostly to answer complaints about inconsistencies with similar functions. Also, it answers complaints about confusion over the use of abs2().
Closes RobotLocomotion#14051. This is mostly to answer complaints about inconsistencies with similar functions. Also, it answers complaints about confusion over the use of abs2().
Closes RobotLocomotion#14051. This is mostly to answer complaints about inconsistencies with similar functions. Also, it answers complaints about confusion over the use of abs2().
* autodiffxd atan(): Make consistent with other implementations Closes #14051. This is mostly to answer complaints about inconsistencies with similar functions. Also, it answers complaints about confusion over the use of abs2().
Questions were raised in the context of #14045 about the details of the math implementing atan() for AutoDiffXd. I couldn't answer without a bit of history, and some way to evaluate the alternatives. This issue is to track that follow-up.
Comments:
#14045 (review)
and
#14045 (review)
The text was updated successfully, but these errors were encountered: