-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close out the pybind11 fork #5842
Comments
Relates pybind/pybind11#1152. |
Porting item from #7660 to here:
|
Per Eric, we don't think we'll ever get to zero diffs from upstream, but we should still try to keep our diffs minimal by PRing upstream. |
Will close this for now. Will encode that we should keep diffs minimal in our fork's README. |
Given the recent uptick in interest in pybind11's holder setup (specifically for |
Given that pybind11 upsteam just repaved over the entire universe with |
Agreed it will be more work, but I think reformatting our tree (hopefully idempotent with very small span of fixed points) will help PR merging. Planning to do another update in April. |
It remains a goal to get off https://github.com/RobotLocomotion/pybind11 and back onto upstream. Not top priority, but we shouldn't forget to do it - and it may be easier to do the fresher our fork is.
cc @stonier @jamiesnape
The text was updated successfully, but these errors were encountered: