Fully-automatic clang-format with include reordering #3713
Conversation
rwgk
changed the title
.clang-format
Outdated
| TabWidth: 4 | ||
| IncludeCategories: |
There was a problem hiding this comment.
This could go in before / be rebased in, doesn't need to be in the automatic commit, since we aren't running clang-format till this point.
There was a problem hiding this comment.
Doing this right now.
.clang-format
Outdated
| @@ -9,11 +9,28 @@ BinPackParameters: false | |||
| BreakBeforeBinaryOperators: All | |||
| BreakConstructorInitializers: BeforeColon | |||
| ColumnLimit: 99 | |||
There was a problem hiding this comment.
i would add some comment pragmas for clang-tidy nolints
There was a problem hiding this comment.
Do you have a pointer handy to some time-tested config? Or a concrete suggestion? Happy to fold that in. (I just don't want to invent an incompatible wheel, not currently needing anything in particular.)
There was a problem hiding this comment.
CommentPragmas is a regular expression, can you just match it with a nolint comment? That's quite nice, actually.
rwgk
force-pushed
the
clang-format_with_include_reordering
branch
2 times, most recently
from
98313de
to
c0fea50
Compare
|
(The 🐍 3.5 • MSVC 2017 • x64 failure is an infrastructure flake, connection timed out. Safe to ignore.) |
rwgk
force-pushed
the
clang-format_with_include_reordering
branch
from
0497fd5
to
4b1c3fa
Compare
|
|
Description
To be merged after PR #3712.
Suggested changelog entry: