-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setup scripts for various Homebrew changes/removals #12004
Fix setup scripts for various Homebrew changes/removals #12004
Conversation
@drake-jenkins-bot mac-high-sierra-unprovisioned-clang-bazel-experimental-python2-release please |
@drake-jenkins-bot mac-high-sierra-unprovisioned-clang-bazel-experimental-python2-release please |
+@EricCousineau-TRI for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status: 2 unresolved discussions, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jamiesnape)
setup/mac/binary_distribution/Brewfile, line 30 at r1 (raw file):
brew 'zeromq' cask 'adoptopenjdk' unless system '/usr/libexec/java_home --version 1.8+ --failfast &> /dev/null'
nit Can you state why this is being used instead of java
?
setup/mac/binary_distribution/requirements.txt, line 3 at r1 (raw file):
lxml matplotlib protobuf; python_version < "3.0"
nit Is it possible to briefly explain why this is necessary?
e.g. "Homebrew no longer provides Python 2 version."
FTR NumPy fixes will need to come in later; comments may be added in then (per f2f). |
For anyone looking at this in a few days/weeks when there are
numpy
issues, the fix is going to benumpy; python_version < "3.0"
insetup/mac/binary_distribution/requirements.txt
.Relates #12003.
This change is