Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup scripts for various Homebrew changes/removals #12004

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Fix setup scripts for various Homebrew changes/removals #12004

merged 2 commits into from
Sep 4, 2019

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Sep 3, 2019

For anyone looking at this in a few days/weeks when there are numpy issues, the fix is going to be numpy; python_version < "3.0" in setup/mac/binary_distribution/requirements.txt.

Relates #12003.


This change is Reviewable

@jamiesnape
Copy link
Contributor Author

@drake-jenkins-bot mac-high-sierra-unprovisioned-clang-bazel-experimental-python2-release please
@drake-jenkins-bot mac-mojave-unprovisioned-clang-bazel-experimental-python2-release please

@jamiesnape
Copy link
Contributor Author

@drake-jenkins-bot mac-high-sierra-unprovisioned-clang-bazel-experimental-python2-release please
@drake-jenkins-bot mac-mojave-unprovisioned-clang-bazel-experimental-python2-release please

@jamiesnape
Copy link
Contributor Author

+@EricCousineau-TRI for review.

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: 2 unresolved discussions, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jamiesnape)


setup/mac/binary_distribution/Brewfile, line 30 at r1 (raw file):

brew 'zeromq'

cask 'adoptopenjdk' unless system '/usr/libexec/java_home --version 1.8+ --failfast &> /dev/null'

nit Can you state why this is being used instead of java?


setup/mac/binary_distribution/requirements.txt, line 3 at r1 (raw file):

lxml
matplotlib
protobuf; python_version < "3.0"

nit Is it possible to briefly explain why this is necessary?
e.g. "Homebrew no longer provides Python 2 version."

@jamiesnape jamiesnape added status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits status: single reviewer ok https://drake.mit.edu/reviewable.html labels Sep 4, 2019
@jamiesnape jamiesnape merged commit cdccfa0 into RobotLocomotion:master Sep 4, 2019
@jamiesnape jamiesnape deleted the fix-for-homebrew-removal branch September 4, 2019 21:45
@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Sep 4, 2019

FTR NumPy fixes will need to come in later; comments may be added in then (per f2f).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants