Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Eslint and prettier configs with husky pre-push hook #174

Closed

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented Jul 4, 2022

  • Added Eslint configs and checks to both app and cms
  • Added Prettier configs to format code to both app and cms
  • Added husky pre-push hook to format and lint code before pushing the code

Closes #172

@debdutdeb
Copy link
Member

Hey @sidmohanty11 please remove the hook. thanks.

@debdutdeb
Copy link
Member

Why not put the configs on the top level?

@sidmohanty11
Copy link
Contributor Author

@debdutdeb we can't do it with eslint as its configs are different for app and cms, but as far as I know, prettier will go up one dir and search for the config till it finds one, so we can definitely use it from the top level. I've made the changes, please let me know if something else needs to be changed.

Thanks!

@Palanikannan1437
Copy link
Contributor

@Sing-Li @Dnouv and @sidmohanty11, has all of this been addressed in resolved in #189?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO] Add prettier and eslint configs
3 participants