Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Lint errors fixed in app directory #189

Merged
merged 7 commits into from
Oct 26, 2022

Conversation

Palanikannan1437
Copy link
Contributor

Closes #175

Issue in brief

Tons of linting errors were present in the app directory

Suggested Fixes/Changes

  • Added ESLint config for the app directory
  • Fixed all errors and warnings according to next/core-web-vitals
  • Fixed unnecessary re-renders by changing the dependencies of useEffect
  • Updates nextjs to support next/future/image
  • Added react-cookie for better and clear logic
  • Formatted the files in the process with the already existing prettier configs

Result of the above Suggested Changes 🎉

image

@lgtm-com
Copy link

lgtm-com bot commented Oct 23, 2022

This pull request introduces 1 alert and fixes 2 when merging 9c51e4b into d7d6311 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Potentially unsafe external link

@Palanikannan1437
Copy link
Contributor Author

@Sing-Li and @Dnouv, would be awesome if you could review this and let me know if I need to make any changes

@Sing-Li Sing-Li merged commit 5f2fb37 into RocketChat:master Oct 26, 2022
Dnouv pushed a commit to Dnouv/RC4Community that referenced this pull request Nov 3, 2022
* added eslint config for app directory

* fixed link, displayname, apos, key and noreferrer errors

* removed incorrect function execution instead of reference

* changed img to next/future/image and added missing alt properties

* fixed missing passHref, non declared object and async useffect functions

* fixed useffect dependencies, react-cookie and nextjs support for future/image and svg added

* eslint config in multiple directories bug fixed for babel in vscode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tons of linting error in app directory
4 participants