-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to install language dictionaries #562
Add option to install language dictionaries #562
Conversation
@damon-myers Hey! This is awesome, thanks for you contribution. |
src/public/lib/SpellCheck.js
Outdated
@@ -70,7 +86,7 @@ class SpellCheck { | |||
* dictionary that is valid based on system (defaults to en_US) | |||
*/ | |||
setEnabledDictionaries () { | |||
const dictionaries = this.dictionaries; | |||
const dictionaries = this.availableDictionaries; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing this it seems to have enabled all dictionaries for me. I think it is caused by the change you made here.
@alexbrazier Thanks for catching that! I corrected the dictionary issue you mentioned, and also tested the changes on Windows. I had only tested them on Linux beforehand, so I also made it so that the install menu option is only shown if you are not using system language dictionaries. (In that case you'd simply install the language via your operating system.) |
Hey @damon-myers giving this branch a try, can you provide the dictionary you used to test this? Just checking if we can add this to the current release or if it's going to be postponed into the next version. |
@gdelavald Sure thing, I used the dictionary .dic and .aff from here: https://cgit.freedesktop.org/libreoffice/dictionaries/plain/cs_CZ I used Google to get some Czech text and it seemed to correct that correctly. |
any news? it would be a huge improvment |
@damon-myers Sorry for the delay on this, we have had some issues testing this branch, on osx and ubuntu we had some exceptions thrown when starting the app. |
@gdelavald anything new? do you have any logs with errors? |
@monspid, Holy crap! Sorry! I got busy and didn't notice there were issues with this. I can take a look at the crashes this weekend and try to get the branch up to date. |
It's a great NEWS :-) It would be a huge improvement |
I rebased the branch against develop and made sure everything still works. @gdelavald, I'm not able to reproduce the issue on |
Can't wait to see that coming in, I had to copy over es_ES my fr_FR for now |
We would love to have this functionality. |
@damon-myers can you please resolve the conflicts so I can merge this? |
@engelgabriel, of course! On it! |
@RocketChat/DesktopApp
Closes #535
This PR adds an option to the Spellchecker menu to install a new language dictionary. It works by copying the dictionary to the app's dictionary directory and adding it to the list of available dictionaries.