This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 108
Search for globally available dictionaries #69
Open
DemonTPx
wants to merge
12
commits into
atom:master
Choose a base branch
from
DemonTPx:hunspell-search-global-dictionaries
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Search for globally available dictionaries #69
DemonTPx
wants to merge
12
commits into
atom:master
from
DemonTPx:hunspell-search-global-dictionaries
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linux, CI or when hunspell is preferred
…ome tests for getAvailableDictionaries; Add missing semicolon
winstliu
changed the title
Search for globally available dictionaries (on non-windows systems)
Search for globally available dictionaries
Feb 10, 2017
+1 |
Is there any chance this will be reviewed? Or should I also make a PR to the (bit more active) bdict branch? |
I much prefer this change over the solution in the bdict branch, mostly because I don't want my app downloading dictionary files from the internet. |
Hey, it seems this project is active at last! Any change this PR could be merged in as well? :) |
Any update on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
GetAvailableDictionaries
orSetDictionary
, it will search in the given path or known locations where hunspell dictionaries are typically located (/usr/share/hunspell
for example.)This fixes #51 and #54.
No windows support yetI also added windows support!I've used this script to test it out:
On my machine, this results in:
Please note that I am not an experienced C++ programmer, so I might do some weird stuff. I'd love to know if anything seems weird and how to fix it.