refactor!: removed roomNameExists method (#32484)

Co-authored-by: Marcos Spessatto Defendi <[email protected]>
RocketChat · Sep 14, 2024 · 010dfd6 · 010dfd6
1 parent 7778f38
commit 010dfd6
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 37 deletions.
diff --git a/apps/meteor/app/api/server/v1/rooms.ts b/apps/meteor/app/api/server/v1/rooms.ts
@@ -89,7 +89,9 @@ API.v1.addRoute(
 		async get() {
 			const { roomName } = this.queryParams;
 
-			return API.v1.success({ exists: await Meteor.callAsync('roomNameExists', roomName) });
+			const room = await Rooms.findOneByName(roomName, { projection: { _id: 1 } });
+
+			return API.v1.success({ exists: !!room });
 		},
 	},
 );

diff --git a/apps/meteor/server/methods/index.ts b/apps/meteor/server/methods/index.ts
@@ -41,7 +41,6 @@ import './removeUserFromRoom';
 import './reportMessage';
 import './requestDataDownload';
 import './resetAvatar';
-import './roomNameExists';
 import './saveUserPreferences';
 import './saveUserProfile';
 import './sendConfirmationEmail';

diff --git a/apps/meteor/server/methods/roomNameExists.ts b/apps/meteor/server/methods/roomNameExists.ts
diff --git a/apps/meteor/tests/end-to-end/api/rooms.ts b/apps/meteor/tests/end-to-end/api/rooms.ts
@@ -941,7 +941,22 @@ describe('[Rooms]', () => {
 				.end(done);
 		});
 
-		it('should return an error when send an invalid room', (done) => {
+		it('should return false if this room name does not exist', (done) => {
+			void request
+				.get(api('rooms.nameExists'))
+				.set(credentials)
+				.query({
+					roomName: 'foo',
+				})
+				.expect(200)
+				.expect((res) => {
+					expect(res.body).to.have.property('success', true);
+					expect(res.body).to.have.property('exists', false);
+				})
+				.end(done);
+		});
+
+		it('should return an error when the require parameter (roomName) is not provided', (done) => {
 			void request
 				.get(api('rooms.nameExists'))
 				.set(credentials)