Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted user can not see all accessible other users in the Directory (no permission view-outside-room) #14930

Open
ggruber4711 opened this issue Jul 4, 2019 · 11 comments · May be fixed by #16897

Comments

@ggruber4711
Copy link

ggruber4711 commented Jul 4, 2019

Description:

Steps to reproduce:

  1. Remove the permission view-outside-room from the role User
  2. Create a new group TestGroup 1
  3. Create User A and add the user to the group just created
  4. Create User B and add the user to the group just created
  5. Login with User A and click on the search button to search for other users

Expected behavior:

Search result should contain User B, as he is in the same group as User A.

Actual behavior:

Only those users can be found, where at least once a discussion was started.

Server Setup Information:

  • Version of Rocket.Chat Server: 1.1.3
  • Operating System: Linux
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: 8.11.4
  • MongoDB Version: 4.0.10
@ggruber4711 ggruber4711 changed the title Restricted user can not see all accessible other users in the Directory (no permission view-outside-rooms) Restricted user can not see all accessible other users in the Directory (no permission view-outside-room) Jul 4, 2019
@ggruber4711
Copy link
Author

Can someone give a hint on how this could be fixed?

@reetp
Copy link

reetp commented Aug 9, 2019

Please see our guide for opening issues: https://rocket.chat/docs/contributing/reporting-issues

Rocket moves rapidly and this may already be fixed.

Test on either 1.3.x or Develop.

Can someone give a hint on how this could be fixed?

If it isn't already the devs will look in due course.

This is Open Source. Everyone can contribute.

@rodrigomeneguet
Copy link

Do you have any plans to implement this improvement?

@ggruber4711
Copy link
Author

Please see our guide for opening issues: https://rocket.chat/docs/contributing/reporting-issues

Rocket moves rapidly and this may already be fixed.

Test on either 1.3.x or Develop.

Can someone give a hint on how this could be fixed?

If it isn't already the devs will look in due course.

This is Open Source. Everyone can contribute.

Just checked on 2.1.0 and the problem still exists.
If any expert could give some advice on where the necessary code-ajustments would needed to be done, I might be able to help to implement this feature.

@reetp
Copy link

reetp commented Sep 28, 2019

Please note this is not a help forum.

See https://rocket.chat/docs/getting-support/

https://open.rocket.chat

#dev channel for developers needing help developing new features

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Oct 10, 2020
@ggruber4711
Copy link
Author

hmm, there is a PR which fixes the problem. I think only think left is to merge the Pull Request :-)

@github-actions github-actions bot removed the stat: stale Stale issues will be automatically closed if no activity label Oct 10, 2020
@dimitrihof
Copy link

Would be nice to have that fixed.

@ecfghjp
Copy link

ecfghjp commented Jul 4, 2021

Any action on it yet , this is a very desirable feature for our use case as well, specially when you want to restrict users haiving access to their channels/groups and restricting them from peeking into all users on the server

@wokawoka
Copy link

wokawoka commented Apr 1, 2022

I agree, it would be great if the way it works now could be changed

@skmaingi
Copy link

skmaingi commented Jul 29, 2022

This issue was resolved. Remove view-outside-room permission from the role User and create team with user A and B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants