[FIX] Spotlight search when view-outside-room is false (#14930)

[TheoKouzelis]

[FIX] For bug fixes

Closes #14930

When view-outside-room is set to false, the spotlight search will now return search users who are subscribed to the same rooms as the logged in user.

Previous behaviour was to always return empty results, because the variable rid was never set.

[ggazzo]

looks perfect to me (the behavior) but its quite expensive too what do you think @sampaiodiego ?

[sampaiodiego]

this is indeed somewhat expensive.. specially to spotlight, that is trigger for each typed character.

I thought maybe searching direct on subscription's fields like u.name and u.username, so one trip to mongo can be reduced, but are no indexes there and I'm not sure without a deeper look, if the data there is reliable.

Maybe one thing that can be done is to store usersWithSameSubscriptions in mem cache.. so it doesn't need to hit the DB every time to get that info.

[AllRWeak]

Hello

Any updates on this fix? This is something that we could really use to keep the number of different servers down.

[CLAassistant]

All committers have signed the CLA.