-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Send to Channel" send automatically disables checkbox #19167
Labels
Comments
Same here (v 3.7.1). Reverse case is also "valid" :
|
@dougfabris @renatobecker I have made a PR for this can you review it ? |
Still an issue in 4.0.2 🙄 Is nobody using threaded messages at rocket.chat? This bug is mind-bogglingly obvious.. |
Still an issue in 4.0.2 |
Same with 4.3.0 |
as a workaround for now we use this script: #20695 (comment) |
kodiakhq bot
pushed a commit
that referenced
this issue
Jun 27, 2022
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> ## Proposed changes (including videos or screenshots) <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> This PR removes the confusion between the `show message in main thread` and the function `also to send to channel`. In the past, we used the `show message in main thread` as a solution to help users to understand the thread feature, as this feature is now mature enough there's no reason to maintain this preference. Send the thread message to the main channel or just inside of the thread, should be a decision from the user where the function `also send to channel` appears. Because of that, and because of a bunch of requests and issues we received, we're introducing a new preference `also send thread to channel` where users will be able to decide the behavior of the checkbox. ![image](https://user-images.githubusercontent.com/27704687/175655594-023c5907-adc8-4924-ba7d-467608d06fec.png) Now there are three behavior options - `Default`: when it unchecks after sending the first message <img width='250px' height='350px' src='https://user-images.githubusercontent.com/27704687/175656500-34817639-7f13-4641-b4fa-9dd106e99443.gif' /> - `Always`: stay checked for all messages <img width='250px' height='350px' src='https://user-images.githubusercontent.com/27704687/175657299-d88efaba-1c2b-4bb9-a23a-f9755dcec5ca.gif' /> - `Never`: stay unchecked for all messages <img width='250px' height='350px' src='https://user-images.githubusercontent.com/27704687/175657544-3dcd0adc-05cf-4196-83a6-f6cc29a1de2b.gif' /> <!-- END CHANGELOG --> ## Issue(s) <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> Closes #20695 Closes #19167 Closes #18347 ## Steps to test or reproduce <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> ## Further comments <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> Co-authored-by: Guilherme Gazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Also Send to Channel tick box in thread does not persist
Steps to reproduce:
Set Send to Channel globally
Administration -> Accounts -> Default User Preferences -> Show thread messages in the main thread
Set Send to Channel individually
Account -> Preferences -> Show thread messages in the main thread
Reply to create a new thread. 'Also Send to Channel' is ticked.
Close thread box.
Open Thread box.
'Also Send to Channel' not ticked.
Tick box and send and the box unchecks again.
Expected behavior:
If the setting is enable the 'Also Send To Channel' tick box should be checked at all times unless the user deselects it.
Actual behavior:
When you close and the reopen the thread box the 'Also Send To Channel' is not checked.
Check the box and send and it unchecks again.
It does appear that messages are sent to the thread.
However, this is confusing a lot of users.
Server Setup Information:
Client Setup Information
Additional context
None
Relevant logs:
None
Probably related:
#18347
#17416
The text was updated successfully, but these errors were encountered: