-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAK] Remove show message in main thread preference #26002
Conversation
…turbo * 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits) Chore: Major refactors in pageobjects (#26015) [BREAK] Remove show message in main thread preference (#26002) Regression: Webhook Integration Creation + string error toast msg (#26008) Chore: convert e2e to ts (#25958) Regression: Room Endpoint Call Issues (#25928) Chore: Fixes e2e playwright intermittences (#25984) Chore: Fuselage update (#26004) Chore: Small fix on callProvider (#25963) [FIX] Initial members value on Create Channel Modal (#26000) Chore: Migrate from meteor model to raw (#25756) Chore: VoIP Context (#25994) Chore: Fuselage update (#25983) [FIX] sidebar colors (#25987) Regression: Non-reactive routes (#25990) [BREAK] use urlParams on omnichannel/agent/extension/ (#25982) [FIX] toolbox menu behind thread component (#25925) [FIX] Sort by scope or creation date not working on canned responses list (#25475) Chore: Colors (#25969) Revert "[BREAK] use urlParams on omnichannel/agent/extension/" (#25980) Regression: Prevent Form Submit on Reset Click ...
You mixed up two different use-cases... While people can understand the behaviour of sending some (first, and maybe important other) thread messages to the main chat, for some communities, some people would like to see all thread messages in main chat, wether or not the box was ticked by the OP when the message was send Bring back that feature, the two can live together ! |
I think that TBG-FR is absolutely right! |
@aceArt-GmbH @TBG-FR @rumato163 After receiving those requests when we did the preference removal, we brought the complaints to the product team and we're planning to bring back the preference on our next release: #29302. |
Proposed changes (including videos or screenshots)
This PR removes the confusion between the
show message in main thread
and the functionalso to send to channel
. In the past, we used theshow message in main thread
as a solution to help users to understand the thread feature, as this feature is now mature enough there's no reason to maintain this preference.Send the thread message to the main channel or just inside of the thread, should be a decision from the user where the function
also send to channel
appears. Because of that, and because of a bunch of requests and issues we received, we're introducing a new preferencealso send thread to channel
where users will be able to decide the behavior of the checkbox.Now there are three behavior options
Default
: when it unchecks after sending the first messageAlways
: stay checked for all messagesNever
: stay unchecked for all messagesIssue(s)
Closes #20695
Closes #19167
Closes #18347
Steps to test or reproduce
Further comments