Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions inside a private group show as pop-up to user outside of the private group #2165

Closed
m-se opened this issue Feb 8, 2016 · 1 comment · Fixed by #2954
Closed

Mentions inside a private group show as pop-up to user outside of the private group #2165

m-se opened this issue Feb 8, 2016 · 1 comment · Fixed by #2954
Labels
contrib: easy feat: notification type: bug

Comments

@m-se
Copy link

m-se commented Feb 8, 2016

Whenever someone in a private group mentions a user that is not part of the private group, this user will still get the pop-up indicating the #channelname and context of the mention.
@graywolf336
Copy link
Contributor

This needs to be marked as a high priority! It is still happening.

marceloschmidt added a commit that referenced this issue Apr 19, 2016
@marceloschmidt
Do not notify mentions to people outside of a private group.
1a8ed8b 
Fix #2165
@marceloschmidt marceloschmidt mentioned this issue Apr 19, 2016
Merged
engelgabriel pushed a commit that referenced this issue Apr 19, 2016
@marceloschmidt @engelgabriel
Close #2165 Do not notify mentions to people outside of a private gro…
66269e2 
…up. (#2954)

* Do not notify mentions to people outside of a private group.
Fix #2165

* Improved checking if user belongs to private room
@matthias-brun matthias-brun mentioned this issue May 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: easy feat: notification type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not notify mentions to people outside of a private group. RocketChat/Rocket.Chat
2 participants
@graywolf336 @m-se