Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not notify mentions to people outside of a private group. #2954

Merged
merged 2 commits into from
Apr 19, 2016

Conversation

marceloschmidt
Copy link
Member

@RocketChat/core

Closes #2165

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-2954 April 19, 2016 18:40 Inactive
@sampaiodiego
Copy link
Member

LGTM

1 similar comment
@rodrigok
Copy link
Member

LGTM

@engelgabriel engelgabriel merged commit 66269e2 into develop Apr 19, 2016
@engelgabriel engelgabriel deleted the mention-in-private-groups branch April 19, 2016 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentions inside a private group show as pop-up to user outside of the private group
4 participants