Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel scrolls to bottom when clicking image #32206

Closed
paulchen opened this issue Apr 14, 2024 · 13 comments · Fixed by #32187
Closed

Channel scrolls to bottom when clicking image #32206

paulchen opened this issue Apr 14, 2024 · 13 comments · Fixed by #32187

Comments

@paulchen
Copy link

Description:

After reloading a channel, clicking an image in a message makes the channel scroll to the very bottom instead of showing the image.

Steps to reproduce:

  1. Open a channel in a browser.
  2. Refresh the page.
  3. Scroll up to a message containing an image.
  4. Click on the image.

Expected behavior:

The image is shown.

Actual behavior:

The channel scrolls to the very bottom:

simplescreenrecorder-2024-04-14_22.09.23.mp4

Server Setup Information:

  • Version of Rocket.Chat Server: 6.7.0
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • MongoDB Version: 6.0.14

Client Setup Information

Based on the reports by the users on my Rocket.Chat instance, the issue seems to occur in every browser. I just successfully reproduced it using:

  • Browser Version:
    • Version 123.0.6312.105 (Offizieller Build) Arch Linux (64-Bit)
    • Firefox 124.0.2 (64-bit)
  • Operating System: Arch Linux

Additional context

The same behaviour occurs when clicking a link preview or an attachment.

@Gummikavalier
Copy link

Gummikavalier commented Apr 15, 2024

We are witnessing the very same thing happening with the message toolbar. For instance:

  1. Switch from one channel to other
  2. Scroll up to some old message
  3. Hover mouse over the message and select Reply in thread

Reply in thread action does not trigger and the message view scrolls to bottom.

Edit: Many other elements seem to trigger this too.

Edit2: Also reproducible in the official open.rocket.chat.

@Gummikavalier
Copy link

Gummikavalier commented Apr 15, 2024

@juliajforesti Hi, do you think this issue could have been introduced by the new date bubble feature?
#31572

@SySagar
Copy link
Contributor

SySagar commented Apr 16, 2024

For some reason I am unable to produce it neither in open.rocket.chat or in my local dev environment.

2024-04-16.19-56-15.mov

@paulchen
Copy link
Author

For some reason I am unable to produce it neither in open.rocket.chat or in my local dev environment.

I can't reproduce it on open.rocket.chat either. Maybe this depends on the deployment method? There have been issues in the past that only occurred when using Docker.

@Gummikavalier
Copy link

I think they've simply fixed it there now. It did happen the last time I tested there, but I cannot reproduce there anymore either.

@Den4ik92
Copy link

I have the same bug, it can be reproduced as follows:
-In the browser (refresh the page):
-In the app (View menu -> Refresh without cache):

  1. Open any chat with a long history
  2. Scroll up until loading old messages
  3. Click on any message and it scrolls all the way down

@wanderlage
Copy link

I have the same problem after updating to version 6.7.0

@dougfabris
Copy link
Member

dougfabris commented Apr 18, 2024

Indeed it's an issue folks. Unfortunately it is a side effect introduced with the message keyboard navigation we shipped on 6.7. It's already fixed an the 6.7.1 is on the way

@Gummikavalier
Copy link

Confirmed working in RC 6.7.1 for us.

@dougfabris
Copy link
Member

Thank you for always helping us @Gummikavalier

@Gummikavalier
Copy link

No problem! ❤️ Credits for @paulchen too for the fastest reaction. 👍

@dougfabris
Copy link
Member

@Gummikavalier Of course, nice catch @paulchen
Thank you all 💯 🚀

@paulchen
Copy link
Author

I can confirm that this problem is fixed in 6.7.1. Thanks @dougfabris for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants