Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show date on message's scroll #31572

Merged
merged 32 commits into from
Feb 29, 2024
Merged

feat: show date on message's scroll #31572

merged 32 commits into from
Feb 29, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jan 29, 2024

Proposed changes (including videos or screenshots)

Show bubble with date on:

  • room messages
  • thread messages

Kapture 2024-02-09 at 09 56 22

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: bc87818

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: Patch coverage is 76.28866% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 54.50%. Comparing base (8629672) to head (bc87818).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31572      +/-   ##
===========================================
- Coverage    54.54%   54.50%   -0.04%     
===========================================
  Files         2279     2276       -3     
  Lines        50208    50193      -15     
  Branches     10237    10236       -1     
===========================================
- Hits         27385    27359      -26     
- Misses       20337    20350      +13     
+ Partials      2486     2484       -2     
Flag Coverage Δ
e2e 53.38% <76.28%> (-0.03%) ⬇️
e2e-api 40.05% <ø> (-0.07%) ⬇️
unit 76.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti changed the title feat: sticky date on MessageList feat: show date on message's scroll Feb 9, 2024
@juliajforesti juliajforesti marked this pull request as ready for review February 16, 2024 18:37
@juliajforesti juliajforesti requested a review from a team as a code owner February 16, 2024 18:37
@juliajforesti juliajforesti added this to the 6.7 milestone Feb 20, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 29, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 29, 2024
@kodiakhq kodiakhq bot merged commit 299aa15 into develop Feb 29, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the feat/date-bubble branch February 29, 2024 23:39
gabriellsh added a commit that referenced this pull request Mar 6, 2024
…tMarkdown

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: improve useJumpToMessage (#31907)
  feat: Add `link` action to composer toolbar (#31679)
  chore: replace `PaletteStyleTag` in favor of fuselage component (#31839)
  fix: presence for mobiles with duplicated connections (#31895)
  fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720)
  fix: livechat agent status set to available after reactivation (#31651)
  chore: Deprecate `insertOrUpdateUser` method (#31884)
  chore: update ts version on recently merged package (#31885)
  chore: move utilitary functions out of ee folder (#31207)
  chore: Remove references to EE code from the app bridges (#31757)
  fix: Room import doesn't honor the specified owner (#31803)
  fix: message parser emphasis black hole (#31868)
  chore: remove hardcoded position for message date (#31866)
  feat: show date on message's scroll (#31572)
  chore: `RoomHeader` keyboard navigability (#31837)
  fix: Login page breaking when handling not expected errors (#31804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants