Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Focus being forced on last message when interacting with mouse #32187

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 11, 2024

Proposed changes (including videos or screenshots)

Fixes an issue that forces the focus on the last message when interacting by mouse on message list

Issue(s)

Fixes #32206

Steps to test or reproduce

Further comments

CORE-265

Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: 9fa3a01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 6.8 milestone Apr 11, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link
Contributor

dionisio-bot bot commented Apr 11, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.04%. Comparing base (b7f5035) to head (9fa3a01).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32187      +/-   ##
===========================================
- Coverage    55.05%   55.04%   -0.01%     
===========================================
  Files         2309     2305       -4     
  Lines        50977    50925      -52     
  Branches     10428    10423       -5     
===========================================
- Hits         28067    28034      -33     
+ Misses       20387    20376      -11     
+ Partials      2523     2515       -8     
Flag Coverage Δ
e2e 54.20% <66.66%> (-0.02%) ⬇️
unit 75.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review April 11, 2024 21:29
@dougfabris dougfabris requested a review from a team as a code owner April 11, 2024 21:29
@dougfabris dougfabris force-pushed the fix/messageFocusByClick branch 2 times, most recently from 2437278 to 702d976 Compare April 15, 2024 21:38
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 15, 2024
@kodiakhq kodiakhq bot merged commit 844e599 into develop Apr 15, 2024
43 checks passed
@kodiakhq kodiakhq bot deleted the fix/messageFocusByClick branch April 15, 2024 23:21
@ggazzo
Copy link
Member

ggazzo commented Apr 18, 2024

/patch

Copy link
Contributor

dionisio-bot bot commented Apr 18, 2024

Pull request #32252 added to Project: "Patch 6.7.1"

ggazzo added a commit that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel scrolls to bottom when clicking image
2 participants