Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is Audio & Video call Button ? #9632

Closed
RiusmaX opened this issue Feb 7, 2018 · 81 comments · Fixed by #13675
Closed

Where is Audio & Video call Button ? #9632

RiusmaX opened this issue Feb 7, 2018 · 81 comments · Fixed by #13675
Assignees
Milestone

Comments

@RiusmaX
Copy link

RiusmaX commented Feb 7, 2018

Description:

I've installed a fresh instance of Rocket.Chat 0.61 on Ubuntu 16.04 with snapd and when i'm in a private chat with someone, I can't see the "Call Button" for start an audio or a video call anywhere (WebRTC is set).

Server Setup Information:

  • Version of Rocket.Chat Server: 0.61.0
  • Operating System: Ubuntu Server 16.04 (fresh install)
  • Deployment Method(snap/docker/tar/etc): snap (i've tried docker too)
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Activated
  • Node Version: 8.8.1

Steps to Reproduce:

  1. Run a VM with Ubuntu 16.04
  2. Run in a terminal "sudo snap install rocketchat-server"
  3. Go to http://:3000
  4. Create an account
  5. Ask a Friend or take a second device to create a second account
  6. Try to launch a call

Expected behavior:

The buttons "Call" is displayed in the user section.

Actual behavior:

Impossible to find the button anywhere. I can only use the Jitsi call feature.

@rasos
Copy link
Contributor

rasos commented Feb 11, 2018

Check if WebRTC is activated https://yourdomain.net/admin/WebRTC
duplicate of #9632 ?

@ElieMyIdea
Copy link

+1
Duplicated by itself 😋 ?
Like said before, WebRTC is enable in admin Panel with default parameters set ;)

Please need some help 🙏

@afroDC
Copy link

afroDC commented Feb 14, 2018

We're also experiencing the same issue.

@LifeIsAParadox
Copy link

same.

@xenithorb
Copy link
Contributor

xenithorb commented Feb 23, 2018

This should be probably retitled:

"WebRTC Administration options left behind after feature removal"

Nevermind that, I read something wrong

@der-eismann
Copy link
Contributor

der-eismann commented Feb 27, 2018

I just noticed that I can start audio & video calls, but only in private rooms & open channels. In direct messages the option is missing.

@xenithorb
Copy link
Contributor

xenithorb commented Feb 27, 2018

@der-eismann That sounds more like the meet.jit.si integration?

Does the button say "Video Chat?", if so that's the jitsi integration.

The symptom of this bug for me is that if I disable that functionality from the admin panel via Administration -> Video Conference - Enabled: False then the menu for any conversation whether private, direct, or public looks like so:

image

The point being, that this is with Administration -> WebRTC -> Enabled For *: True

@der-eismann
Copy link
Contributor

der-eismann commented Feb 27, 2018

No, I have jitsi and video conferences disabled and enabled WebRTC everywhere. But the audio & video calls are still missing from direct messages.
This is the user information in a room or channel:
rocket channel
And this is in direct messages:
rocket dm

@xenithorb
Copy link
Contributor

Indeed, I found it too:

screenshot

Man that's in a really unintuitive spot.

@xenithorb
Copy link
Contributor

xenithorb commented Feb 27, 2018

Also, It's true that User<->User rooms don't have this... And to make things work the icon is overloaded:

image

Contrast that with the previous behavior:

image

@karlprieb
Copy link
Contributor

karlprieb commented Feb 28, 2018

Hey guys, thank you all for your reports!

@arthurgiustina will work on a better way to display this options (icons + label, or just icons, idk) and I will investigate that to make it work again!

@arthurgiustina
Copy link

user information

@karlprieb check this idea =)

@xenithorb
Copy link
Contributor

I really like that, including how the mute icon is clearer about its intentions. Well done.

@Phuzzy112
Copy link

Hi all,
I'm about 90% done with putting RC into prod here, but am getting pressured about this. Any ETA that I could pass along?

PS love that mockup

@versavius
Copy link

Also in the drop down menu next to a user in the attached screenshot we have the "Video Chat" button if this was changed to two buttons "Audio Call" and "Video Call" as well as arthurgiustina suggestion that would make it so much easier to make audio/video calls.

image

@karlprieb karlprieb added this to the 0.65.0 milestone Apr 9, 2018
@graywolf336
Copy link
Contributor

@karlprieb when you guys go to do this, please add these convert this pull request to the new style: #3635

@avignat
Copy link

avignat commented May 29, 2018

Please bring those buttons back. I'm also affected running Rocket 0.65.0 with WebRTC enable for MP, private and public groups.

@reetp
Copy link

reetp commented May 30, 2018

I only use video/audio when in Direct Messages, and the person I do use video with mainly is hardly ever in the private group, which means I now have to scroll back to find their last comment in the group to start a call.
Frustrating and wastes time.

@jrichard8
Copy link

Version 0.64.2

WebRTC activated and dont have button to launch voice call. Whats wrong ?

@Shaverdoff
Copy link

@hortonelectric Jitsi integration is already available in the fairchat app (which can connect to any RC server, see Android / iOS stores).

on mobile ios client no any video options like start video(jitsi/BB) or something else like WebRTC.
on mobile android client webrtc option is appears but it grayout like disabled, even if options turn on on server side.

@rasos
Copy link
Contributor

rasos commented Feb 2, 2019

@Shaverdoff Jitsi must be configured on your server, then you see in the fairchat app in any chat or channel in the lower bar a video icon, which launches the Jitsi Meet app seamlessly (or suggests to install it first).

19-02-02 10-15-36 0019

@Shaverdoff
Copy link

@Shaverdoff Jitsi must be configured on your server, then you see in the fairchat app in any chat or channel in the lower bar a video icon, which launches the Jitsi Meet app seamlessly (or suggests to install it first).

19-02-02 10-15-36 0019

ofcouse it configured.. 074 tar
m-p : IOS 12.1.3 client 3.2.0 (223)
this photo from mobile
img_5599
and this photo from desktop client.
2019-02-02 16 44 55
do not know how in currently android version was, but cuple month ago no point to video not to mention about photo...

@rasos
Copy link
Contributor

rasos commented Feb 2, 2019

The screenshot with the cat is from the fairchat app - it is an independent app development compatible with RocketChat servers, which has video calls integrated.

Android: https://play.google.com/store/apps/details?id=com.osalliance.rocketchatMobile

iOS: https://itunes.apple.com/at/app/fairchat/id1301616129?mt=8

Source Code: https://git.fairkom.net/chat/fairchat/

@Shaverdoff
Copy link

The screenshot with the cat is from the fairchat app - it is an independent app development compatible with RocketChat servers, which has video calls integrated.

Android: https://play.google.com/store/apps/details?id=com.osalliance.rocketchatMobile

iOS: https://itunes.apple.com/at/app/fairchat/id1301616129?mt=8

Source Code: https://git.fairkom.net/chat/fairchat/

after add server and click to it - app crash) cool!) i wait until ios team with Refael as Lead will procced with video

@pwittke
Copy link

pwittke commented Feb 11, 2019

any updates?

@ministry-of-code
Copy link

How can it be that a core feature is fundamentally broken and nobody cares?

@Shaverdoff
Copy link

now even webrtc enable on pv - video/audio button do not work))

@reetp
Copy link

reetp commented Feb 15, 2019

How can it be that a core feature is fundamentally broken and nobody cares?

It's not that they don't care, but the direction of travel is to remove this sort of functionality from the core and move it to Apps/External programs eg in this case Jitsi and in say the case of the internal bot to an external bot system.

It means it simplifies the core making it easier to maintain and manage.

Also remember to date Rocket is essentially Alpha which means things get chopped and changed.

@ministry-of-code
Copy link

ministry-of-code commented Feb 15, 2019

@reetp thanks for the information. we're in the process of evaluating to use rocket chat for our company and this does not really help to say "it's great, lets go with it". I understand that it makes sense to remove this stuff from core and replace with external services - but even these integrations are broken. We integrated Jitsi and it does not work. When someone starts a video conference, nobody in the channel can join because the link simply does not work (nothing happens when the link is clicked). Also, the admin menu entry WebRTC should be remove when it does not work/is not integrated any more.

@9joshua
Copy link

9joshua commented Feb 15, 2019

I would say it is foolish to stop maintaining a core feature unless a viable app can replace it. Otherwise, we let things deteriorate while we anticipate something that may never come to pass. And in the case of WebRTC, I think 1 to 1 calls should always be a core functionality. What's next? Do we need to find an app for messages? Should RocketChat be reduced to an app container?

This issue has persisted for more than a year now. It's time to fix it and stop waiting for apps.

@HammyHavoc
Copy link
Contributor

HammyHavoc commented Feb 15, 2019

@discon-nected, ridiculous, right? With this thought process in mind and a lack of basic communication functionality outside of messaging, we've been forced to go elsewhere for our communication needs. It's a pity, because Rocket.Chat was otherwise a very promising project, and I've enjoyed contributing.

@9joshua
Copy link

9joshua commented Feb 15, 2019

@HammyHavoc I guess the RC team became busy selling their paid platforms. I have noticed issues are left open for years now and/or closed with "This is better suited for apps" or something similar.

i.e. RocketChat/feature-requests#610 #5506 https://github.com/RocketChat/Rocket.Chat/issues/3416 RocketChat/feature-requests#637

@Toub Toub mentioned this issue Feb 18, 2019
@Alwandy
Copy link

Alwandy commented Mar 8, 2019

As some has mentioned, we're also currently evaluating to use rocket.chat but what hinders us is this functionality! We also do not want to use external apps / third party services to enable this feature, we really would like to use it if it's part of the core as we're self-hosting again for confidential reasons.

@pwittke
Copy link

pwittke commented Mar 11, 2019

Cutting a core feature that made many peoply move to RocketChat would be a mistake.

For many companies the sole reason of using such a system is to have it on a standalone basis with no external services connected due to privacy/security/confidentiality reasons.

And if the feature is planned to be removed I agree there should not be an option for it and the website should be updated.

But I guess we have to wait for the Devs to answer and clarify at one point in time.

image

image

@ggazzo
Copy link
Member

ggazzo commented Mar 11, 2019

@discon-nected we really want to move to apps... but it doesn't mean we gonna to abandon the features, it's how the framework/code structure works, our apps are our responsibility as the core code is. But on the other hand, if you don like some app/feature you could remove/install/develop a different app.

I have noticed issues are left open for years now and/or closed with "This is better suited for apps".
again its not true, your team its not so huge as you think. ok, its true we have tried to make some money, but our development team is 100% on nonpaid features. (some examples, federantion, threads and the new livechat).
I guess the RC team became busy selling their paid platforms.

@pwittke no! we never had this in mind, we have a planned project to fix/improve videos/audio, and I/we want to start very soon.

And if the feature is planned to be removed I agree there should not be an option for it and the website should be updated.

@9joshua
Copy link

9joshua commented Mar 11, 2019

we really want to move to apps... but it doesn't mean we gonna to abandon the features

Then why can't we make audio calls (for over a year now)?

And don't get me wrong, I have no problem using RC developed apps, but using 3rd party apps to achieve what should be core functionality while at the same time compromising security is a problem. (i.e., Jistsi)

Also, closing an issue with "this is better suited as an app" means that RC does not want to develop the particular feature in-house.

@MathiasGmeiner
Copy link

MathiasGmeiner commented Mar 11, 2019

#9632 (comment)
@ggazzo thanks for the clarification!

@ggazzo
Copy link
Member

ggazzo commented Mar 11, 2019

we really want to move to apps... but it doesn't mean we gonna to abandon the features

Then why can't we make audio calls (for over a year now)?

And don't get me wrong, I have no problem using RC developed apps, but using 3rd party apps to achieve what should be core functionality while at the same time compromising security is a problem. (i.e., Jistsi)

there are no excuses fot that, actually, I just can say we had no time to make a proper fix... but believe me, I'm not happy with that, please await for the next weeks :x

@9joshua
Copy link

9joshua commented Mar 11, 2019

That's great news. I will wait impatiently :D

@rasos
Copy link
Contributor

rasos commented Mar 11, 2019

@Shaverdoff you may try again the fairchat app, the 1.2.1 version has got fixed the server change bug. It seamlessly calls the Jitsi Meet app when you get an invitation to join a conference call.

@Shaverdoff
Copy link

@Shaverdoff you may try again the fairchat app, the 1.2.1 version has got fixed the server change bug. It seamlessly calls the Jitsi Meet app when you get an invitation to join a conference call.

in 12/1/4 iOS that fairchat forclose after try to enter server url and press connect. so...

@ggazzo
Copy link
Member

ggazzo commented Mar 11, 2019

@discon-nected please check #13675

@9joshua
Copy link

9joshua commented Mar 11, 2019

Sweet. Thank you!

@melroy89
Copy link

Indeed, I found it too:

screenshot

Man that's in a really unintuitive spot.

But that is only for a audio call one-on-one?

What about a Jitsi audio call only in either a channel or private group?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.