Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] WebRTC wasn't working due to design and browser's APIs changes #13675

Merged
merged 5 commits into from
Mar 15, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 11, 2019

Closes #9632
Closes #12899
ITS NOT A FINAL version, we have a lot of improvements we want to do... but with that PR the users are able to use webrtc (with all old well know bugs)
image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13675 March 11, 2019 22:09 Inactive
@tassoevan tassoevan self-requested a review March 11, 2019 22:21
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13675 March 12, 2019 03:09 Inactive
@ggazzo ggazzo added this to the 1.0.0 milestone Mar 12, 2019
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13675 March 13, 2019 01:33 Inactive
@rodrigok rodrigok changed the title [FIX] webrtc [FIX] WebRTC wasn't working duo to design and browser's APIs changes Mar 13, 2019
tassoevan
tassoevan previously approved these changes Mar 13, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13675 March 13, 2019 19:31 Inactive
@tassoevan tassoevan dismissed their stale review March 13, 2019 19:34

I've found a small issue in membersList

@ggazzo ggazzo merged commit 246ff8a into develop Mar 15, 2019
@ggazzo ggazzo deleted the fix/webrtc branch March 15, 2019 00:07
@flantascience
Copy link

Will there be a notification when this is added to the 'master' branch???

@rodrigok rodrigok mentioned this pull request Apr 28, 2019
@Sing-Li Sing-Li changed the title [FIX] WebRTC wasn't working duo to design and browser's APIs changes [FIX] WebRTC wasn't working due to design and browser's APIs changes Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants