Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Show user's status description by the usernames in messages list #14892

Merged
merged 5 commits into from
May 8, 2020
Merged

[NEW] Show user's status description by the usernames in messages list #14892

merged 5 commits into from
May 8, 2020

Conversation

wreiske
Copy link
Contributor

@wreiske wreiske commented Jun 28, 2019 •
edited by rodrigok
Loading

This is a work in progress.... I can't seem to get them to be reactive! Maybe @Hudell knows?

status_bubbles_messages

image

The status bubble only shows if the user has a status message. The status text displays when you hover over the status bubble.

@reetp reetp mentioned this pull request Jun 28, 2019
Open
@tassoevan
Copy link
Contributor

@wreiske This is super tricky. Due to performance issues, the message template is non-reactive, only re-rendering when the message object is updated that its collection.

BTW, should this feature not be added only after setting an emoji for a custom status? I believe this was removed from the feature, right?

@wreiske
Copy link
Contributor Author

wreiske commented Jun 28, 2019 •
edited
Loading

@wreiske This is super tricky. Due to performance issues, the message template is non-reactive, only re-rendering when the message object is updated that its collection.

BTW, should this feature not be added only after setting an emoji for a custom status? I believe this was removed from the feature, right?

I was thinking to do this one in steps... adding emojis to a status text, and assigning an emoji to a message is two different things.

image

image
image

If there is no emoji set for the status, it shows the bubble.

image

If we can figure out how to update this, I think it will be OK as the current bubble icon. Once emoji's get added to status messages at a later time, it could pull the emoji instead of the bubble icon.

@engelgabriel engelgabriel added this to the 1.3.0 milestone Jul 1, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@sampaiodiego sampaiodiego modified the milestones: 2.0.0, 2.1.0 Sep 6, 2019
@engelgabriel engelgabriel modified the milestones: 2.1.0, 2.2.0 Oct 13, 2019
@ggazzo ggazzo modified the milestones: 2.2.0, 2.3.0 Oct 18, 2019
@wreiske
Copy link
Contributor Author

wreiske commented Mar 4, 2020

Now that NRR is pulled, I'm wondering if this will just work? 🤔 @ggazzo

@engelgabriel engelgabriel modified the milestones: 2.3.0, 3.1.0 Mar 17, 2020
ggazzo and others added 2 commits March 19, 2020 01:09
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
1c9b519 
…4892-wreiske-user-status-bubbles

* 'develop' of github.com:RocketChat/Rocket.Chat: (540 commits)
  [FIX] Show error message if password and confirm password not equal (RocketChat#16247)
  [FIX] Message quote button inside threads (RocketChat#16925)
  Fix wrong imported library meteor/tap:i18n
  lint
  [IMPROVE] User gets feedback when a message has been starred or unstarred (RocketChat#13860)
  [FIX] admin can sort users by email in directory view (RocketChat#15796)
  [FIX] Pinned messages wouldn't collapse (RocketChat#16188)
  [IMPROVE] Added border to page header. (RocketChat#16792)
  [FIX] Correct thread messages display in context bar. (RocketChat#16835)
  [FIX] Public channel cannot be acessed via URL when 'Allow Anonymous Read' is active (RocketChat#16914)
  Fixed Line break incorrectly being called apostrophe (RocketChat#16918)
  [IMPROVE] Context menu autofocus (RocketChat#16915)
  Improve room types usage (RocketChat#16753)
  [NEW] API `users.deactivateIdle` for mass-disabling of idle users (RocketChat#16849)
  [NEW] API to logout from other locations (RocketChat#16193)
  [IMPROVE] Add option to require authentication on user's shield endpoint (RocketChat#16845)
  [FIX] Custom OAuth Bug (RocketChat#16811)
  [FIX] Integrations page pagination (RocketChat#16838)
  reset package-lock to upstream
  Apply suggestions from code review
  ...
@wreiske
Merge branch 'develop' into user-status-bubbles
0279de5
@engelgabriel engelgabriel modified the milestones: 3.1.0, 3.2.0 Apr 20, 2020
@rodrigok rodrigok changed the title [WIP] [NEW] Status bubbles in messages [NEW] Show user's status description by the usernames in messages list May 7, 2020
@rodrigok rodrigok modified the milestones: 3.2.0, 3.3.0 May 7, 2020
@ggazzo ggazzo merged commit 47a8bac into RocketChat:develop May 8, 2020
@wreiske
Copy link
Contributor Author

wreiske commented May 8, 2020

🥳

gabriellsh added a commit that referenced this pull request May 9, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into inte…
eeb73d6 
…grations

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
  Regression: RegExp callbacks of settings were not being called (#17552)
  Meteor update to version 1.10.2 (#17533)
ggazzo added a commit that referenced this pull request May 10, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
b25b6ae 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Push settings enabled when push gateway is selected (#17582)
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
ggazzo added a commit that referenced this pull request May 11, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
89f7125 
* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
  Regression: RegExp callbacks of settings were not being called (#17552)
  Meteor update to version 1.10.2 (#17533)
  Fix default offline channel name when saving departments. (#17553)
  [NEW] Screen Lock settings - mobile client (#17523)
ggazzo added a commit that referenced this pull request May 12, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into remo…
1d1bbcd 
…ve-get-dom

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Push settings enabled when push gateway is selected (#17582)
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
  Regression: RegExp callbacks of settings were not being called (#17552)
  Meteor update to version 1.10.2 (#17533)
  Fix default offline channel name when saving departments. (#17553)
  [NEW] Screen Lock settings - mobile client (#17523)
This was referenced May 28, 2020
Merged
Merged
@wreiske wreiske mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@tassoevan tassoevan Awaiting requested review from tassoevan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wreiske @tassoevan @ggazzo @rodrigok @engelgabriel @sampaiodiego