Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Error during data export for DMs #17577

Merged
merged 1 commit into from
May 8, 2020
Merged

[FIX] Error during data export for DMs #17577

merged 1 commit into from
May 8, 2020

Conversation

mtmr0x
Copy link
Contributor

@mtmr0x mtmr0x commented May 8, 2020 

- Change from `roomId` variable to `roomData` the value to get iterate on `uids` fields

How to reproduce

  1. Have 2 users and create a DM and send some message between them in your environment;
  2. As admin user, go to "Administration" > "User Data Download" and make sure this option is enabled;
  3. As any of the users, go to "My Account" > "Preferences" and click at "Export My Data" or "Download My Data" located at the bottom of that page;
  4. When the cron runs it will fail with "TypeError: Cannot read property 'filter' of undefined" because roomId is a string and has no uids in it;

@mtmr0x
[FIX] userId in process download cron value adjust
ccb00d4 
- Change from `roomId` to `roomData` the value to get iterate on `uids` fields
@mtmr0x mtmr0x requested a review from sampaiodiego May 8, 2020 19:00
@mtmr0x mtmr0x self-assigned this May 8, 2020
@mtmr0x mtmr0x changed the title [FIX] userId in process download cron value adjust [FIX] Error during data export for DMs May 8, 2020
@sampaiodiego sampaiodiego added this to the 3.2.2 milestone May 8, 2020
@sampaiodiego sampaiodiego merged commit 75743f2 into develop May 8, 2020
@sampaiodiego sampaiodiego deleted the fix-process-download-cron branch May 8, 2020 20:40
gabriellsh added a commit that referenced this pull request May 9, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into inte…
eeb73d6 
…grations

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
  Regression: RegExp callbacks of settings were not being called (#17552)
  Meteor update to version 1.10.2 (#17533)
ggazzo added a commit that referenced this pull request May 10, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
b25b6ae 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Push settings enabled when push gateway is selected (#17582)
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
sampaiodiego pushed a commit that referenced this pull request May 11, 2020
@mtmr0x @sampaiodiego
[FIX] Error during data export for DMs (#17577)
7693020
@sampaiodiego sampaiodiego mentioned this pull request May 11, 2020
Merged
ggazzo added a commit that referenced this pull request May 11, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
89f7125 
* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
  Regression: RegExp callbacks of settings were not being called (#17552)
  Meteor update to version 1.10.2 (#17533)
  Fix default offline channel name when saving departments. (#17553)
  [NEW] Screen Lock settings - mobile client (#17523)
ggazzo added a commit that referenced this pull request May 12, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into remo…
1d1bbcd 
…ve-get-dom

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Push settings enabled when push gateway is selected (#17582)
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
  Regression: RegExp callbacks of settings were not being called (#17552)
  Meteor update to version 1.10.2 (#17533)
  Fix default offline channel name when saving departments. (#17553)
  [NEW] Screen Lock settings - mobile client (#17523)
@pierre-lehnen-rc pierre-lehnen-rc mentioned this pull request May 22, 2020
Closed
This was referenced May 28, 2020
Merged
Merged
This was referenced Aug 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

@mtmr0x mtmr0x

Labels
type: bug
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mtmr0x @sampaiodiego