[IMPROVE] Remove NRR #16071
Merged
[IMPROVE] Remove NRR #16071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
force-pushed
the
fix/remove-nrr
branch
from
9af113f
to
74751fb
Compare
sampaiodiego
requested changes
Dec 30, 2019
There was a problem hiding this comment.
It is throwing this error when showing uploaded images:
meteor.js?hash=857dafb4b9dff17e29ed8498a22ea5b1a3d6b41d:1059 Exception in template helper: TypeError: Converting circular structure to JSON
--> starting at object with constructor 'Object'
| property 'attachments' -> object with constructor 'Array'
| index 0 -> object with constructor 'Object'
--- property 'msg' closes the circle
at JSON.stringify (<anonymous>)
at Object.defaultCacheKey [as cacheKey] (http://localhost:3000/packages/modules.js?hash=0f4e9cdaba07cd69962d0866c0f7e4a1a1d5a30d:48719:17)
at Object.condition (http://localhost:3000/packages/modules.js?hash=0f4e9cdaba07cd69962d0866c0f7e4a1a1d5a30d:48750:27)
at http://localhost:3000/app/app.js?hash=4f13b9318623b6b8ecdeeb252866fdef382d127c:16199:53
at Array.filter (<anonymous>)
at _temp.getButtons (http://localhost:3000/app/app.js?hash=4f13b9318623b6b8ecdeeb252866fdef382d127c:16197:25)
at Object.messageActions (http://localhost:3000/app/app.js?hash=4f13b9318623b6b8ecdeeb252866fdef382d127c:61824:26)
at http://localhost:3000/packages/blaze.js?hash=2aa6f0f3b9cff09a60c7b659375479dd4e27e8af:2850:16
at http://localhost:3000/packages/blaze.js?hash=2aa6f0f3b9cff09a60c7b659375479dd4e27e8af:1566:16
at http://localhost:3000/packages/blaze.js?hash=2aa6f0f3b9cff09a60c7b659375479dd4e27e8af:2903:66
sampaiodiego
requested changes
Dec 30, 2019
There was a problem hiding this comment.
and this one when trying to collapse oembeded images
room.js:908 Uncaught TypeError: Cannot read property '_id' of undefined
at Object.click .collapse-switch (room.js:908)
at template.js:539
at Function.Template._withTemplateInstanceFunc (template.js:490)
at Blaze.View.<anonymous> (template.js:538)
at view.js:879
at Object.Blaze._withCurrentView (view.js:533)
at Blaze._DOMRange.<anonymous> (view.js:878)
at HTMLSpanElement.<anonymous> (events.js:47)
at HTMLDivElement.dispatch (modules.js?hash=0f4e9cdaba07cd69962d0866c0f7e4a1a1d5a30d:43483)
at HTMLDivElement.elemData.handle (modules.js?hash=0f4e9cdaba07cd69962d0866c0f7e4a1a1d5a30d:43291)
sampaiodiego
requested changes
Jan 2, 2020
…to fix/remove-nrr
…to fix/remove-nrr
…to fix/remove-nrr
…to fix/remove-nrr
sampaiodiego
previously approved these changes
Jan 6, 2020
sampaiodiego
force-pushed
the
fix/remove-nrr
branch
from
c674711
to
538c064
Compare
sampaiodiego
approved these changes
Jan 7, 2020
|
🎉 |
gabriellsh
added a commit
that referenced
this pull request
Jan 9, 2020
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits) fix space update on mongo, node and caddy [NEW] Enforce plain text emails converting from HTML when no text version supplied (#16063) [IMPROVE] Status Text form validation (#16121) [FIX] auto translate cache (#15768) [FIX] Save new password without confirmation (#16060) Disable PR Docker image build (#16141) [IMPROVE] Set the color of the cancel button on modals to #bdbebf for enhanced visibiity (#15913) [FIX] Break message-attachment text to the next line (#16039) [IMPROVE] Remove NRR (#16071) Add Cloud Info to translation dictionary (#16122) [FIX] Resolving console errors Administrations (#16139) [FIX] SafePorts: Ports 80, 8080 & 443 linked to respective protocols (#16108) [FIX] Drag and drop disabled when file upload is disabled (#16049) [FIX] Video message sent to wrong room (#16113) [FIX] "User not found" for direct messages (#16047) [BREAK] Removed room counter from sidebar (#16036) [FIX] Embedded style when using 'go' command (#16051) [NEW] Setting Top navbar in embedded mode (#16064) [FIX] Thread message icon overlapping text (#16083) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont need NRR anymore
closes #14989
closes #15604
closes #12765
closes #15917