Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Thread message icon overlapping text #16083

Merged
merged 4 commits into from
Jan 6, 2020

Conversation

gabriellsh
Copy link
Member

Closes #15448

When "Hide Avatars" is set in the user's preference, the thread icon will be placed on the right of the text so that everything aligns correctly.

Screenshot 2019-12-27 at 11 11 21

@zdumitru
Copy link
Contributor

@ggazzo Code review, please.

@ggazzo ggazzo added this to the 3.0.0 milestone Dec 27, 2019
@ggazzo ggazzo added the ui/ux label Dec 27, 2019
@ggazzo ggazzo merged commit a082a50 into develop Jan 6, 2020
@ggazzo ggazzo deleted the fix/thread-message-icon-no-avatar branch January 6, 2020 11:35
gabriellsh added a commit that referenced this pull request Jan 9, 2020
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits)
  fix space
  update on mongo, node and caddy
  [NEW] Enforce plain text emails converting from HTML when no text version supplied (#16063)
  [IMPROVE] Status Text form validation (#16121)
  [FIX] auto translate cache (#15768)
  [FIX] Save new password without confirmation (#16060)
  Disable PR Docker image build (#16141)
  [IMPROVE] Set the color of the cancel button on modals to #bdbebf for enhanced  visibiity (#15913)
  [FIX] Break message-attachment text to the next line (#16039)
  [IMPROVE] Remove NRR (#16071)
  Add Cloud Info to translation dictionary (#16122)
  [FIX] Resolving console errors Administrations (#16139)
  [FIX] SafePorts: Ports 80, 8080 & 443 linked to respective protocols (#16108)
  [FIX] Drag and drop disabled when file upload is disabled (#16049)
  [FIX] Video message sent to wrong room (#16113)
  [FIX] "User not found" for direct messages (#16047)
  [BREAK] Removed room counter from sidebar (#16036)
  [FIX] Embedded style when using 'go' command  (#16051)
  [NEW]  Setting Top navbar in embedded mode (#16064)
  [FIX] Thread message icon overlapping text (#16083)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread UI broken when Hide Avatars is set
3 participants