Rocket.Cat Shouldn't be Admin #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RocketChat/core Would like someone to test this before this is merged in, to double check my work. Appears to be a high priority for new installations which opt to use the develop builds since they have to make manual changes to get their first user to be admin. |
|
Oh ... I have just started implementation on 👍 I've tested it with a brand new install. It should clear the show-stopper as a hot fix. BUT hard-coding 'rocket.cat' might be an objection for longer term maintenance. idk One more @RocketChat/core vote and we're good 4 hotfix merge-down. |
|
lgtm |
|
Going to merge the pull request then, thanks @Sing-Li @sampaiodiego 👍 |
graywolf336
added a commit
that referenced
this pull request
Dec 12, 2015
Rocket.Cat Shouldn't be Admin, allowing first users to be admins again
|
👍 |
|
@graywolf336 makes sense, sorry and thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of the user
Rocket.Catfor integration and it being created as a first user has caused the "real" first users to no longer be made admin. This fixes #1632 and #1646