Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only a User should become Admin #5979

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Only a User should become Admin #5979

merged 1 commit into from
Feb 15, 2017

Conversation

ofpiyush
Copy link

@RocketChat/core

The bug:
The first "user" should be made admin. Instead rocket.cat becomes the admin in new installs.

History:

The Fix
Check type: user before making a user admin.

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2017

CLA assistant check
All committers have signed the CLA.

@ofpiyush
Copy link
Author

@dalchand please set your email and sign the cla

@dalchand
Copy link

@CLAassistant I have signed the CLA and set the email id as well

@graywolf336
Copy link
Contributor

You guys might need to do this again, as the commit was done with the email address configured as [email protected].

@ofpiyush
Copy link
Author

ofpiyush commented Feb 10, 2017

@graywolf336 Thanks for pointing it out. Fixed now :)

Copy link

@dalchand dalchand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if there is an admin of type 'user'

@engelgabriel engelgabriel merged commit 0ac50e4 into RocketChat:develop Feb 15, 2017
@engelgabriel engelgabriel modified the milestone: 0.53.0 Feb 15, 2017
@ofpiyush ofpiyush deleted the first_user_account_bug branch February 15, 2017 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants