Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Increase decoupling between React components and Blaze templates #16642

Merged
merged 17 commits into from
Apr 10, 2020

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Feb 18, 2020

  • Renders all React components in portals from a single tree
  • Creates React components from Blaze templates
  • Transparently transforms some small templates into components

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@tassoevan tassoevan marked this pull request as ready for review March 13, 2020 17:48
@tassoevan tassoevan requested a review from ggazzo March 13, 2020 17:48
ggazzo
ggazzo previously approved these changes Apr 6, 2020
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every react component working properly...

gabriellsh
gabriellsh previously approved these changes Apr 6, 2020
@ggazzo ggazzo merged commit 7a46c7d into develop Apr 10, 2020
ggazzo added a commit that referenced this pull request Apr 10, 2020
…/admin-root

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Increase decoupling between React components and Blaze templates (#16642)
  Fix self DM (#17239)
  [CHORE] Use REST API for sending audio messages (#17237)
  [FIX] Random errors on SAML logout (#17227)
  Collect metrics about meteor facts (#17216)
  Removed the invalid and unnecessary parameter clientAction. (#17224)
  [FIX] Wrong SAML Response Signature Validation (#16922)
  [FIX] SAML login errors not showing on UI (#17219)
  Add statistics and metrics about push queue (#17208)
  Regression: Fix users raw model (#17204)
ggazzo added a commit that referenced this pull request Apr 10, 2020
…/admin-root

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Increase decoupling between React components and Blaze templates (#16642)
  Fix self DM (#17239)
  [CHORE] Use REST API for sending audio messages (#17237)
  [FIX] Random errors on SAML logout (#17227)
  Collect metrics about meteor facts (#17216)
  Removed the invalid and unnecessary parameter clientAction. (#17224)
  [FIX] Wrong SAML Response Signature Validation (#16922)
  [FIX] SAML login errors not showing on UI (#17219)
  Add statistics and metrics about push queue (#17208)
  Regression: Fix users raw model (#17204)
@ggazzo ggazzo deleted the feat/react-root branch April 10, 2020 22:19
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants