-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Increase decoupling between React components and Blaze templates #16642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
force-pushed
the
feat/react-root
branch
from
February 20, 2020 01:45
af51505
to
9e3574c
Compare
ggazzo
requested changes
Mar 19, 2020
tassoevan
force-pushed
the
feat/react-root
branch
from
April 2, 2020 02:58
d4e4073
to
51080ff
Compare
ggazzo
previously approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every react component working properly...
gabriellsh
previously approved these changes
Apr 6, 2020
ggazzo
approved these changes
Apr 10, 2020
ggazzo
added a commit
that referenced
this pull request
Apr 10, 2020
…/admin-root * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Increase decoupling between React components and Blaze templates (#16642) Fix self DM (#17239) [CHORE] Use REST API for sending audio messages (#17237) [FIX] Random errors on SAML logout (#17227) Collect metrics about meteor facts (#17216) Removed the invalid and unnecessary parameter clientAction. (#17224) [FIX] Wrong SAML Response Signature Validation (#16922) [FIX] SAML login errors not showing on UI (#17219) Add statistics and metrics about push queue (#17208) Regression: Fix users raw model (#17204)
ggazzo
added a commit
that referenced
this pull request
Apr 10, 2020
…/admin-root * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Increase decoupling between React components and Blaze templates (#16642) Fix self DM (#17239) [CHORE] Use REST API for sending audio messages (#17237) [FIX] Random errors on SAML logout (#17227) Collect metrics about meteor facts (#17216) Removed the invalid and unnecessary parameter clientAction. (#17224) [FIX] Wrong SAML Response Signature Validation (#16922) [FIX] SAML login errors not showing on UI (#17219) Add statistics and metrics about push queue (#17208) Regression: Fix users raw model (#17204)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates React components from Blaze templatesTransparently transforms some small templates into components