[FIX] Room event emitter passing an invalid parameter when finding removed subscriptions #17224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
approved these changes
Apr 8, 2020
Merged
ggazzo
added a commit
that referenced
this pull request
Apr 10, 2020
…/admin-root * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Increase decoupling between React components and Blaze templates (#16642) Fix self DM (#17239) [CHORE] Use REST API for sending audio messages (#17237) [FIX] Random errors on SAML logout (#17227) Collect metrics about meteor facts (#17216) Removed the invalid and unnecessary parameter clientAction. (#17224) [FIX] Wrong SAML Response Signature Validation (#16922) [FIX] SAML login errors not showing on UI (#17219) Add statistics and metrics about push queue (#17208) Regression: Fix users raw model (#17204)
ggazzo
added a commit
that referenced
this pull request
Apr 10, 2020
…/admin-root * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Increase decoupling between React components and Blaze templates (#16642) Fix self DM (#17239) [CHORE] Use REST API for sending audio messages (#17237) [FIX] Random errors on SAML logout (#17227) Collect metrics about meteor facts (#17216) Removed the invalid and unnecessary parameter clientAction. (#17224) [FIX] Wrong SAML Response Signature Validation (#16922) [FIX] SAML login errors not showing on UI (#17219) Add statistics and metrics about push queue (#17208) Regression: Fix users raw model (#17204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clientActionvalue was being passed as a parameter, but the method was expecting theroom id.