Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: Better Push Notification code #17338

Merged
merged 17 commits into from
Apr 20, 2020
Merged

Improve: Better Push Notification code #17338

merged 17 commits into from
Apr 20, 2020

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Apr 17, 2020

- [ ] Remove setting Push_debug Will do on next PR to join with other changes

  • Convert to classes
  • Reduce Meteor dependency

Closes #10675

@rodrigok rodrigok modified the milestones: 3.1.2, 3.2.0 Apr 17, 2020
@rodrigok rodrigok marked this pull request as ready for review April 17, 2020 16:04
app/push/server/apn.js Outdated Show resolved Hide resolved
app/push/server/apn.js Outdated Show resolved Hide resolved
@RocketChat RocketChat deleted a comment from lgtm-com bot Apr 19, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Apr 19, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Apr 19, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Apr 19, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Apr 19, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Apr 19, 2020
@RocketChat RocketChat deleted a comment from lgtm-com bot Apr 19, 2020
@rodrigok rodrigok merged commit d9f5068 into develop Apr 20, 2020
@rodrigok rodrigok deleted the push branch April 20, 2020 14:37
ggazzo added a commit that referenced this pull request Apr 20, 2020
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Allow to send Agent custom fields through the Omnichannel CRM integration (#16286)
  [FIX] Spotify embed and collapsed (#17356)
  Improve: Better Push Notification code (#17338)
  LingoHub Update 🚀 (#17365)
  [FIX] Allow Screensharing in BBB Iframe (#17290)
  [NEW] Make the header for rooms clickable (#16762)
  Import data pagination (#17355)
  Allow to set a comment when forwarding omnichannel rooms. (#17353)
  [FIX] Web Client memory leak caused by the Emoji library (#17320)
  [FIX] Omnichannel room info panel opening whenever a message is sent (#17348)
  [FIX] New user added by admin doesn't receive random password email (#17249)
dudizilla added a commit that referenced this pull request Apr 21, 2020
…nto view-logs

* 'develop' of https://github.com/RocketChat/Rocket.Chat:
  [NEW] Allow to send Agent custom fields through the Omnichannel CRM integration (#16286)
  [FIX] Spotify embed and collapsed (#17356)
  Improve: Better Push Notification code (#17338)
  LingoHub Update 🚀 (#17365)
  [FIX] Allow Screensharing in BBB Iframe (#17290)
  [NEW] Make the header for rooms clickable (#16762)
  Import data pagination (#17355)
  Allow to set a comment when forwarding omnichannel rooms. (#17353)
  [FIX] Web Client memory leak caused by the Emoji library (#17320)
  [FIX] Omnichannel room info panel opening whenever a message is sent (#17348)
  [FIX] New user added by admin doesn't receive random password email (#17249)
  Bump https-proxy-agent from 2.2.1 to 2.2.4 (#17323)
  [NEW] Adds ability for Rocket.Chat Apps to create discussions (#16683)
  Add possibility to sort the Omnichannel current chats list by column (#17347)
  [IMPROVE] Redesign Administration > Import (#17289)
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS Push Notifications Option for Setting "mutable content".
2 participants