[FIX] Spotify embed and collapsed #17356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks really good mate! Thanks for your help. |
gabriellsh
approved these changes
Apr 20, 2020
ggazzo
approved these changes
Apr 20, 2020
ggazzo
changed the title
ggazzo
added a commit
that referenced
this pull request
Apr 20, 2020
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Allow to send Agent custom fields through the Omnichannel CRM integration (#16286) [FIX] Spotify embed and collapsed (#17356) Improve: Better Push Notification code (#17338) LingoHub Update 🚀 (#17365) [FIX] Allow Screensharing in BBB Iframe (#17290) [NEW] Make the header for rooms clickable (#16762) Import data pagination (#17355) Allow to set a comment when forwarding omnichannel rooms. (#17353) [FIX] Web Client memory leak caused by the Emoji library (#17320) [FIX] Omnichannel room info panel opening whenever a message is sent (#17348) [FIX] New user added by admin doesn't receive random password email (#17249)
dudizilla
added a commit
that referenced
this pull request
Apr 21, 2020
…nto view-logs * 'develop' of https://github.com/RocketChat/Rocket.Chat: [NEW] Allow to send Agent custom fields through the Omnichannel CRM integration (#16286) [FIX] Spotify embed and collapsed (#17356) Improve: Better Push Notification code (#17338) LingoHub Update 🚀 (#17365) [FIX] Allow Screensharing in BBB Iframe (#17290) [NEW] Make the header for rooms clickable (#16762) Import data pagination (#17355) Allow to set a comment when forwarding omnichannel rooms. (#17353) [FIX] Web Client memory leak caused by the Emoji library (#17320) [FIX] Omnichannel room info panel opening whenever a message is sent (#17348) [FIX] New user added by admin doesn't receive random password email (#17249) Bump https-proxy-agent from 2.2.1 to 2.2.4 (#17323) [NEW] Adds ability for Rocket.Chat Apps to create discussions (#16683) Add possibility to sort the Omnichannel current chats list by column (#17347) [IMPROVE] Redesign Administration > Import (#17289)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update the iframe url for spotify embed player.
Some urls generate a broken iframe in rocketchat.
Example url from spotify that is causing problem: https://open.spotify.com/album/185Tm1g5U7eMOrm3m9SQUh?highlight=spotify:track:4S8d14HvHb70ImctNgVzQQ
The url used for the embedded iframe in rocket chat is https://embed.spotify.com/?uri={{url}}, the new format is https://open.spotify.com/embed/(artist,album,song)/(id)
This url is provided in the twitter-player meta data.
I suggest that we use this value instead of generating one like you guys do in oembedYoutubeWidget.html.
There is also a problem with collapse of the embedded iframe for spotify.
I reused the same logic you used in oembedYoutubeWidget.html for the collapse component.
Before:
After:
Thank you