[FIX] FormData uploads not working #25069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougfabris
changed the title
dougfabris
previously approved these changes
Apr 6, 2022
dougfabris
approved these changes
Apr 6, 2022
gabriellsh
added a commit
that referenced
this pull request
Apr 7, 2022
…age-template-2 * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] FormData uploads not working (#25069) [FIX] Video and Audio not skipping forward (#19866) [FIX] NPS never finishing sending results (#25067) [IMPROVE] Add tooltip to sidebar room menu (#24405) [IMPROVE] Added tooltip options for message menu (#24431) [FIX] Replace encrypted text to Encrypted Message Placeholder (#24166) [FIX] Prevent sequential messages edited icon to hide on hover #24984 [IMPROVE] Improve active/hover colors in account sidebar (#25024) [FIX] Full error message is visible (#24856) Chore: Cancel running jobs if PR is updated (#24708)
sampaiodiego
pushed a commit
that referenced
this pull request
Apr 7, 2022
* fix useEndpointUpload hook * chore: remove log Co-authored-by: dougfabris <[email protected]>
Merged
gabriellsh
added a commit
that referenced
this pull request
Apr 14, 2022
…ove/rewrite-permissions * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Remove duplicated useUserRoom (#25180) Bump version to 4.6.2 [FIX] Database indexes not being created (#25101) [FIX] Deactivating user not working if user is the only room owner (#24933) Chore: TS migration SortList (#25167) [FIX] Deactivating user not working if user is the only room owner (#24933) Regression: Fix services Docker build on CI (#25181) [FIX] UserCard sanitization (#25089) Bump version to 4.6.1 [FIX] Proxy settings being ignored (#25022) [FIX] Invitation links don't redirect to the registration form (#25082) [FIX] FormData uploads not working (#25069) [FIX] NPS never finishing sending results (#25067) [FIX] Upgrade Tab showing for a split second (#25050) [FIX] UserAutoComplete not rendering UserAvatar correctly (#25055)
Merged
d-gubert
added a commit
that referenced
this pull request
May 4, 2022
* Bump version to 4.7.0-develop * Language update from LingoHub 🤖 (#25043) Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Robot LingoHub <[email protected]> * Bump body-parser from 1.19.2 to 1.20.0 in /ee/server/services (#25042) Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.19.2 to 1.20.0. - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.19.2...1.20.0) --- updated-dependencies: - dependency-name: body-parser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump template-file from 6.0.0 to 6.0.1 (#25002) Bumps [template-file](https://github.com/gsandf/template-file) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/gsandf/template-file/releases) - [Commits](https://github.com/gsandf/template-file/commits) --- updated-dependencies: - dependency-name: template-file dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 in /ee/server/services (#24991) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore: TS conversion folder client (#25031) * [FIX] UserAutoComplete not rendering UserAvatar correctly (#25055) * [FIX] Upgrade Tab showing for a split second (#25050) * Update pino and pino-pretty (#25052) * Chore: Remove Alpine image deps after using them (#25053) * Bump ejson from 2.2.1 to 2.2.2 (#25057) Bumps [ejson](https://github.com/primus/ejson) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/primus/ejson/releases) - [Commits](primus/ejson@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: ejson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore: Missing keys in APIsDisplay (#24464) * Chore: organize test files and fix code coverage (#24900) Co-authored-by: montini.ext tiago <[email protected]> Co-authored-by: Rodrigo Nascimento <[email protected]> Co-authored-by: Weslley de Campos <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> * Chore: Cancel running jobs if PR is updated (#24708) Co-authored-by: Thassio Victor <[email protected]> Signed-off-by: Debdut Chakraborty <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> * [FIX] Full error message is visible (#24856) * Full error message is visible * Remove `RawText` usage Co-authored-by: Tasso Evangelista <[email protected]> * [IMPROVE] Improve active/hover colors in account sidebar (#25024) * [FIX] Prevent sequential messages edited icon to hide on hover #24984 * [FIX] Replace encrypted text to Encrypted Message Placeholder (#24166) * show placeholder in place of cipher text * remove unnecessary line break Co-authored-by: Fábio Albuquerque <[email protected]> * [IMPROVE] Added tooltip options for message menu (#24431) * Added toolTip Options for Message Menu * Added more options tool tip for menu * [IMPROVE] Add tooltip to sidebar room menu (#24405) Co-authored-by: dougfabris <[email protected]> * First move to monorepo * CI using monorepo * Move eslint to meteor * Move husky to root * [FIX] NPS never finishing sending results (#25067) * [FIX] Video and Audio not skipping forward (#19866) * [FIX] Video and Audio not skipping forward * chore: add preload attr to video attachement Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: dougfabris <[email protected]> * [FIX] FormData uploads not working (#25069) * fix useEndpointUpload hook * chore: remove log Co-authored-by: dougfabris <[email protected]> * change react-i18n deps * Update deps * [NEW] Message Template React Component (#23971) Co-authored-by: Filipe Marins <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: juliajforesti <[email protected]> * [FIX] Invitation links don't redirect to the registration form (#25082) * [FIX] Proxy settings being ignored (#25022) Co-authored-by: Diego Sampaio <[email protected]> * [FIX] Use correct room property for call ended at (#24932) * [FIX] End call button disappearing when on-hold (#24936) * Bump eslint-plugin-anti-trojan-source from 1.0.6 to 1.1.0 (#25076) Bumps [eslint-plugin-anti-trojan-source](https://github.com/lirantal/eslint-plugin-anti-trojan-source) from 1.0.6 to 1.1.0. - [Release notes](https://github.com/lirantal/eslint-plugin-anti-trojan-source/releases) - [Commits](lirantal/eslint-plugin-anti-trojan-source@v1.0.6...v1.1.0) --- updated-dependencies: - dependency-name: eslint-plugin-anti-trojan-source dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [IMPROVE] Rename upgrade tab routes (#25097) * feat: rename upgrade tab url routes * feat: change getUpgradeTabType test url names * Move files to root * Regression: Fix CI monorepo build (#25107) * Regression: CI build fix * Chore: Convert Mailer to TS (#25121) Co-authored-by: Diego Sampaio <[email protected]> * Chore: Remove unused files (#25124) * Chore: Convert LivechatAgentActivity to raw model and TS (#25123) * Chore: Migrate oauth2server to typescript (#25126) * Chore: Convert admin custom sound to tsx (#25128) * Chore: Remove old files from removed Omnichannel feature (#25129) * Chore: Tests with Playwright (task: All works) (#25122) * [FIX] Message menu action not working on legacy messages. (#25148) * fix action call * Fix lint * Chore: Convert NotificationStatus to TS (#25125) Co-authored-by: Guilherme Gazzo <[email protected]> * Fix CI (#25168) * Chore: move definitions to packages (#25085) * [FIX] UserCard sanitization (#25089) * fix: UserCard sanitization * chore: fix customStatus margin * Regression: Fix services Docker build on CI (#25181) * [FIX] Deactivating user not working if user is the only room owner (#24933) * Chore: TS migration SortList (#25167) * Chore: Remove duplicated useUserRoom (#25180) * [IMPROVE] Rewrite Admin Permissions to Typescript Co-authored-by: gabriellsh <[email protected]> * Regression: Fix micro services Docker build (#25193) Co-authored-by: Guilherme Gazzo <[email protected]> * Chore: Template to generate packages (#25174) Co-authored-by: Diego Sampaio <[email protected]> * Chore: Tests with Playwright (task: ROC-28, 09-channels) (#25196) * [FIX] Added invalid password error message (#24714) * Added invalid password error message * Added new password error message Co-authored-by: dougfabris <[email protected]> * Regression: yarn dev triggers build dependencies (#25208) Co-authored-by: Diego Sampaio <[email protected]> * [FIX] Close room when dismiss wrap up call modal (#25056) * [FIX] AgentOverview analytics wrong departmentId parameter (#25073) * Chore: Update Livechat version (#25130) * Chore: Add error boundary to message component (#25223) * Fix add reaction (#25222) * fix: check if message unread to show read receipts (#25216) * fix: is own message on broadcast receipts (#25175) * [FIX] Desktop notification on multi-instance environments (#25220) * [IMPROVE] Added MaxNickNameLength and MaxBioLength constants (#25231) * Added MaxNickNameLength and MaxBioLength constants added above mentioned constants to remove magic numbers in a simple manner * code style fixes Co-authored-by: gabriellsh <[email protected]> * Change alignment (#25237) * [IMPROVE] Add support for filters on omnichannel/extensions endpoint * Chore: update OTR icon (#24521) * Replace shredder icon by stopwatch icon * stopwatch icon for otr msg * remove old otr css * remove some unnecessary files Co-authored-by: yash-rajpal <[email protected]> Co-authored-by: Yash Rajpal <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> * [NEW] Add expire index to integration history (#25087) * [FIX] VoIP disabled/enabled sequence puts voip agent in error state (#25230) * Clickup Task: https://app.clickup.com/t/22rjza5 Description: The issue occurs because when client turns on VoIP, server starts the connector in apps/meteor/app/voip/server/startup.ts. While the AMI connection is not established, client makes a call to API api/v1/connector.extension.getRegistrationInfoByUserId?id=<userId>. This requires the connection to be up. But because the connection establishment is not yet complete, apps/meteor/server/services/voip/connector/asterisk/CommandHandler.ts thrown an error. Solution : In apps/meteor/app/voip/server/startup.ts add await for Voip.init(). Once the init is done (Which internally waits for socket establishment), broadcast connector.statuschanged with the setting value (Enabled = true/false) In apps/meteor/client/providers/CallProvider/hooks/useVoipClient.ts make voipEnabled as a setting. And change it in the event listener for voip.statuschanged * change place where event was fired Co-authored-by: Kevin Aleman <[email protected]> * [FIX] Read receipts show with color gray when not read yet (#25244) * fix: show read receipts with color gray instead of hidden * fix: rename function * review Co-authored-by: gabriellsh <[email protected]> * [FIX] Client disconnection on network loss (#25170) * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Agent gets disconnected (or Unregistered) from asterisk in multiple ways. The goal is that agent should remain online unless agent explicitly logs off. Agent can stop receiving calls in multiple ways due to network loss. Network loss can happen in following ways. 1. User tries to switch the network. User experiences a glitch of disconnectivity. This can be simulated by turning the network off in the network tab of chrome's dev tool. This can disconnect the UA if the disconnection happens just before the registration refresh. 2. Second reason is when computer goes in sleep mode. 3. Third reason is that when asterisk is crashed/in maintenance mode/explicitly stopped. Solution: The idea is to detect the network disconnection and start the start the attempts to reconnect. The detection of the disconnection does not happen in case#1. The SIPUA's UserAgent transport does not call onDisconnected when network loss of such kind happens. To tackle this problem, window's online and offline event handlers are used. The number of retries is configurable but ideally it is to be kept at -1. Whenever disconnection happens, it should keep on trying to reconnect with increasing backoff time. This behaviour is useful when the asterisk is stopped. When the server is disconnected, it should be indicated on the phone button. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: 1. Replaced complex state handling in OmnichannelCallToggleReady.tsx. This was creating lot of erros. Added simple network status check and the phone button displays the latest state of things. 2. Some files were overwriting the changes in develop branch. Replaced that with correct changes. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Adding semi-colon to fix error. * Clickup Task : https://app.clickup.com/t/245c0d8 Description : Fixing review commnts. * removing unused files * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Renaming file to correct the spelling. Making necessary changes in index.ts * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Fixing incorrect spelling. * Add description to setting Co-authored-by: Kevin Aleman <[email protected]> * [IMPROVE] Add OTR Room States (#24565) * WIP: OTR Room States * lint * remove logs * new OTR components, remove modals * updating stories * convert js files to ts * correct a type * add missing translation * fix review * chore: remove OTRModal * fix: review Co-authored-by: dougfabris <[email protected]> * [FIX] room creation fails if app framework is disabled (#25200) * [IMPROVE] Performance for some Omnichannel features (#25217) * Regression: Show username and real name on the message system (#25254) * Regression: Avatar not loading on first direct message (#25211) * refactor: load from server all chatsubscription before open room * Fix review Co-authored-by: Guilherme Gazzo <[email protected]> * [FIX] Custom sound error toast messages (#24515) Co-authored-by: dougfabris <[email protected]> * Chore: Update Livechat to the last version (#25257) * [FIX] Add katex render to new message react template (#25239) * feat: add katex render to message react * fix: add boolean to type * fix Review * fix: review Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: dougfabris <[email protected]> * [FIX] Add select message to system message, thread preview and allow select on legacy template (#25251) * feat: add export message to system message and thread preview * fix: enable select on export message at legacy message template * Update apps/meteor/client/views/room/contextualBar/ExportMessages/MailExportForm.tsx * chore: update fuselage Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: dougfabris <[email protected]> * [FIX] Showing Blank Message Inside Report (#25007) * [FIX] Incorrect websocket url in livechat widget (#25261) * Chore: Bump Fuselage packages (#25259) * [NEW] Alpha Matrix Federation (#23688) Implement alpha support for Matrix Federation Co-authored-by: Aaron Ogle <[email protected]> Co-authored-by: Marcos Defendi <[email protected]> Co-authored-by: Rodrigo Nascimento <[email protected]> * [FIX] Message preview not available for queued chats (#25092) Co-authored-by: Kevin Aleman <[email protected]> * Regression: Fix federation Matrix bridge startup (#25273) * [NEW] Expand Apps Engine's environment variable allowed list (#23870) * Swap installed app page with marketplace apps page * Update app/apps/server/bridges/environmental.ts Co-authored-by: Debdut Chakraborty <[email protected]> * Fix cannot use dash in environment variable name Co-authored-by: Debdut Chakraborty <[email protected]> Co-authored-by: dougfabris <[email protected]> * Chore: Fix return type warnings (#25275) * feat: remove 'Company' email label on setup wiz (#25260) * Chore: Remove package-lock.json from houston files (#25280) * Chore: Add yarn plugin to check node and yarn version (#25224) * Chore: Minor dependency updates (#25269) * Chore: Add root package.json to houston files (#25286) * Bump version to 4.7.0-rc.0 * Regression: Use exact Node version on micro services Docker images (#25287) * Regression: Shows error if micro service cannot connect to Mongo (#25301) * Regression: Add isPending status to message (#25299) * Update CODEOWNERS * Regression: eslint not running on packages (#25305) * Regression: eslint not running on packages Co-authored-by: Guilherme Gazzo <[email protected]> * Bump version to 4.7.0-rc.1 * Regression: Revert Bugsnag version (#25313) * Chore: ensure scripts use cross-env and ignore some dirs (ROC-54) (#25218) * Regression: Add eslint package to micro services Dockerfile (#25311) * Regression: Fix reply button not working when hideFlexTab is enabled (#25306) * fix: add stop propagation on open thread * Fix type Co-authored-by: gabriellsh <[email protected]> * Regression: Change preference to be default legacy messages (#25255) * Regression: Fix the alpine image and dev UX installing matrix-rust-sdk-bindings (#25319) * Switch to forked version of matrix-appservice-bridge package * change yarn lock * add dependency that is installed indirectly but depended on directly * fix missing reference * fix lockfile Co-authored-by: Douglas Gubert <[email protected]> * Bump version to 4.7.0-rc.2 * Regression: Validate empty fields for Message template (#25250) * Remove null values from messa list * fix order * Fix * Fix type * review * Regression: Better MongoDB connection management for micro services (#25323) * Regression: Messages in new message template Crashing. (#25327) * Bump version to 4.7.0-rc.3 * Regression: Parser message when notify ephemeral message * Chore: Create README.md for Rest Typings (#25335) * Regression: bump onboarding-ui version (#25320) * fix: bump onboarding-ui version * fix: update adminData types * Regression: Fix multi line is not showing an empty line between lines (#25317) * fix: render empty line * remove style * add small comment Co-authored-by: gabriellsh <[email protected]> * Regression: Rocket.Chat Webapp not loading. (#25349) Co-authored-by: gabriellsh <[email protected]> * Regression: Fix English i18n react text (#25368) * Chore: Add options to debug stdout and rate limiter (#25336) * Bump version to 4.7.0-rc.4 * Chore: Bump fuselage (#25371) * Regression: Fix size of custom emoji and render emoji on thread message preview (#25314) * fix: custom emoji size * fix: emoji rendering undefined * fix: add parser to message thread preview * refactor: replace css property to css in js * fix: lint * refactor: change to is span * refactor: add message render component * update emoji component * fix: remove duplicate css import * fix: remove disable emoji props and add custom style * fix: remove unsued props * fix: render emoji render if not find emoji * fix: replace conditional * fix: remove conditional * fix: undo changes on big * Use fuselage * Add missing changes Co-authored-by: gabriellsh <[email protected]> * Regression: Fix clicking on visitor's chat in the sidebar does not display the chat window (#25380) * Bump version to 4.7.0-rc.5 * Bump version to 4.7.0 Co-authored-by: Diego Sampaio <[email protected]> Co-authored-by: lingohub[bot] <69908207+lingohub[bot]@users.noreply.github.com> Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Douglas Fabris <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Tiago Ulisses Montini <[email protected]> Co-authored-by: montini.ext tiago <[email protected]> Co-authored-by: Rodrigo Nascimento <[email protected]> Co-authored-by: Weslley de Campos <[email protected]> Co-authored-by: Debdut Chakraborty <[email protected]> Co-authored-by: Thassio Victor <[email protected]> Co-authored-by: Himanshu Malviya <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Yash Rajpal <[email protected]> Co-authored-by: Fábio Albuquerque <[email protected]> Co-authored-by: Martin Schoeler <[email protected]> Co-authored-by: Filipe Marins <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: juliajforesti <[email protected]> Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: Tiago Evangelista Pinto <[email protected]> Co-authored-by: Guilherme Jun Grillo <[email protected]> Co-authored-by: Júlia Jaeger Foresti <[email protected]> Co-authored-by: Aaron Ogle <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Weslley Campos <[email protected]> Co-authored-by: Jean Brito <[email protected]> Co-authored-by: Sidharth Mohanty <[email protected]> Co-authored-by: Paulo Bernardo <[email protected]> Co-authored-by: aakash-gitdev <[email protected]> Co-authored-by: Gabriel Freitas <[email protected]> Co-authored-by: yash-rajpal <[email protected]> Co-authored-by: amolghode1981 <[email protected]> Co-authored-by: Nishant Patel <[email protected]> Co-authored-by: Alan Sikora <[email protected]> Co-authored-by: Aaron Ogle <[email protected]> Co-authored-by: Marcos Defendi <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Cuong Huu Nguyen <[email protected]> Co-authored-by: souzaramon <[email protected]>
Merged
Merged
ear-dev
added a commit
to WideChat/Rocket.Chat
that referenced
this pull request
Jun 30, 2022
* Regression: Fix double value on holdTime and empty msg on last message (#24630) * Fix time fields and add wrap up * fix lint * Regression: Fix missing hold time and wrap up time missing * On cancel wrapup close room * Fix lint * Fix wrong code * Oh boy I need more sleep * Cherrypick fix * Bump version to 4.5.0-rc.3 * Regression: Queue counter aggregator for incoming/hanged calls (#24635) * Regression: Extension List panel UI not aligned with designs (#24645) * Regression: Server crashing if Voip credentials are invalid (#24646) * Fix wrong tab name. (#24647) * Regression: Error setting user avatars and mentioning rooms on Slack Import (#24585) * Add setting to control avatar rotation * Fix users' and rooms' mentions, fix setUserAvatar error on import * Remove unrelated changes * Fix missing username on imported messages * Reverted some changes * Fixed mentions * Removed duplicated code * Fix #23808 Co-authored-by: Pierre Lehnen <[email protected]> * Bump version to 4.5.0-rc.4 * Regression: Prevent button from losing state when rerendering (#24648) Authored by @amolghode1981 * Refresh server connection when MI server settings change (#24649) * Bump version to 4.5.0-rc.5 * Chore: Update Apps-Engine (#24651) * Update Apps-Engine * Update Apps-Engine * Bump version to 4.5.0-rc.6 * Bump version to 4.5.0 * Bump version to 4.6.0-develop * [IMPROVE] Updated links in readme (#24028) * updated links in readme * changed link to point to playlist * added email link * README: add missing verb Co-authored-by: Debdut Chakraborty <[email protected]> * [FIX] Typo in wrap-up term (#24661) * Bump url-parse from 1.5.7 to 1.5.10 (#24640) Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/ws from 8.2.3 to 8.5.2 in /ee/server/services (#24666) Bumps [@types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws) from 8.2.3 to 8.5.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws) --- updated-dependencies: - dependency-name: "@types/ws" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ts-node from 10.5.0 to 10.6.0 in /ee/server/services (#24667) Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 10.5.0 to 10.6.0. - [Release notes](https://github.com/TypeStrong/ts-node/releases) - [Commits](https://github.com/TypeStrong/ts-node/compare/v10.5.0...v10.6.0) --- updated-dependencies: - dependency-name: ts-node dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps-dev): Bump @types/mock-require from 2.0.0 to 2.0.1 (#24574) Bumps [@types/mock-require](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mock-require) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mock-require) --- updated-dependencies: - dependency-name: "@types/mock-require" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 2 to 3 (#24668) Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [FIX] Duplicated 'name' log key (#24590) * i18n: Language update from LingoHub 🤖 on 2022-02-28Z (#24644) * Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 * Apply suggestions from code review * Update packages/rocketchat-i18n/i18n/de.i18n.json Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> * Bump actions/setup-node from 2 to 3 (#24642) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2 to 3. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix messages being imported without sender's username (#24674) * Bump pino-pretty from 7.5.1 to 7.5.2 in /ee/server/services (#24689) Bumps [pino-pretty](https://github.com/pinojs/pino-pretty) from 7.5.1 to 7.5.2. - [Release notes](https://github.com/pinojs/pino-pretty/releases) - [Commits](https://github.com/pinojs/pino-pretty/compare/v7.5.1...v7.5.2) --- updated-dependencies: - dependency-name: pino-pretty dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore: Improvements on role syncing (ldap, oauth and saml) (#23824) * - created a single `syncUserRoles` function to be used by all login methods that can add and remove user roles. - converted `addUserRoles` and `removeUserFromRoles` to typescript - validate number of user seats available before converting a guest into a full user through role syncing. * typo * missed async call * Code review * Removed promise.await * sync call * Renamed async and sync version of addUserRoles to make the async be the explicitly named one * Renamed async and sync version of removeUserFromRoles to make the async be the explicitly named one * prettier * fixed type Co-authored-by: Tasso Evangelista <[email protected]> * Fix room's message count not being incremented on import (#24696) * Bump pino-pretty from 7.5.2 to 7.5.3 in /ee/server/services (#24698) Bumps [pino-pretty](https://github.com/pinojs/pino-pretty) from 7.5.2 to 7.5.3. - [Release notes](https://github.com/pinojs/pino-pretty/releases) - [Commits](https://github.com/pinojs/pino-pretty/compare/v7.5.2...v7.5.3) --- updated-dependencies: - dependency-name: pino-pretty dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Description : Fixing LGTM error. Instead of assignment, extra |=| was typed. (#24657) * [FIX] Nextcloud OAuth for incomplete token URL (#24476) * Bump ts-node from 10.6.0 to 10.7.0 in /ee/server/services (#24716) Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 10.6.0 to 10.7.0. - [Release notes](https://github.com/TypeStrong/ts-node/releases) - [Commits](https://github.com/TypeStrong/ts-node/compare/v10.6.0...v10.7.0) --- updated-dependencies: - dependency-name: ts-node dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [FIX] API Error preventing adding an email to users without one (like bot/app users) (#24709) * [FIX] Date Message Export Filter Fix (#24542) * Fix Date Filter in Export Messages * Comment fix * small fixes * [FIX] Components for user search (#24677) * Replace AutoComplete with MultiSelectFiltered on CreateTeamModal/UsersInput * regression fuselage packages * Handle loading state * fix UserAutoCompleteMultiple to handle id as a value * manage dataLabel filtering * Set default prop value * Add default valueIsId in UserAutoCompleteMultiple * remove log * Add missing `useMemo` dependency * Use function state dispatch to avoid triggering a new effect * Fix prettier formatting Co-authored-by: Tasso Evangelista <[email protected]> * Chore: Improve logger to allow log of `unknown` values (#24726) * [FIX] VoIP Enable/Disable setting on CallContext/CallProvider Notifications (#24607) * i18n: Language update from LingoHub 🤖 on 2022-03-07Z (#24717) * Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 * Update packages/rocketchat-i18n/i18n/es.i18n.json * Update packages/rocketchat-i18n/i18n/es.i18n.json * Apply suggestions from code review Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> * [FIX][ENTERPRISE] Presence micro service logic (#24724) * [FIX] DDP streamer errors (#24710) * [FIX] Show only available agents on extension association modal (#24680) Co-authored-by: Tiago Evangelista Pinto <[email protected]> * [FIX][ENTERPRISE] DDP streamer not sending data to all clients (#24738) * [IMPROVE][ENTERPRISE] Don't start presence monitor when running micro services (#24739) * [FIX] Typo and placeholder on wrap up call modal (#24737) * Chore: Fix Cypress tests (#24544) Co-authored-by: dougfabris <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> * Stop sending system messages when adding or removing a group from a team (#24743) * [FIX] Reload roomslist after successful deletion of a room from admin panel. (#23795) * fix- delete rooms from admin refresh roomlist and close contextual menu * added success toast message * fix-lint * fix-lint: missing dependency * Handle failing `eraseRoom` call * Handle list changes on save/archive too * Handle teams as a special case Co-authored-by: Tasso Evangelista <[email protected]> * Chore: resolve grammatical errors in Code of Conduct (#24759) * Chore: fix grammatical errors in FEATURES.md (#24771) * Fixed Grammatical Error * Chore: Fixed grammatical errors in Features * Fix sender if close room message has no id (#24683) * Chore: Update Livechat (#24754) * [FIX] Apple login script being loaded even when Apple Login is disabled. (#24760) * Regression: Improve Sidenav open/close handling and fixed codeql configs and E2E tests (#24756) * [FIX] Typo in wrap-up term (#24661) * [FIX] Duplicated 'name' log key (#24590) * Fix messages being imported without sender's username (#24674) * Fix room's message count not being incremented on import (#24696) * Description : Fixing LGTM error. Instead of assignment, extra |=| was typed. (#24657) * [FIX] Components for user search (#24677) * Replace AutoComplete with MultiSelectFiltered on CreateTeamModal/UsersInput * regression fuselage packages * Handle loading state * fix UserAutoCompleteMultiple to handle id as a value * manage dataLabel filtering * Set default prop value * Add default valueIsId in UserAutoCompleteMultiple * remove log * Add missing `useMemo` dependency * Use function state dispatch to avoid triggering a new effect * Fix prettier formatting Co-authored-by: Tasso Evangelista <[email protected]> * [FIX] VoIP Enable/Disable setting on CallContext/CallProvider Notifications (#24607) * [FIX] Show only available agents on extension association modal (#24680) Co-authored-by: Tiago Evangelista Pinto <[email protected]> * [FIX] Typo and placeholder on wrap up call modal (#24737) * Stop sending system messages when adding or removing a group from a team (#24743) * [FIX] Reload roomslist after successful deletion of a room from admin panel. (#23795) * fix- delete rooms from admin refresh roomlist and close contextual menu * added success toast message * fix-lint * fix-lint: missing dependency * Handle failing `eraseRoom` call * Handle list changes on save/archive too * Handle teams as a special case Co-authored-by: Tasso Evangelista <[email protected]> * Fix sender if close room message has no id (#24683) * Chore: Update Livechat (#24754) * [FIX] Apple login script being loaded even when Apple Login is disabled. (#24760) * Bump version to 4.5.1 * Chore: Micro services fixes and cleanup (#24753) * [IMPROVE] UX - VoIP Call Component (#24748) * [IMPROVE] Voip Extensions disabled state (#24750) * [FIX] Opening a new DM from user card (#24623) * Change `useRoomIcon` signature * Fix `IRoom[t]` and `ISubscription[t]` * Ensure `IRoom['uids']` is not mandatory * Fix some typings * [FIX] Show call icon only when user has extension associated (#24752) * Bump jschardet from 1.6.0 to 3.0.0 (#23121) Bumps [jschardet](https://github.com/aadsm/jschardet) from 1.6.0 to 3.0.0. - [Release notes](https://github.com/aadsm/jschardet/releases) - [Commits](https://github.com/aadsm/jschardet/compare/v1.6.0...v3.0.0) --- updated-dependencies: - dependency-name: jschardet dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pino from 7.8.0 to 7.8.1 in /ee/server/services (#24783) Bumps [pino](https://github.com/pinojs/pino) from 7.8.0 to 7.8.1. - [Release notes](https://github.com/pinojs/pino/releases) - [Commits](https://github.com/pinojs/pino/compare/v7.8.0...v7.8.1) --- updated-dependencies: - dependency-name: pino dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [FIX][ENTERPRISE] Auto reload feature of ddp-streamer micro service (#24793) * [FIX] Broken multiple OAuth integrations (#24705) * Chore: Convert server functions from javascript to typescript (#24384) Co-authored-by: Guilherme Gazzo <[email protected]> * [FIX] VoipExtensionsPage component call (#24792) * Regression: Register services right away (#24800) * [FIX] Prevent call button toggle when user is on call (#24758) * Chore: added Server Instances endpoint types (#24507) * [FIX] "livechat/webrtc.call" endpoint not working (#24804) * [FIX] Critical: Incorrect visitor getting assigned to a chat from apps (#24805) * [FIX] Prune Message issue (#24424) Co-authored-by: Debdut Chakraborty <[email protected]> * [FIX] Handle Other Formats inside Upload Avatar (#24226) Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Debdut Chakraborty <[email protected]> * Chore: added settings endpoint types (#24506) Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> * Chore: converted more hooks to typescript (#24628) Co-authored-by: Guilherme Gazzo <[email protected]> * [FIX] `PaginatedSelectFiltered` not handling changes (#24732) * Bump Fuselage packages to `@next` versions * Bump Fuselage packages to `@latest` versions * Chore: Get Settings Statistics (#24397) * Fix: logic and alias of Canned Response * Add File Upload Enable * Regression: Fix ParentRoomWithEndpointData in loop (#24809) * [FIX] "Match error" when converting a team to a channel (#24629) * Fix teams.listRoomsOfUser error when the canUserDelete param is sent * Chore: Skip local services changes when shutting down duplicated services (#24810) * Bump prometheus-gc-stats from 0.6.2 to 0.6.3 (#24803) Bumps [prometheus-gc-stats](https://github.com/SimenB/node-prometheus-gc-stats) from 0.6.2 to 0.6.3. - [Release notes](https://github.com/SimenB/node-prometheus-gc-stats/releases) - [Commits](https://github.com/SimenB/node-prometheus-gc-stats/compare/v0.6.2...v0.6.3) --- updated-dependencies: - dependency-name: prometheus-gc-stats dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump is-svg from 4.3.1 to 4.3.2 (#24801) Bumps [is-svg](https://github.com/sindresorhus/is-svg) from 4.3.1 to 4.3.2. - [Release notes](https://github.com/sindresorhus/is-svg/releases) - [Commits](https://github.com/sindresorhus/is-svg/compare/v4.3.1...v4.3.2) --- updated-dependencies: - dependency-name: is-svg dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore: APIClass types (#24747) Co-authored-by: Guilherme Gazzo <[email protected]> * [FIX] Revert AutoComplete (#24812) Co-authored-by: Guilherme Gazzo <[email protected]> * [IMPROVE] Voip Extensions disabled state (#24750) * [FIX] Opening a new DM from user card (#24623) * Change `useRoomIcon` signature * Fix `IRoom[t]` and `ISubscription[t]` * Ensure `IRoom['uids']` is not mandatory * Fix some typings * [FIX] Broken multiple OAuth integrations (#24705) * [FIX] VoipExtensionsPage component call (#24792) * [FIX] "livechat/webrtc.call" endpoint not working (#24804) * [FIX] Critical: Incorrect visitor getting assigned to a chat from apps (#24805) * [FIX] `PaginatedSelectFiltered` not handling changes (#24732) * Bump Fuselage packages to `@next` versions * Bump Fuselage packages to `@latest` versions * Regression: Fix ParentRoomWithEndpointData in loop (#24809) * [FIX] Revert AutoComplete (#24812) Co-authored-by: Guilherme Gazzo <[email protected]> * Bump version to 4.5.2 * [FIX] German translation for Monitore (#24785) * Chore: Add E2E tests for livechat/room.close (#24729) Co-authored-by: Kevin Aleman <[email protected]> * Chore: Add E2E tests for livechat/visitor (#24764) Co-authored-by: Kevin Aleman <[email protected]> * Bump @types/ws from 8.5.2 to 8.5.3 in /ee/server/services (#24820) Bumps [@types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws) from 8.5.2 to 8.5.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws) --- updated-dependencies: - dependency-name: "@types/ws" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump body-parser from 1.19.0 to 1.19.2 (#24821) Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.19.0 to 1.19.2. - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](https://github.com/expressjs/body-parser/compare/1.19.0...1.19.2) --- updated-dependencies: - dependency-name: body-parser dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/nodemailer from 6.4.2 to 6.4.4 (#24822) Bumps [@types/nodemailer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/nodemailer) from 6.4.2 to 6.4.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/nodemailer) --- updated-dependencies: - dependency-name: "@types/nodemailer" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/clipboard from 2.0.1 to 2.0.7 (#24832) Bumps [@types/clipboard](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/clipboard) from 2.0.1 to 2.0.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/clipboard) --- updated-dependencies: - dependency-name: "@types/clipboard" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/mailparser from 3.0.2 to 3.4.0 (#24833) Bumps [@types/mailparser](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mailparser) from 3.0.2 to 3.4.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mailparser) --- updated-dependencies: - dependency-name: "@types/mailparser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * i18n: Language update from LingoHub 🤖 on 2022-03-14Z (#24823) * Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 * Update packages/rocketchat-i18n/i18n/ca.i18n.json Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> * [FIX] Show only enabled departments on forward (#24829) * [FIX] Wrong param usage on queue summary call (#24799) * [FIX] VoIP button gets disabled whenever user status changes (#24789) * Clickup task : https://app.clickup.com/t/25jwe53 Description : Whenever the user state is changed (Explicitly or automatically by the virtue of user's inactivity) Voip component gets reloaded. Also during the reload of the page, the Voip component gets initialised multiple times, causing multiple websockets opened to asterisk. This happens because of the following facts: 1. The useEffect of useVoipClient, which creates the Voip component had user in its dependency list. 2. Whenever any user property changes, it would cause the useEffect to trigger and execute the entire initialisation of voip component. 3. When state change happens, it triggers update on all the components. So OmnichannelCallToggleReady gets re-rendered, also useVoipClient causes reinitialisation (user state change). 4. Now, when the useEffect of OmnichannelCallToggleReady gets executed, voipClient.getRegistrarState(); value is not |registered| because the state change has caused reinitialisation of voip component, which is not registered. 5. So again, the phone button value gets reset, the agent becomes unavailable. Fix: Even though the user state may change, user identity does not change. SIP client reinitialisation should happen only when userId changes. So the fix is not to add the entire userObject in the dependency list of the useEffect of useVoipClient hook. Instead 1. Create a state userId. 2. Add another useEffect watching the user. Whenever user becomes available or any user change happens, update the userId 3. The useEffect which does the voip client initialisation, should have the userId in the dependency list. When this is done, the Voip initialisation will happen only when userId changes. * Clickup task : https://app.clickup.com/t/25jwe53 Description : Realised that we have useUserId hook. As we have this hook, removed the useEffect which fetches the userId from user. Also removed the state. Instead added a constant userId. * Clickup Tasks: https://app.clickup.com/t/25jwe53 and https://app.clickup.com/t/22xdyn5 Description : Though this workspace was fix the first issue, it was realised that there are few other issues which are dependent on this(Not all may have a clickup task associated). This commit also fixes following : 1. Voip button does not get disabled when the user state changes. This happens because the user gets updated whenever the state change happens, this causes useVoipClient to reload this reload causes the reinitialsation of voipUser which initialises the connection again. 2. PR https://github.com/RocketChat/Rocket.Chat/pull/24752 : This PR fixes the icon display only when the extension associated with the user. This is also fixed as this was broken due to fix for #1. (THis was using user object, and we are now not using the user object directly in the useEffect for voipClient initialisation. 3. This fix broke the fact that whenever user gets associated with the agent, voip button gets active. But because we removed the use of user, This was broken too. This got fixed by the virtue of fixing #2, i.e using extension as a state. 4. Even though the association is deleted, agent was still receiving the call. This was because the SIP user was never unregistered and cleared when the association gets deleted. Fixed this issue by calling voipClient.stop() method. This would take care of unregistering if the UA is registered and then closing the webSocket. * [IMPROVE] Standarize queue behavior for managers and agents when subscribing (#24837) * Standarize queue behavior for managers and agents when subscribing to department/public queues * Fix import * Remove task from comment * [FIX] Match SidebarFooter component with design (#24838) * Regression: Role Sync not always working (#24850) * [FIX] Broken build caused by PRs modifying same file differently(#24863) Co-authored-by: Tiago Evangelista Pinto <[email protected]> * [FIX] Disable voip button when call is in progress (#24864) * Bump pino-pretty from 7.5.3 to 7.5.4 in /ee/server/services (#24870) Bumps [pino-pretty](https://github.com/pinojs/pino-pretty) from 7.5.3 to 7.5.4. - [Release notes](https://github.com/pinojs/pino-pretty/releases) - [Commits](https://github.com/pinojs/pino-pretty/compare/v7.5.3...v7.5.4) --- updated-dependencies: - dependency-name: pino-pretty dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pino from 7.8.1 to 7.9.1 in /ee/server/services (#24869) Bumps [pino](https://github.com/pinojs/pino) from 7.8.1 to 7.9.1. - [Release notes](https://github.com/pinojs/pino/releases) - [Commits](https://github.com/pinojs/pino/compare/v7.8.1...v7.9.1) --- updated-dependencies: - dependency-name: pino dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [FIX] auto-join team channels not honoring user preferences (#24779) * fixed subscriptions w/o notifications pref * added tests * typo * removed unwantend method call * moved some tests to sync methods * finally fixed tests * Chore: Fix MongoDB versions on release notes (#24877) * [FIX] Missing dependency on useEffect at CallProvider (#24882) * [IMPROVE] New omnichannel statistics and async statistics processing. (#24749) * re-pushing changes * fixing code review suggestions and changed requirements * Useless code removed * fixing CI complaints * Missing await * Language update from LingoHub 🤖 (#24895) Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Robot LingoHub <[email protected]> * [FIX] Apple OAuth (#24879) * [FIX] Ignore customClass on messages (#24845) * [FIX] Wrong business hour behavior (#24896) * [FIX] Custom script not being fired (#24901) * [IMPROVE] UX - VoIP Call Component (#24748) * [FIX] Show call icon only when user has extension associated (#24752) * [FIX] VoIP button gets disabled whenever user status changes (#24789) * Clickup task : https://app.clickup.com/t/25jwe53 Description : Whenever the user state is changed (Explicitly or automatically by the virtue of user's inactivity) Voip component gets reloaded. Also during the reload of the page, the Voip component gets initialised multiple times, causing multiple websockets opened to asterisk. This happens because of the following facts: 1. The useEffect of useVoipClient, which creates the Voip component had user in its dependency list. 2. Whenever any user property changes, it would cause the useEffect to trigger and execute the entire initialisation of voip component. 3. When state change happens, it triggers update on all the components. So OmnichannelCallToggleReady gets re-rendered, also useVoipClient causes reinitialisation (user state change). 4. Now, when the useEffect of OmnichannelCallToggleReady gets executed, voipClient.getRegistrarState(); value is not |registered| because the state change has caused reinitialisation of voip component, which is not registered. 5. So again, the phone button value gets reset, the agent becomes unavailable. Fix: Even though the user state may change, user identity does not change. SIP client reinitialisation should happen only when userId changes. So the fix is not to add the entire userObject in the dependency list of the useEffect of useVoipClient hook. Instead 1. Create a state userId. 2. Add another useEffect watching the user. Whenever user becomes available or any user change happens, update the userId 3. The useEffect which does the voip client initialisation, should have the userId in the dependency list. When this is done, the Voip initialisation will happen only when userId changes. * Clickup task : https://app.clickup.com/t/25jwe53 Description : Realised that we have useUserId hook. As we have this hook, removed the useEffect which fetches the userId from user. Also removed the state. Instead added a constant userId. * Clickup Tasks: https://app.clickup.com/t/25jwe53 and https://app.clickup.com/t/22xdyn5 Description : Though this workspace was fix the first issue, it was realised that there are few other issues which are dependent on this(Not all may have a clickup task associated). This commit also fixes following : 1. Voip button does not get disabled when the user state changes. This happens because the user gets updated whenever the state change happens, this causes useVoipClient to reload this reload causes the reinitialsation of voipUser which initialises the connection again. 2. PR https://github.com/RocketChat/Rocket.Chat/pull/24752 : This PR fixes the icon display only when the extension associated with the user. This is also fixed as this was broken due to fix for #1. (THis was using user object, and we are now not using the user object directly in the useEffect for voipClient initialisation. 3. This fix broke the fact that whenever user gets associated with the agent, voip button gets active. But because we removed the use of user, This was broken too. This got fixed by the virtue of fixing #2, i.e using extension as a state. 4. Even though the association is deleted, agent was still receiving the call. This was because the SIP user was never unregistered and cleared when the association gets deleted. Fixed this issue by calling voipClient.stop() method. This would take care of unregistering if the UA is registered and then closing the webSocket. * [FIX] Wrong param usage on queue summary call (#24799) * [FIX] Show only enabled departments on forward (#24829) * [IMPROVE] Standarize queue behavior for managers and agents when subscribing (#24837) * Standarize queue behavior for managers and agents when subscribing to department/public queues * Fix import * Remove task from comment * [FIX] Match SidebarFooter component with design (#24838) * [FIX] Broken build caused by PRs modifying same file differently(#24863) Co-authored-by: Tiago Evangelista Pinto <[email protected]> * [FIX] Disable voip button when call is in progress (#24864) * Chore: Fix MongoDB versions on release notes (#24877) * [FIX] Custom script not being fired (#24901) * Bump version to 4.5.3 * [FIX] Push privacy config to not show username not being respected (#24606) * [FIX][ENTERPRISE] Notifications not being sent by ddp-streamer (#24831) * [FIX] DDP Rate Limiter Translation key (#24898) * Chore: Remove old scripts (#24911) * [IMPROVE] Adding new statistics related to voip and omnichannel (#24887) Co-authored-by: Kevin Aleman <[email protected]> * [NEW] Telemetry Events (#24781) * stats events api and engagement dashboard * Engagement Dashboard stats * Message Auditing * Jitsi Stats * otr stats * improvements * rewrite telemetry events * improved types and queries * telemetry events generics * otr stats update * auth required in telemetry endpoint * Update app/otr/client/rocketchat.otr.room.js Co-authored-by: Pierre Lehnen <[email protected]> * fixed api calls * removed console.log() * lint * fixed more broken API calls * fixed types * incrementValueByID + moved OTR telemtry call from end() to acknoledge() * IStats update Co-authored-by: Leonardo Ostjen Couto <[email protected]> Co-authored-by: Pierre Lehnen <[email protected]> * [FIX] Several issues related to custom roles (#24052) * [FIX] `roles.delete` not properly checking if subscription based roles are being used * Improved typings * Added error message in development if a role scope is passed to a method that expects a scope value * Fix prettier rules * Replace role name by id in findUsersInRole * Fix Users In Role page * Fix role not available error * Fix Users in Role screen for users' custom roles * Check if role exists before adding to user * Fix Remove user from role * Fix roles _id field * Partial commit of changes * some changes * merge fixes * Replaces some names with ids * parseCSV util * ts * Changes from yesterday * api * Removed more roleNames * typo * roles.getUsersInRole * findUsersInRole * fixed import path * removeUserFromRoles * Removed comments * removed comment * migration * Imports * types * createOrUpdateProtectedRole * Removed DetailedError * tests * await server fresh install * Update server/lib/roles/updateRole.ts Co-authored-by: Matheus Barbosa Silva <[email protected]> * MeteorErrors * Display role name in UserInfo when description is not available * Migrate roleNames * syntax * syntax * Review fixes Co-authored-by: Matheus Barbosa Silva <[email protected]> Co-authored-by: matheusbsilva137 <[email protected]> * Bump version to 4.6.0-rc.0 * [FIX] External search providers not working (#24860) * [FIX] Duplicated "jump to message" button on starred messages (#24867) * Regression: Fix account service login expiration (#24920) * [NEW] Engagement Statistics (#24777) * White label stats * lint fix * Invites * Models Methods * Teams stats and 2fa stats * Users Created Stats * Import Fix * Import Fix 2 * team fix * moved to statistics.ts Co-authored-by: Leonardo Ostjen Couto <[email protected]> * Regression: Call doesn't stop ringing after agent unregistration (#24908) * [FIX] Force name to string (#24930) * Force name and email to string If its ever anything but a string. Like an array for example It borks the user list because of the aggregations done to bring in users * Removed force to string for email Downstream user creation logic handles this so its safe to let go as is * Log number of values received per attribute * Allow multiple emails Co-authored-by: Pierre Lehnen <[email protected]> * [FIX] LDAP avatars being rotated according to metadata even if the setting to rotate uploads is off (#24320) Co-authored-by: Pierre Lehnen <[email protected]> * [FIX] Force name to string (#24930) * Force name and email to string If its ever anything but a string. Like an array for example It borks the user list because of the aggregations done to bring in users * Removed force to string for email Downstream user creation logic handles this so its safe to let go as is * Log number of values received per attribute * Allow multiple emails Co-authored-by: Pierre Lehnen <[email protected]> * Bump version to 4.5.4 * Bump version to 4.6.0-rc.1 * Regression: Fix unexpected errors breaking ddp-streamer (#24948) * [FIX] Register with Secret URL (#24921) * render Login Form on correct hash * remove log * Language update from LingoHub 🤖 (#24971) Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Robot LingoHub <[email protected]> * Chore: add some missing REST definitions (#24925) * Fix room archived/unarchived system messages (#24897) * Revert "[NEW] Engagement Statistics (#24777)" (#24989) This reverts commit f79e7eb5bbe13a4f577c648c254110fcf579f322. * Chore: Update Livechat (#24990) * Chore: Storybook mocking and examples improved (#24969) * Upgrade Storybook * Replace `ts-loader` with `babel-loader` * Rearrange some stories * Rearrange some stories * Move `NotAuthorizedPage` * Rearrange some stories * Rearrange some stories * Rearrange some stories * Rearrange some stories * Rearrange some stories * Squashed commit of the following: commit f0cda61edf0c6d9341c87096ebaa1e014eb8747a Author: Tiago Evangelista Pinto <[email protected]> Date: Fri Mar 25 15:45:59 2022 -0300 fix review commit 4113ffb9336d661bd31711155738ca6f1bc4c3e1 Author: Tiago Evangelista Pinto <[email protected]> Date: Thu Mar 24 17:34:48 2022 -0300 fix commit 82e14b6c187b78b2ca73e6fbcbeb524443b6a7ad Author: Tiago Evangelista Pinto <[email protected]> Date: Thu Mar 24 17:18:57 2022 -0300 fix * Rearrange some stories * Rearrange some stories * Improve `ServerProviderMock` with parameters * Expand story mocking capabilities * Move mocks * Fix lint issues * [FIX] room message not load when is a new message (#24955) * fix: if not find room on subscription try on chatroom * refactor: remove aditional request and aadd rid * refactor: remove unsed async * fields -> projection * fix link to new users on spotlight Co-authored-by: Pierre Lehnen <[email protected]> * Bump version to 4.6.0-rc.2 * [FIX] High CPU usage caused by CallProvider (#24994) * fix infinite loop * fix Co-authored-by: Guilherme Gazzo <[email protected]> * Bump version to 4.6.0-rc.3 * Chore: Update Livechat (#24990) * [FIX] room message not load when is a new message (#24955) * fix: if not find room on subscription try on chatroom * refactor: remove aditional request and aadd rid * refactor: remove unsed async * fields -> projection * fix link to new users on spotlight Co-authored-by: Pierre Lehnen <[email protected]> * [FIX] High CPU usage caused by CallProvider (#24994) * fix infinite loop * fix Co-authored-by: Guilherme Gazzo <[email protected]> * Bump version to 4.5.5 * Clickup task : https://app.clickup.com/t/29gujj8 (#24980) Description : In ACDQueue.ts, When there is no queue available on asterisk, onQueueSummary never gets executed. It directly calls onQueueSummaryComplete Because result.queueSummary never got initialised, result is undefined. This causes getQueueDetails fails as it assumes that there will be a valid queue summary. To fix this, set result.queueSummary to empty array if it does not already exist in onQueueSummaryComplete of ACDQueue.ts * [NEW] Upgrade Tab (#24835) * Add Upgrade tab on sidebar * chore: add new icons * [NEW] UpgradeTab Page Error (#24851) * new: upgradeTab error * remove route Co-authored-by: gabriellsh <[email protected]> * [NEW] UpgradeTab Iframe (#24881) * WIP * chore: code org * Iframe navigation * WIP tabtype endpoint * chore: revert endpoint name * new: connect UpgradePageError to iframe page * WIP tabtype 2 * Update links to redirect * Wip had trial before * update cloud.getUpgradeTabParams endpoint * Add tests * Remove logs Co-authored-by: gabriellsh <[email protected]> * fix: missing hasRole function * fix: upgradeTab routing * chore: missing import * fix: setting value * fix: update setting value on sync * fix: missing isLoading in route * Small screen, language and review * Avoid unnecessary query * chore: review * Retype `useUpgradeTabParams` * Rename `UpgradeTabVariants` as `UpgradeTabVariant` * Remove placeholder data; fix route redirection * Replace history instead of pushing it * fix: gold license & trialEnd date * wip * Rework `useUpgradeTabParams` * fix: valid licenses * fix: query loading * fix: license type Co-authored-by: dougfabris <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Pierre Lehnen <[email protected]> * Regression: Custom roles displaying ID instead of name on some admin screens (#24999) * Regression: Custom roles displaying ID instead of name on admin screens * fix: missing NewRolePage role name validation * Update client/views/admin/users/AddUser.js Co-authored-by: Douglas Fabris <[email protected]> * filter * prettier Co-authored-by: dougfabris <[email protected]> * Chore: Bump Fuselage packages (#25015) * chore: bump version * Bump to 0.31.9 * Workaround misuse of `Box`'s `withRichContent` prop Co-authored-by: Tasso Evangelista <[email protected]> * Regression: Add createdOTR index (#25017) * Bump version to 4.6.0-rc.4 * Bump @rocket.chat/string-helpers in /ee/server/services (#25018) Bumps [@rocket.chat/string-helpers](https://github.com/RocketChat/Rocket.Chat.Fuselage/tree/HEAD/packages/string-helpers) from 0.31.4 to 0.31.9. - [Release notes](https://github.com/RocketChat/Rocket.Chat.Fuselage/releases) - [Changelog](https://github.com/RocketChat/Rocket.Chat.Fuselage/blob/develop/CHANGELOG.md) - [Commits](https://github.com/RocketChat/Rocket.Chat.Fuselage/commits/v0.31.9/packages/string-helpers) --- updated-dependencies: - dependency-name: "@rocket.chat/string-helpers" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @rocket.chat/message-parser in /ee/server/services (#25019) Bumps [@rocket.chat/message-parser](https://github.com/RocketChat/Rocket.Chat.Fuselage/tree/HEAD/packages/message-parser) from 0.31.4 to 0.31.9. - [Release notes](https://github.com/RocketChat/Rocket.Chat.Fuselage/releases) - [Changelog](https://github.com/RocketChat/Rocket.Chat.Fuselage/blob/develop/CHANGELOG.md) - [Commits](https://github.com/RocketChat/Rocket.Chat.Fuselage/commits/v0.31.9/packages/message-parser) --- updated-dependencies: - dependency-name: "@rocket.chat/message-parser" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @rocket.chat/ui-kit from 0.31.4 to 0.31.9 in /ee/server/services (#25020) Bumps [@rocket.chat/ui-kit](https://github.com/RocketChat/Rocket.Chat.Fuselage) from 0.31.4 to 0.31.9. - [Release notes](https://github.com/RocketChat/Rocket.Chat.Fuselage/releases) - [Changelog](https://github.com/RocketChat/Rocket.Chat.Fuselage/blob/develop/CHANGELOG.md) - [Commits](https://github.com/RocketChat/Rocket.Chat.Fuselage/compare/v0.31.4...v0.31.9) --- updated-dependencies: - dependency-name: "@rocket.chat/ui-kit" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @rocket.chat/emitter from 0.31.4 to 0.31.9 in /ee/server/services (#25021) Bumps [@rocket.chat/emitter](https://github.com/RocketChat/Rocket.Chat.Fuselage) from 0.31.4 to 0.31.9. - [Release notes](https://github.com/RocketChat/Rocket.Chat.Fuselage/releases) - [Changelog](https://github.com/RocketChat/Rocket.Chat.Fuselage/blob/develop/CHANGELOG.md) - [Commits](https://github.com/RocketChat/Rocket.Chat.Fuselage/compare/v0.31.4...v0.31.9) --- updated-dependencies: - dependency-name: "@rocket.chat/emitter" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump version to 4.6.0-rc.5 * Bump version to 4.6.0 * [FIX] UserAutoComplete not rendering UserAvatar correctly (#25055) * [FIX] Upgrade Tab showing for a split second (#25050) * [FIX] NPS never finishing sending results (#25067) * [FIX] FormData uploads not working (#25069) * fix useEndpointUpload hook * chore: remove log Co-authored-by: dougfabris <[email protected]> * [FIX] Invitation links don't redirect to the registration form (#25082) * [FIX] Proxy settings being ignored (#25022) Co-authored-by: Diego Sampaio <[email protected]> * Bump version to 4.6.1 * [FIX] Deactivating user not working if user is the only room owner (#24933) * [FIX] Database indexes not being created (#25101) * Bump version to 4.6.2 * [FIX] Desktop notification on multi-instance environments (#25220) * Bump version to 4.6.3 * Merge branch 'develop_pwa' of https://github.com/WideChat/Rocket.Chat into develop_pwa-catchup-596881e * Add package.lock * Fix import for filters page * Fix viasat bot role creation * Fix lint error * Update package-lock * Remove duplicate translation key * Fix merge problems * Add package lock * Remove cypress UI test workflow * Disable E2E UI tests for github workflow * Add catchup to PR title checker * Add push to acc-ecr workflow * Add pushm to message check * Fix missing test method * Add missed catchup changes * Add telephoneNumber as optional field Co-authored-by: Martin Schoeler <[email protected]> Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: amolghode1981 <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Renato Becker <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Douglas Gubert <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: P Aswini Kumar <[email protected]> Co-authored-by: Debdut Chakraborty <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lingohub[bot] <69908207+lingohub[bot]@users.noreply.github.com> Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: eduardofcabrera <[email protected]> Co-authored-by: Júlia Jaeger Foresti <[email protected]> Co-authored-by: Tiago Evangelista Pinto <[email protected]> Co-authored-by: Rodrigo Nascimento <[email protected]> Co-authored-by: dougfabris <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Aman-Maheshwari <[email protected]> Co-authored-by: Aadish Jain <[email protected]> Co-authored-by: Cuong Huu Nguyen <[email protected]> Co-authored-by: Felipe <[email protected]> Co-authored-by: Nishant Patel <[email protected]> Co-authored-by: Fábio Albuquerque <[email protected]> Co-authored-by: JMoVS <[email protected]> Co-authored-by: Pedro Muramatsu <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Leonardo Ostjen Couto <[email protected]> Co-authored-by: Cauê Felchar <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: matheusbsilva137 <[email protected]> Co-authored-by: Allan Ribeiro <[email protected]> Co-authored-by: Thomas Kurz <[email protected]> Co-authored-by: Himanshu Malviya <[email protected]> Co-authored-by: Aaron Ogle <[email protected]> Co-authored-by: Allan RIbeiro <[email protected]> Co-authored-by: Yash Rajpal <[email protected]> Co-authored-by: Gerzon Z <[email protected]> Co-authored-by: Filipe Marins <[email protected]> Co-authored-by: Sidharth Mohanty <[email protected]> Co-authored-by: Aditya Bhardwaj <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #25041
Steps to test or reproduce
Further comments