Regression: Avatar not loading on first direct message #25211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipemarins
changed the title
filipemarins
force-pushed
the
load-avatar
branch
from
01b1bf2
to
a79df25
Compare
ggazzo
changed the title
gabriellsh
approved these changes
Apr 20, 2022
gabriellsh
added a commit
that referenced
this pull request
Apr 25, 2022
…veNull * 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits) Regression: Use exact Node version on micro services Docker images (#25287) Chore: Add root package.json to houston files (#25286) Chore: Minor dependency updates (#25269) Chore: Add yarn plugin to check node and yarn version (#25224) Chore: Remove package-lock.json from houston files (#25280) feat: remove 'Company' email label on setup wiz (#25260) Chore: Fix return type warnings (#25275) [NEW] Expand Apps Engine's environment variable allowed list (#23870) Regression: Fix federation Matrix bridge startup (#25273) [FIX] Message preview not available for queued chats (#25092) [NEW] Alpha Matrix Federation (#23688) Chore: Bump Fuselage packages (#25259) [FIX] Incorrect websocket url in livechat widget (#25261) [FIX] Showing Blank Message Inside Report (#25007) [FIX] Add select message to system message, thread preview and allow select on legacy template (#25251) [FIX] Add katex render to new message react template (#25239) Chore: Update Livechat to the last version (#25257) [FIX] Custom sound error toast messages (#24515) Regression: Avatar not loading on first direct message (#25211) Bump version to 4.6.3 ...
Merged
d-gubert
added a commit
that referenced
this pull request
May 4, 2022
* Bump version to 4.7.0-develop * Language update from LingoHub 🤖 (#25043) Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Robot LingoHub <[email protected]> * Bump body-parser from 1.19.2 to 1.20.0 in /ee/server/services (#25042) Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.19.2 to 1.20.0. - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.19.2...1.20.0) --- updated-dependencies: - dependency-name: body-parser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump template-file from 6.0.0 to 6.0.1 (#25002) Bumps [template-file](https://github.com/gsandf/template-file) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/gsandf/template-file/releases) - [Commits](https://github.com/gsandf/template-file/commits) --- updated-dependencies: - dependency-name: template-file dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 in /ee/server/services (#24991) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore: TS conversion folder client (#25031) * [FIX] UserAutoComplete not rendering UserAvatar correctly (#25055) * [FIX] Upgrade Tab showing for a split second (#25050) * Update pino and pino-pretty (#25052) * Chore: Remove Alpine image deps after using them (#25053) * Bump ejson from 2.2.1 to 2.2.2 (#25057) Bumps [ejson](https://github.com/primus/ejson) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/primus/ejson/releases) - [Commits](primus/ejson@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: ejson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore: Missing keys in APIsDisplay (#24464) * Chore: organize test files and fix code coverage (#24900) Co-authored-by: montini.ext tiago <[email protected]> Co-authored-by: Rodrigo Nascimento <[email protected]> Co-authored-by: Weslley de Campos <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> * Chore: Cancel running jobs if PR is updated (#24708) Co-authored-by: Thassio Victor <[email protected]> Signed-off-by: Debdut Chakraborty <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> * [FIX] Full error message is visible (#24856) * Full error message is visible * Remove `RawText` usage Co-authored-by: Tasso Evangelista <[email protected]> * [IMPROVE] Improve active/hover colors in account sidebar (#25024) * [FIX] Prevent sequential messages edited icon to hide on hover #24984 * [FIX] Replace encrypted text to Encrypted Message Placeholder (#24166) * show placeholder in place of cipher text * remove unnecessary line break Co-authored-by: Fábio Albuquerque <[email protected]> * [IMPROVE] Added tooltip options for message menu (#24431) * Added toolTip Options for Message Menu * Added more options tool tip for menu * [IMPROVE] Add tooltip to sidebar room menu (#24405) Co-authored-by: dougfabris <[email protected]> * First move to monorepo * CI using monorepo * Move eslint to meteor * Move husky to root * [FIX] NPS never finishing sending results (#25067) * [FIX] Video and Audio not skipping forward (#19866) * [FIX] Video and Audio not skipping forward * chore: add preload attr to video attachement Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: dougfabris <[email protected]> * [FIX] FormData uploads not working (#25069) * fix useEndpointUpload hook * chore: remove log Co-authored-by: dougfabris <[email protected]> * change react-i18n deps * Update deps * [NEW] Message Template React Component (#23971) Co-authored-by: Filipe Marins <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: juliajforesti <[email protected]> * [FIX] Invitation links don't redirect to the registration form (#25082) * [FIX] Proxy settings being ignored (#25022) Co-authored-by: Diego Sampaio <[email protected]> * [FIX] Use correct room property for call ended at (#24932) * [FIX] End call button disappearing when on-hold (#24936) * Bump eslint-plugin-anti-trojan-source from 1.0.6 to 1.1.0 (#25076) Bumps [eslint-plugin-anti-trojan-source](https://github.com/lirantal/eslint-plugin-anti-trojan-source) from 1.0.6 to 1.1.0. - [Release notes](https://github.com/lirantal/eslint-plugin-anti-trojan-source/releases) - [Commits](lirantal/eslint-plugin-anti-trojan-source@v1.0.6...v1.1.0) --- updated-dependencies: - dependency-name: eslint-plugin-anti-trojan-source dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [IMPROVE] Rename upgrade tab routes (#25097) * feat: rename upgrade tab url routes * feat: change getUpgradeTabType test url names * Move files to root * Regression: Fix CI monorepo build (#25107) * Regression: CI build fix * Chore: Convert Mailer to TS (#25121) Co-authored-by: Diego Sampaio <[email protected]> * Chore: Remove unused files (#25124) * Chore: Convert LivechatAgentActivity to raw model and TS (#25123) * Chore: Migrate oauth2server to typescript (#25126) * Chore: Convert admin custom sound to tsx (#25128) * Chore: Remove old files from removed Omnichannel feature (#25129) * Chore: Tests with Playwright (task: All works) (#25122) * [FIX] Message menu action not working on legacy messages. (#25148) * fix action call * Fix lint * Chore: Convert NotificationStatus to TS (#25125) Co-authored-by: Guilherme Gazzo <[email protected]> * Fix CI (#25168) * Chore: move definitions to packages (#25085) * [FIX] UserCard sanitization (#25089) * fix: UserCard sanitization * chore: fix customStatus margin * Regression: Fix services Docker build on CI (#25181) * [FIX] Deactivating user not working if user is the only room owner (#24933) * Chore: TS migration SortList (#25167) * Chore: Remove duplicated useUserRoom (#25180) * [IMPROVE] Rewrite Admin Permissions to Typescript Co-authored-by: gabriellsh <[email protected]> * Regression: Fix micro services Docker build (#25193) Co-authored-by: Guilherme Gazzo <[email protected]> * Chore: Template to generate packages (#25174) Co-authored-by: Diego Sampaio <[email protected]> * Chore: Tests with Playwright (task: ROC-28, 09-channels) (#25196) * [FIX] Added invalid password error message (#24714) * Added invalid password error message * Added new password error message Co-authored-by: dougfabris <[email protected]> * Regression: yarn dev triggers build dependencies (#25208) Co-authored-by: Diego Sampaio <[email protected]> * [FIX] Close room when dismiss wrap up call modal (#25056) * [FIX] AgentOverview analytics wrong departmentId parameter (#25073) * Chore: Update Livechat version (#25130) * Chore: Add error boundary to message component (#25223) * Fix add reaction (#25222) * fix: check if message unread to show read receipts (#25216) * fix: is own message on broadcast receipts (#25175) * [FIX] Desktop notification on multi-instance environments (#25220) * [IMPROVE] Added MaxNickNameLength and MaxBioLength constants (#25231) * Added MaxNickNameLength and MaxBioLength constants added above mentioned constants to remove magic numbers in a simple manner * code style fixes Co-authored-by: gabriellsh <[email protected]> * Change alignment (#25237) * [IMPROVE] Add support for filters on omnichannel/extensions endpoint * Chore: update OTR icon (#24521) * Replace shredder icon by stopwatch icon * stopwatch icon for otr msg * remove old otr css * remove some unnecessary files Co-authored-by: yash-rajpal <[email protected]> Co-authored-by: Yash Rajpal <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> * [NEW] Add expire index to integration history (#25087) * [FIX] VoIP disabled/enabled sequence puts voip agent in error state (#25230) * Clickup Task: https://app.clickup.com/t/22rjza5 Description: The issue occurs because when client turns on VoIP, server starts the connector in apps/meteor/app/voip/server/startup.ts. While the AMI connection is not established, client makes a call to API api/v1/connector.extension.getRegistrationInfoByUserId?id=<userId>. This requires the connection to be up. But because the connection establishment is not yet complete, apps/meteor/server/services/voip/connector/asterisk/CommandHandler.ts thrown an error. Solution : In apps/meteor/app/voip/server/startup.ts add await for Voip.init(). Once the init is done (Which internally waits for socket establishment), broadcast connector.statuschanged with the setting value (Enabled = true/false) In apps/meteor/client/providers/CallProvider/hooks/useVoipClient.ts make voipEnabled as a setting. And change it in the event listener for voip.statuschanged * change place where event was fired Co-authored-by: Kevin Aleman <[email protected]> * [FIX] Read receipts show with color gray when not read yet (#25244) * fix: show read receipts with color gray instead of hidden * fix: rename function * review Co-authored-by: gabriellsh <[email protected]> * [FIX] Client disconnection on network loss (#25170) * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Agent gets disconnected (or Unregistered) from asterisk in multiple ways. The goal is that agent should remain online unless agent explicitly logs off. Agent can stop receiving calls in multiple ways due to network loss. Network loss can happen in following ways. 1. User tries to switch the network. User experiences a glitch of disconnectivity. This can be simulated by turning the network off in the network tab of chrome's dev tool. This can disconnect the UA if the disconnection happens just before the registration refresh. 2. Second reason is when computer goes in sleep mode. 3. Third reason is that when asterisk is crashed/in maintenance mode/explicitly stopped. Solution: The idea is to detect the network disconnection and start the start the attempts to reconnect. The detection of the disconnection does not happen in case#1. The SIPUA's UserAgent transport does not call onDisconnected when network loss of such kind happens. To tackle this problem, window's online and offline event handlers are used. The number of retries is configurable but ideally it is to be kept at -1. Whenever disconnection happens, it should keep on trying to reconnect with increasing backoff time. This behaviour is useful when the asterisk is stopped. When the server is disconnected, it should be indicated on the phone button. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: 1. Replaced complex state handling in OmnichannelCallToggleReady.tsx. This was creating lot of erros. Added simple network status check and the phone button displays the latest state of things. 2. Some files were overwriting the changes in develop branch. Replaced that with correct changes. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Adding semi-colon to fix error. * Clickup Task : https://app.clickup.com/t/245c0d8 Description : Fixing review commnts. * removing unused files * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Renaming file to correct the spelling. Making necessary changes in index.ts * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Fixing incorrect spelling. * Add description to setting Co-authored-by: Kevin Aleman <[email protected]> * [IMPROVE] Add OTR Room States (#24565) * WIP: OTR Room States * lint * remove logs * new OTR components, remove modals * updating stories * convert js files to ts * correct a type * add missing translation * fix review * chore: remove OTRModal * fix: review Co-authored-by: dougfabris <[email protected]> * [FIX] room creation fails if app framework is disabled (#25200) * [IMPROVE] Performance for some Omnichannel features (#25217) * Regression: Show username and real name on the message system (#25254) * Regression: Avatar not loading on first direct message (#25211) * refactor: load from server all chatsubscription before open room * Fix review Co-authored-by: Guilherme Gazzo <[email protected]> * [FIX] Custom sound error toast messages (#24515) Co-authored-by: dougfabris <[email protected]> * Chore: Update Livechat to the last version (#25257) * [FIX] Add katex render to new message react template (#25239) * feat: add katex render to message react * fix: add boolean to type * fix Review * fix: review Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: dougfabris <[email protected]> * [FIX] Add select message to system message, thread preview and allow select on legacy template (#25251) * feat: add export message to system message and thread preview * fix: enable select on export message at legacy message template * Update apps/meteor/client/views/room/contextualBar/ExportMessages/MailExportForm.tsx * chore: update fuselage Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: dougfabris <[email protected]> * [FIX] Showing Blank Message Inside Report (#25007) * [FIX] Incorrect websocket url in livechat widget (#25261) * Chore: Bump Fuselage packages (#25259) * [NEW] Alpha Matrix Federation (#23688) Implement alpha support for Matrix Federation Co-authored-by: Aaron Ogle <[email protected]> Co-authored-by: Marcos Defendi <[email protected]> Co-authored-by: Rodrigo Nascimento <[email protected]> * [FIX] Message preview not available for queued chats (#25092) Co-authored-by: Kevin Aleman <[email protected]> * Regression: Fix federation Matrix bridge startup (#25273) * [NEW] Expand Apps Engine's environment variable allowed list (#23870) * Swap installed app page with marketplace apps page * Update app/apps/server/bridges/environmental.ts Co-authored-by: Debdut Chakraborty <[email protected]> * Fix cannot use dash in environment variable name Co-authored-by: Debdut Chakraborty <[email protected]> Co-authored-by: dougfabris <[email protected]> * Chore: Fix return type warnings (#25275) * feat: remove 'Company' email label on setup wiz (#25260) * Chore: Remove package-lock.json from houston files (#25280) * Chore: Add yarn plugin to check node and yarn version (#25224) * Chore: Minor dependency updates (#25269) * Chore: Add root package.json to houston files (#25286) * Bump version to 4.7.0-rc.0 * Regression: Use exact Node version on micro services Docker images (#25287) * Regression: Shows error if micro service cannot connect to Mongo (#25301) * Regression: Add isPending status to message (#25299) * Update CODEOWNERS * Regression: eslint not running on packages (#25305) * Regression: eslint not running on packages Co-authored-by: Guilherme Gazzo <[email protected]> * Bump version to 4.7.0-rc.1 * Regression: Revert Bugsnag version (#25313) * Chore: ensure scripts use cross-env and ignore some dirs (ROC-54) (#25218) * Regression: Add eslint package to micro services Dockerfile (#25311) * Regression: Fix reply button not working when hideFlexTab is enabled (#25306) * fix: add stop propagation on open thread * Fix type Co-authored-by: gabriellsh <[email protected]> * Regression: Change preference to be default legacy messages (#25255) * Regression: Fix the alpine image and dev UX installing matrix-rust-sdk-bindings (#25319) * Switch to forked version of matrix-appservice-bridge package * change yarn lock * add dependency that is installed indirectly but depended on directly * fix missing reference * fix lockfile Co-authored-by: Douglas Gubert <[email protected]> * Bump version to 4.7.0-rc.2 * Regression: Validate empty fields for Message template (#25250) * Remove null values from messa list * fix order * Fix * Fix type * review * Regression: Better MongoDB connection management for micro services (#25323) * Regression: Messages in new message template Crashing. (#25327) * Bump version to 4.7.0-rc.3 * Regression: Parser message when notify ephemeral message * Chore: Create README.md for Rest Typings (#25335) * Regression: bump onboarding-ui version (#25320) * fix: bump onboarding-ui version * fix: update adminData types * Regression: Fix multi line is not showing an empty line between lines (#25317) * fix: render empty line * remove style * add small comment Co-authored-by: gabriellsh <[email protected]> * Regression: Rocket.Chat Webapp not loading. (#25349) Co-authored-by: gabriellsh <[email protected]> * Regression: Fix English i18n react text (#25368) * Chore: Add options to debug stdout and rate limiter (#25336) * Bump version to 4.7.0-rc.4 * Chore: Bump fuselage (#25371) * Regression: Fix size of custom emoji and render emoji on thread message preview (#25314) * fix: custom emoji size * fix: emoji rendering undefined * fix: add parser to message thread preview * refactor: replace css property to css in js * fix: lint * refactor: change to is span * refactor: add message render component * update emoji component * fix: remove duplicate css import * fix: remove disable emoji props and add custom style * fix: remove unsued props * fix: render emoji render if not find emoji * fix: replace conditional * fix: remove conditional * fix: undo changes on big * Use fuselage * Add missing changes Co-authored-by: gabriellsh <[email protected]> * Regression: Fix clicking on visitor's chat in the sidebar does not display the chat window (#25380) * Bump version to 4.7.0-rc.5 * Bump version to 4.7.0 Co-authored-by: Diego Sampaio <[email protected]> Co-authored-by: lingohub[bot] <69908207+lingohub[bot]@users.noreply.github.com> Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Douglas Fabris <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Tiago Ulisses Montini <[email protected]> Co-authored-by: montini.ext tiago <[email protected]> Co-authored-by: Rodrigo Nascimento <[email protected]> Co-authored-by: Weslley de Campos <[email protected]> Co-authored-by: Debdut Chakraborty <[email protected]> Co-authored-by: Thassio Victor <[email protected]> Co-authored-by: Himanshu Malviya <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Yash Rajpal <[email protected]> Co-authored-by: Fábio Albuquerque <[email protected]> Co-authored-by: Martin Schoeler <[email protected]> Co-authored-by: Filipe Marins <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: juliajforesti <[email protected]> Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: Tiago Evangelista Pinto <[email protected]> Co-authored-by: Guilherme Jun Grillo <[email protected]> Co-authored-by: Júlia Jaeger Foresti <[email protected]> Co-authored-by: Aaron Ogle <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Weslley Campos <[email protected]> Co-authored-by: Jean Brito <[email protected]> Co-authored-by: Sidharth Mohanty <[email protected]> Co-authored-by: Paulo Bernardo <[email protected]> Co-authored-by: aakash-gitdev <[email protected]> Co-authored-by: Gabriel Freitas <[email protected]> Co-authored-by: yash-rajpal <[email protected]> Co-authored-by: amolghode1981 <[email protected]> Co-authored-by: Nishant Patel <[email protected]> Co-authored-by: Alan Sikora <[email protected]> Co-authored-by: Aaron Ogle <[email protected]> Co-authored-by: Marcos Defendi <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Cuong Huu Nguyen <[email protected]> Co-authored-by: souzaramon <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
fix avatar not loading on a first direct message
Issue(s)
Steps to test or reproduce
Further comments
The room avatar component depends on the
Subscriptionobject to load the avatar URL. But the subscription is updated in an asynchronous way, sometimes when a room is created theSubscriptionwas not set yet. Adding aloadFromServerAndPopulatefunction redirect to a room will ensure that theSubscriptionobject will be updated before creating a room.