Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] UI/UX issues on Live Chat widget #25407

Merged
merged 8 commits into from
May 16, 2022
Merged

[FIX] UI/UX issues on Live Chat widget #25407

merged 8 commits into from
May 16, 2022

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented May 5, 2022 •
edited
Loading

  • Quick reply buttons don't fit the UI/Message container
  • Rocket.chat logo is not the latest one

Will be ready to review as soon as #25312 is merged

@MartinSchoeler MartinSchoeler mentioned this pull request May 5, 2022
Closed
3 tasks
Base automatically changed from new/livechat-monorepo to develop May 6, 2022 13:27
@MartinSchoeler MartinSchoeler marked this pull request as ready for review May 6, 2022 13:54
@MartinSchoeler MartinSchoeler requested review from a team as code owners May 6, 2022 13:54
@MartinSchoeler MartinSchoeler marked this pull request as draft May 6, 2022 18:58
@MartinSchoeler MartinSchoeler marked this pull request as ready for review May 9, 2022 13:12
@renatobecker renatobecker added this to the 4.7.1 milestone May 10, 2022
KevLehman
KevLehman previously approved these changes May 11, 2022
View reviewed changes
KevLehman
KevLehman reviewed May 12, 2022
View reviewed changes
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're not using the logo, maybe you can remove it from the widget files too 👀

packages/livechat/src/components/Footer/index.js Outdated Show resolved Hide resolved
KevLehman
KevLehman previously approved these changes May 12, 2022
View reviewed changes
@casalsgh casalsgh modified the milestones: 4.7.1, 4.7.2 May 13, 2022
@dougfabris dougfabris force-pushed the livechat/fix-ui-issues branch 2 times, most recently from 9ef15e1 to a5cbde8 Compare May 16, 2022 14:32
@MartinSchoeler MartinSchoeler merged commit 75c7f4d into develop May 16, 2022
@MartinSchoeler MartinSchoeler deleted the livechat/fix-ui-issues branch May 16, 2022 19:10
gabriellsh added a commit that referenced this pull request May 17, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
0e05742 
…threadTemplate

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  Chore: migrate from cypress to pw 14-setting-permission (#25523)
  Chore: Tests with Playwright (task: ROC-31, 12-settings) (#25253)
  Chore: Migrate 15-message-popup from cypress to playwright (#25462)
  Chore: Convert apps/meteor/client/views/admin/settings/inputs folder (#25427)
  [FIX] UI/UX issues on Live Chat widget (#25407)
  Chore: Convert Admin -> Rooms to TS (#25348)
  Chore: Migrate NotFoundPage to TS (#25509)
  [FIX] Unable to see channel member list by authorized channel roles (#25412)
  Regression: Fix services-image-build-check (#25519)
  Chore: Migrate spotify to ts (#25507)
  [Chore] Reorder unreleased migrations (#25508)
  [FIX] Spotlight results showing usernames instead of real names (#25471)
  [FIX] LDAP sync removing users from channels when multiple groups are mapped to it (#25434)
  Chore: Move markdown message parser to a `callback` (#25413)
  [FIX] Settings listeners not receiving overwritten values from env vars (#25448)
  Chore: Move ddp-streamer micro service to its own sub-repo (#25246)
  [NEW] Use setting to determine if initial general channel is needed (#25441)
  [IMPROVE] New admin settings Page (#25439)
  [FIX] Failure to update Integration History index (#25473)
  Chore: Rewrite 2fa to typescript (#25285)
  ...
gabriellsh added a commit that referenced this pull request May 17, 2022
@gabriellsh
Merge branch 'new/threadTemplate' of github.com:RocketChat/Rocket.Cha…
382cec3 
…t into new/threadTemplate-thread-components

* 'new/threadTemplate' of github.com:RocketChat/Rocket.Chat:
  Chore: migrate from cypress to pw 14-setting-permission (#25523)
  Chore: Tests with Playwright (task: ROC-31, 12-settings) (#25253)
  Chore: Migrate 15-message-popup from cypress to playwright (#25462)
  Chore: Convert apps/meteor/client/views/admin/settings/inputs folder (#25427)
  [FIX] UI/UX issues on Live Chat widget (#25407)
  Chore: Convert Admin -> Rooms to TS (#25348)
d-gubert pushed a commit that referenced this pull request May 20, 2022
@MartinSchoeler @dougfabris @d-gubert
[FIX] UI/UX issues on Live Chat widget (#25407)
41cfa00 
* [FIX] UI/UX issues on Live Chat widget

* Use @rocketchat/logo

* READ THE ERRORS MARTIN

* Remove old logo

* Fix Reviews

* chore: remove unnecessary class prop

Co-authored-by: dougfabris <[email protected]>
@d-gubert d-gubert mentioned this pull request May 20, 2022
Merged
albuquerquefabio added a commit that referenced this pull request May 20, 2022
@albuquerquefabio
Squashed commit of the following:
752737a 
commit 8a3c928
Author: Aaron Ogle <[email protected]>
Date:   Fri May 20 08:35:44 2022 -0500

    [FIX] Initial User not added to default channel (#25544)

commit b893ffd
Author: Leonardo Ostjen Couto <[email protected]>
Date:   Thu May 19 20:39:38 2022 -0300

    [NEW] New stats rewrite (#25078)

    Co-authored-by: matheusbsilva137 <[email protected]>
    Co-authored-by: Diego Sampaio <[email protected]>

commit 42442d2
Author: Júlia Jaeger Foresti <[email protected]>
Date:   Thu May 19 18:42:27 2022 -0300

    Chore: Convert apps/meteor/client/views/admin/settings (#25565)

commit 59c52e3
Author: Cauê Felchar <[email protected]>
Date:   Thu May 19 16:32:06 2022 -0300

    [FIX] User abandonment setting is working again (#25520)

commit e851297
Author: souzaramon <[email protected]>
Date:   Thu May 19 01:04:54 2022 -0300

    Test: Migrate 13-permissions from cypress to playwright (#25558)

commit 0830814
Author: Filipe Marins <[email protected]>
Date:   Wed May 18 20:06:13 2022 -0300

    [FIX] Add open user card to user avatar (#25445)

commit e80d88f
Author: Guilherme Gazzo <[email protected]>
Date:   Wed May 18 19:28:37 2022 -0300

    [FIX] Dynamic load matrix is enabled and handle failure (#25495)

    Co-authored-by: Aaron Ogle <[email protected]>

commit 71d57bd
Author: Martin Schoeler <[email protected]>
Date:   Wed May 18 17:45:58 2022 -0300

    [FIX] One of the triggers was not working correctly (#25409)

    * [FIX] One of the triggers was not working correctly

    * fix html iteration

    * eslint fix

    Co-authored-by: Tiago Evangelista Pinto <[email protected]>

commit bbd534a
Author: Guilherme Gazzo <[email protected]>
Date:   Wed May 18 14:42:44 2022 -0300

    Regression: CI services build (#25555)

commit 45b46da
Author: Fábio Albuquerque <[email protected]>
Date:   Wed May 18 09:42:43 2022 -0300

    Chore: User set UTC offset (#25381)

    Co-authored-by: Guilherme Gazzo <[email protected]>

commit d170c48
Author: Guilherme Jun Grillo <[email protected]>
Date:   Wed May 18 09:11:44 2022 -0300

    [FIX] Rooms' names turn lower case on CSV import (#24612)

    * feat: change channel name 'rule' when importing

    * feat: add maintainCase in limax

    * fix: update special characters rule

    * fix: regression of settings use for import rules

commit 3ab9d8a
Author: Weslley Campos <[email protected]>
Date:   Tue May 17 21:34:38 2022 -0300

    Chore: migrate-to-pw-adjust-in-intermitences (#25542)

commit f975b2c
Author: Matheus Barbosa Silva <[email protected]>
Date:   Tue May 17 18:38:44 2022 -0300

    Add support to map a LDAP group to multiple roles (#23849)

    Co-authored-by: Pierre Lehnen <[email protected]>

commit 86c0131
Author: Guilherme Gazzo <[email protected]>
Date:   Tue May 17 17:05:44 2022 -0300

    Chore: Livechat change output level (#25522)

commit 93575bf
Author: Allan RIbeiro <[email protected]>
Date:   Tue May 17 16:11:51 2022 -0300

    [NEW] Adding app button on user dropdown (#25326)

    * feat: adding app button on user dropdown

    * chore: changing some implementations and adding comments

    * chore: fixing lint issues

    * Update apps/meteor/client/sidebar/header/UserDropdown.tsx

    * chore: change some method location

    * chore: fixing lint issues

    * fix: using local method

    * Refactor AccountBox to singleton

    Co-authored-by: Douglas Gubert <[email protected]>

commit fd40e3e
Author: Weslley Campos <[email protected]>
Date:   Tue May 17 13:33:19 2022 -0300

    Chore: migrate from cypress to pw 14-setting-permission (#25523)

commit 88710b2
Author: souzaramon <[email protected]>
Date:   Tue May 17 10:59:56 2022 -0300

    Chore: Tests with Playwright (task: ROC-31, 12-settings) (#25253)

commit 72db7a2
Author: souzaramon <[email protected]>
Date:   Tue May 17 09:35:07 2022 -0300

    Chore: Migrate 15-message-popup from cypress to playwright (#25462)

commit 99a3651
Author: Júlia Jaeger Foresti <[email protected]>
Date:   Mon May 16 16:56:01 2022 -0300

    Chore: Convert apps/meteor/client/views/admin/settings/inputs folder (#25427)

commit 75c7f4d
Author: Martin Schoeler <[email protected]>
Date:   Mon May 16 16:10:42 2022 -0300

    [FIX] UI/UX issues on Live Chat widget (#25407)

    * [FIX] UI/UX issues on Live Chat widget

    * Use @rocketchat/logo

    * READ THE ERRORS MARTIN

    * Remove old logo

    * Fix Reviews

    * chore: remove unnecessary class prop

    Co-authored-by: dougfabris <[email protected]>

commit bdeb54a
Author: Yash Rajpal <[email protected]>
Date:   Tue May 17 00:12:55 2022 +0530

    Chore: Convert Admin -> Rooms to TS (#25348)

    Co-authored-by: Guilherme Gazzo <[email protected]>

commit 394b4aa
Author: Hugo Costa <[email protected]>
Date:   Mon May 16 12:52:15 2022 -0300

    Chore: Migrate NotFoundPage to TS (#25509)

commit de7cd66
Author: Hugo Costa <[email protected]>
Date:   Mon May 16 12:10:48 2022 -0300

    [FIX] Unable to see channel member list by authorized channel roles (#25412)

commit 2d59aa9
Author: Guilherme Gazzo <[email protected]>
Date:   Mon May 16 11:08:28 2022 -0300

    Regression: Fix services-image-build-check (#25519)

    Co-authored-by: Diego Sampaio <[email protected]>

commit 3b9254e
Author: Kevin Aleman <[email protected]>
Date:   Mon May 16 05:55:35 2022 -0600

    Chore: Migrate spotify to ts (#25507)
albuquerquefabio added a commit that referenced this pull request May 20, 2022
@albuquerquefabio
Squashed commit of the following:
7ba724a 
commit 4cbc777
Author: Kevin Aleman <[email protected]>
Date:   Fri May 20 13:24:10 2022 -0600

    Chore: Rewrite autotranslate to ts (#25425)

commit 603ade2
Author: Rafael Tapia <[email protected]>
Date:   Fri May 20 13:47:17 2022 -0400

    [NEW] Add user events for apps (#25165)

    * Add user events for apps

    * Remove trycatch validation

    * Get the user entity after the update

    * Trigger events when the user updates his profile or deletes his account

    * Update Apps-Engine

    * Make update return doc after update

    * Find user after the update to trigger event with correct data

    * Change where clause to use userData instead of userId

    * Update apps-engine

commit 6aa09ec
Author: Pierre Lehnen <[email protected]>
Date:   Fri May 20 14:27:11 2022 -0300

    [FIX] Integrations avatar attribute misuse (#25283)

commit dd6acaf
Author: Allan RIbeiro <[email protected]>
Date:   Fri May 20 14:25:14 2022 -0300

    Chore: Converting orchestrator.js to ts (#25367)

commit 6d95144
Author: Matheus Lucca do Carmo <[email protected]>
Date:   Fri May 20 14:23:44 2022 -0300

    Chore: convert marketplace price display component to use typescript (#25504)

commit 45417ea
Author: Júlia Jaeger Foresti <[email protected]>
Date:   Fri May 20 14:17:58 2022 -0300

    Chore: Convert apps/meteor/client/components/UserAutoComplete (#25554)

    Co-authored-by: Guilherme Gazzo <[email protected]>

commit 8a3c928
Author: Aaron Ogle <[email protected]>
Date:   Fri May 20 08:35:44 2022 -0500

    [FIX] Initial User not added to default channel (#25544)

commit b893ffd
Author: Leonardo Ostjen Couto <[email protected]>
Date:   Thu May 19 20:39:38 2022 -0300

    [NEW] New stats rewrite (#25078)

    Co-authored-by: matheusbsilva137 <[email protected]>
    Co-authored-by: Diego Sampaio <[email protected]>

commit 42442d2
Author: Júlia Jaeger Foresti <[email protected]>
Date:   Thu May 19 18:42:27 2022 -0300

    Chore: Convert apps/meteor/client/views/admin/settings (#25565)

commit 59c52e3
Author: Cauê Felchar <[email protected]>
Date:   Thu May 19 16:32:06 2022 -0300

    [FIX] User abandonment setting is working again (#25520)

commit e851297
Author: souzaramon <[email protected]>
Date:   Thu May 19 01:04:54 2022 -0300

    Test: Migrate 13-permissions from cypress to playwright (#25558)

commit 0830814
Author: Filipe Marins <[email protected]>
Date:   Wed May 18 20:06:13 2022 -0300

    [FIX] Add open user card to user avatar (#25445)

commit e80d88f
Author: Guilherme Gazzo <[email protected]>
Date:   Wed May 18 19:28:37 2022 -0300

    [FIX] Dynamic load matrix is enabled and handle failure (#25495)

    Co-authored-by: Aaron Ogle <[email protected]>

commit 71d57bd
Author: Martin Schoeler <[email protected]>
Date:   Wed May 18 17:45:58 2022 -0300

    [FIX] One of the triggers was not working correctly (#25409)

    * [FIX] One of the triggers was not working correctly

    * fix html iteration

    * eslint fix

    Co-authored-by: Tiago Evangelista Pinto <[email protected]>

commit bbd534a
Author: Guilherme Gazzo <[email protected]>
Date:   Wed May 18 14:42:44 2022 -0300

    Regression: CI services build (#25555)

commit 45b46da
Author: Fábio Albuquerque <[email protected]>
Date:   Wed May 18 09:42:43 2022 -0300

    Chore: User set UTC offset (#25381)

    Co-authored-by: Guilherme Gazzo <[email protected]>

commit d170c48
Author: Guilherme Jun Grillo <[email protected]>
Date:   Wed May 18 09:11:44 2022 -0300

    [FIX] Rooms' names turn lower case on CSV import (#24612)

    * feat: change channel name 'rule' when importing

    * feat: add maintainCase in limax

    * fix: update special characters rule

    * fix: regression of settings use for import rules

commit 3ab9d8a
Author: Weslley Campos <[email protected]>
Date:   Tue May 17 21:34:38 2022 -0300

    Chore: migrate-to-pw-adjust-in-intermitences (#25542)

commit f975b2c
Author: Matheus Barbosa Silva <[email protected]>
Date:   Tue May 17 18:38:44 2022 -0300

    Add support to map a LDAP group to multiple roles (#23849)

    Co-authored-by: Pierre Lehnen <[email protected]>

commit 86c0131
Author: Guilherme Gazzo <[email protected]>
Date:   Tue May 17 17:05:44 2022 -0300

    Chore: Livechat change output level (#25522)

commit 93575bf
Author: Allan RIbeiro <[email protected]>
Date:   Tue May 17 16:11:51 2022 -0300

    [NEW] Adding app button on user dropdown (#25326)

    * feat: adding app button on user dropdown

    * chore: changing some implementations and adding comments

    * chore: fixing lint issues

    * Update apps/meteor/client/sidebar/header/UserDropdown.tsx

    * chore: change some method location

    * chore: fixing lint issues

    * fix: using local method

    * Refactor AccountBox to singleton

    Co-authored-by: Douglas Gubert <[email protected]>

commit fd40e3e
Author: Weslley Campos <[email protected]>
Date:   Tue May 17 13:33:19 2022 -0300

    Chore: migrate from cypress to pw 14-setting-permission (#25523)

commit 88710b2
Author: souzaramon <[email protected]>
Date:   Tue May 17 10:59:56 2022 -0300

    Chore: Tests with Playwright (task: ROC-31, 12-settings) (#25253)

commit 72db7a2
Author: souzaramon <[email protected]>
Date:   Tue May 17 09:35:07 2022 -0300

    Chore: Migrate 15-message-popup from cypress to playwright (#25462)

commit 99a3651
Author: Júlia Jaeger Foresti <[email protected]>
Date:   Mon May 16 16:56:01 2022 -0300

    Chore: Convert apps/meteor/client/views/admin/settings/inputs folder (#25427)

commit 75c7f4d
Author: Martin Schoeler <[email protected]>
Date:   Mon May 16 16:10:42 2022 -0300

    [FIX] UI/UX issues on Live Chat widget (#25407)

    * [FIX] UI/UX issues on Live Chat widget

    * Use @rocketchat/logo

    * READ THE ERRORS MARTIN

    * Remove old logo

    * Fix Reviews

    * chore: remove unnecessary class prop

    Co-authored-by: dougfabris <[email protected]>

commit bdeb54a
Author: Yash Rajpal <[email protected]>
Date:   Tue May 17 00:12:55 2022 +0530

    Chore: Convert Admin -> Rooms to TS (#25348)

    Co-authored-by: Guilherme Gazzo <[email protected]>

commit 394b4aa
Author: Hugo Costa <[email protected]>
Date:   Mon May 16 12:52:15 2022 -0300

    Chore: Migrate NotFoundPage to TS (#25509)

commit de7cd66
Author: Hugo Costa <[email protected]>
Date:   Mon May 16 12:10:48 2022 -0300

    [FIX] Unable to see channel member list by authorized channel roles (#25412)

commit 2d59aa9
Author: Guilherme Gazzo <[email protected]>
Date:   Mon May 16 11:08:28 2022 -0300

    Regression: Fix services-image-build-check (#25519)

    Co-authored-by: Diego Sampaio <[email protected]>

commit 3b9254e
Author: Kevin Aleman <[email protected]>
Date:   Mon May 16 05:55:35 2022 -0600

    Chore: Migrate spotify to ts (#25507)
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

@KevLehman KevLehman KevLehman left review comments

Assignees
No one assigned
Labels
subj: livechat
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinSchoeler @KevLehman @dougfabris @renatobecker @casalsgh