[IMPROVE] New admin settings Page #25439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging 1995692 into 1300079 - view on LGTM.com new alerts:
|
ggazzo
force-pushed
the
improve/admin-settings
branch
3 times, most recently
from
1315f12
to
b9f947e
Compare
fix review
ggazzo
force-pushed
the
improve/admin-settings
branch
from
b9f947e
to
4b0c392
Compare
ggazzo
approved these changes
May 12, 2022
This was referenced May 12, 2022
gabriellsh
added a commit
that referenced
this pull request
May 12, 2022
…lists * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Move markdown message parser to a `callback` (#25413) [FIX] Settings listeners not receiving overwritten values from env vars (#25448) Chore: Move ddp-streamer micro service to its own sub-repo (#25246) [NEW] Use setting to determine if initial general channel is needed (#25441) [IMPROVE] New admin settings Page (#25439) [FIX] Failure to update Integration History index (#25473) Chore: Rewrite 2fa to typescript (#25285) Chore: solve yarn issues from env var (#25468) Chore: REST query and body params validation (#25446) Chore: Tests with Playwright (task: ROC-66, Intermittent resolution in tests) (#25416) Chore: Convert email inbox feature to TypeScript (#25298)
gabriellsh
added a commit
that referenced
this pull request
May 16, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Migrate NotFoundPage to TS (#25509) [FIX] Unable to see channel member list by authorized channel roles (#25412) Regression: Fix services-image-build-check (#25519) Chore: Migrate spotify to ts (#25507) [Chore] Reorder unreleased migrations (#25508) [FIX] Spotlight results showing usernames instead of real names (#25471) [FIX] LDAP sync removing users from channels when multiple groups are mapped to it (#25434) Chore: Move markdown message parser to a `callback` (#25413) [FIX] Settings listeners not receiving overwritten values from env vars (#25448) Chore: Move ddp-streamer micro service to its own sub-repo (#25246) [NEW] Use setting to determine if initial general channel is needed (#25441) [IMPROVE] New admin settings Page (#25439) [FIX] Failure to update Integration History index (#25473) Chore: Rewrite 2fa to typescript (#25285) Chore: solve yarn issues from env var (#25468) Chore: REST query and body params validation (#25446) Chore: Tests with Playwright (task: ROC-66, Intermittent resolution in tests) (#25416) Chore: Convert email inbox feature to TypeScript (#25298)
gabriellsh
added a commit
that referenced
this pull request
May 17, 2022
…threadTemplate * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) Chore: migrate from cypress to pw 14-setting-permission (#25523) Chore: Tests with Playwright (task: ROC-31, 12-settings) (#25253) Chore: Migrate 15-message-popup from cypress to playwright (#25462) Chore: Convert apps/meteor/client/views/admin/settings/inputs folder (#25427) [FIX] UI/UX issues on Live Chat widget (#25407) Chore: Convert Admin -> Rooms to TS (#25348) Chore: Migrate NotFoundPage to TS (#25509) [FIX] Unable to see channel member list by authorized channel roles (#25412) Regression: Fix services-image-build-check (#25519) Chore: Migrate spotify to ts (#25507) [Chore] Reorder unreleased migrations (#25508) [FIX] Spotlight results showing usernames instead of real names (#25471) [FIX] LDAP sync removing users from channels when multiple groups are mapped to it (#25434) Chore: Move markdown message parser to a `callback` (#25413) [FIX] Settings listeners not receiving overwritten values from env vars (#25448) Chore: Move ddp-streamer micro service to its own sub-repo (#25246) [NEW] Use setting to determine if initial general channel is needed (#25441) [IMPROVE] New admin settings Page (#25439) [FIX] Failure to update Integration History index (#25473) Chore: Rewrite 2fa to typescript (#25285) ...
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments