Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrate oembed to ts #25622

Merged
merged 12 commits into from
Jun 27, 2022
Merged

Chore: Migrate oembed to ts #25622

merged 12 commits into from
Jun 27, 2022

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman changed the title ChoreMigrate oembed to ts part 1 Chore: Migrate oembed to ts May 24, 2022
@KevLehman KevLehman marked this pull request as ready for review May 30, 2022 16:23
@KevLehman KevLehman requested a review from a team as a code owner May 30, 2022 16:23
@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2022

This pull request introduces 1 alert when merging 16e1ae8 into a358017 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@KevLehman KevLehman requested a review from a team as a code owner June 10, 2022 20:20
@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2022

This pull request introduces 1 alert when merging 8dccdad into 5a287ff - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 27, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jun 27, 2022

This pull request introduces 1 alert when merging 4625a3e into c8f93fa - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@kodiakhq kodiakhq bot merged commit 5afe5ce into develop Jun 27, 2022
@kodiakhq kodiakhq bot deleted the chore/migrate-oembed-to-ts branch June 27, 2022 20:37
gabriellsh added a commit that referenced this pull request Jun 28, 2022
…ove/message-renderer-tweaks

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  Chore: Create a token for each action (#26023)
  Chore: Migrate oembed to ts (#25622)
  Regression: Fix voip call wrap-up model not working (#26024)
  Chore: Updating Apps-Engine  (#26001)
  [IMPROVE] Differ Voip calls from Incoming and Outgoing (#25643)
  [FIX] Append path To Route For Custom Emoji (#24379)
  [IMPROVE] Moved call wrap up modal to EE (#25875)
  Chore: Major refactors in pageobjects (#26015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng day stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants