Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Enable outbound calling for EE (#25843) #25960

Merged
merged 15 commits into from
Jun 28, 2022
Merged

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

amolghode1981 and others added 2 commits June 21, 2022 14:57
* Clickup Task: https://app.clickup.com/t/22bmce2
Description: Creating EE structure for outbound dialing.
Refactored VoIPUser.ts and made necessary fields protected.
Created VoIPUser or EEVoipClient based on the licensing in SimpleVoipUser
Made necessary changes for using the voip client.

* Clickup Task: https://app.clickup.com/t/22bmce2
Description: Adding missing file.

* Clickup Task: https://app.clickup.com/t/22bmce2
Description: Connector changes for detecting the outbound call.

* Clickup Task: https://app.clickup.com/t/22bmce2
Description: Handling review comments.
@KevLehman KevLehman requested review from a team as code owners June 22, 2022 16:20
@KevLehman KevLehman requested review from amolghode1981 and a team June 22, 2022 16:20
@murtaza98
Copy link
Contributor

@KevLehman FYI: There are some conflicts here 😬

murtaza98
murtaza98 previously approved these changes Jun 24, 2022
Copy link
Contributor

@murtaza98 murtaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested and everything looks good to me!

Description: Fixing the VoIP client loading problem.
Description: Adding voip-enterprise license.
Description: Implementing callfailed event for outbound calls. callfailed event will be displatched with reasonCode
signifying why the call failed (Not Found/Busy Here)
tiagoevanp
tiagoevanp previously approved these changes Jun 27, 2022
@KevLehman KevLehman added this to the 5.0.0 milestone Jun 27, 2022
@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 27, 2022
@tiagoevanp
Copy link
Contributor

#25890 needs this one to be tested by QA!

tiagoevanp
tiagoevanp previously approved these changes Jun 28, 2022
@MartinSchoeler MartinSchoeler dismissed stale reviews from aleksandernsilva and themself June 28, 2022 11:15

stale review

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would make more sense move useVoipClient to ee folder

@kodiakhq kodiakhq bot merged commit 957c69d into develop Jun 28, 2022
@kodiakhq kodiakhq bot deleted the new/voip-outbound branch June 28, 2022 16:23
gabriellsh added a commit that referenced this pull request Jun 28, 2022
…ove/message-renderer-tweaks

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  Chore: Create a token for each action (#26023)
  Chore: Migrate oembed to ts (#25622)
  Regression: Fix voip call wrap-up model not working (#26024)
  Chore: Updating Apps-Engine  (#26001)
  [IMPROVE] Differ Voip calls from Incoming and Outgoing (#25643)
  [FIX] Append path To Route For Custom Emoji (#24379)
  [IMPROVE] Moved call wrap up modal to EE (#25875)
  Chore: Major refactors in pageobjects (#26015)
gabriellsh added a commit that referenced this pull request Jun 29, 2022
…/clientPackage

* 'develop' of github.com:RocketChat/Rocket.Chat: (80 commits)
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
  Chore: Add missing Swedish livechat translations (#26048)
  [IMPROVE] Expand the feature set of the new message rendering (#25970)
  Chore: Bump fuselage and update icon (#26036)
  [NEW][APPS] Allowing apps to register authenticated routes (#25937)
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants