Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK] Remove Blockstack authentication #25649

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented May 26, 2022

Proposed changes (including videos or screenshots)

Blockstack authentication is broken and is preventing some dependencies to be up to date. As a migration to Stacks authentication is not trivial, we've opted for removing the authentication service.

Issue(s)

Steps to test or reproduce

Further comments

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2022

This pull request fixes 2 alerts when merging 9c68542 into 3cd0cab - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types
  • 1 for Template syntax in string literal

@tassoevan tassoevan requested a review from a team May 26, 2022 19:34
@tassoevan tassoevan marked this pull request as ready for review May 26, 2022 19:34
@tassoevan tassoevan requested a review from a team as a code owner May 26, 2022 19:34
ggazzo
ggazzo previously approved these changes May 27, 2022
@tassoevan tassoevan added this to the 5.0.0 milestone May 27, 2022
@lgtm-com
Copy link

lgtm-com bot commented May 30, 2022

This pull request fixes 2 alerts when merging 4750d5a into 62405c6 - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types
  • 1 for Template syntax in string literal

@lgtm-com
Copy link

lgtm-com bot commented May 30, 2022

This pull request fixes 2 alerts when merging 2be6f86 into 713120e - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types
  • 1 for Template syntax in string literal

@tassoevan tassoevan requested a review from ggazzo May 30, 2022 23:13
@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2022

This pull request fixes 2 alerts when merging cc6e19d into 881e762 - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types
  • 1 for Template syntax in string literal

@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2022

This pull request fixes 2 alerts when merging 4466a64 into 9a4c6cb - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types
  • 1 for Template syntax in string literal

@ggazzo ggazzo merged commit 440dfaa into develop Jun 7, 2022
@ggazzo ggazzo deleted the break/blockstack-removal branch June 7, 2022 13:06
gabriellsh added a commit that referenced this pull request Jun 8, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Fix CI (#25797)
  [FIX] Fix prom-client new promise usage (#25781)
  [FIX] Discussion alphabetical  ordering (#25788)
  Update .kodiak.toml
  Update .kodiak.toml
  Chore: Testing Kodiak feature (#25794)
  [FIX] Broken Omnichannel>Agents page (#25731)
  [FIX] Sanitize styles in message (#25744)
  chore: Convert to TS RoomAutoComplete (#25536)
  Chore: API test on method GET with params as a number. (#25769)
  Chore: convert invites, misc and subscriptions to TS and create definitions (#25350)
  Chore: Remove .snapcraft
  Chore: Remove toastr package (#25787)
  [BREAK] Remove Blockstack authentication (#25649)
  [FIX] getUserMentionsByChannel method room permission (#25748)
  [NEW] Fuselage ToastBar (#25583)
gabriellsh added a commit that referenced this pull request Jun 8, 2022
… feat/custom-homepage-setting

* 'new/homepage' of github.com:RocketChat/Rocket.Chat:
  Chore: Fix CI (#25797)
  [FIX] Fix prom-client new promise usage (#25781)
  [FIX] Discussion alphabetical  ordering (#25788)
  Update .kodiak.toml
  Update .kodiak.toml
  Chore: Testing Kodiak feature (#25794)
  [FIX] Broken Omnichannel>Agents page (#25731)
  [FIX] Sanitize styles in message (#25744)
  chore: Convert to TS RoomAutoComplete (#25536)
  Chore: API test on method GET with params as a number. (#25769)
  Chore: convert invites, misc and subscriptions to TS and create definitions (#25350)
  Chore: Remove .snapcraft
  Chore: Remove toastr package (#25787)
  [BREAK] Remove Blockstack authentication (#25649)
  [FIX] getUserMentionsByChannel method room permission (#25748)
  [NEW] Fuselage ToastBar (#25583)
gabriellsh added a commit that referenced this pull request Jun 9, 2022
… feat/new-header

* 'new/homepage' of github.com:RocketChat/Rocket.Chat:
  [NEW] Add Custom homepage Content Setting (#25777)
  Chore: Fix CI (#25797)
  [FIX] Fix prom-client new promise usage (#25781)
  [FIX] Discussion alphabetical  ordering (#25788)
  Update .kodiak.toml
  Update .kodiak.toml
  Chore: Testing Kodiak feature (#25794)
  [FIX] Broken Omnichannel>Agents page (#25731)
  [FIX] Sanitize styles in message (#25744)
  chore: Convert to TS RoomAutoComplete (#25536)
  Chore: API test on method GET with params as a number. (#25769)
  Chore: convert invites, misc and subscriptions to TS and create definitions (#25350)
  Chore: Remove .snapcraft
  Chore: Remove toastr package (#25787)
  [BREAK] Remove Blockstack authentication (#25649)
  [FIX] getUserMentionsByChannel method room permission (#25748)
  [NEW] Fuselage ToastBar (#25583)
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants