[FIX] Broken Omnichannel>Agents page #25731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
reviewed
Jun 2, 2022
MartinSchoeler
requested changes
Jun 2, 2022
ggazzo
requested changes
Jun 2, 2022
…agents-route-page
…agents-route-page
…agents-route-page
MartinSchoeler
requested changes
Jun 7, 2022
| </Box> | ||
| {!mediaQuery && name && ( | ||
| <Box fontScale='p2' color='hint' withTruncatedText> | ||
| {' '} |
There was a problem hiding this comment.
I believe that those {' '} are artifacts of prettier and are unnecessary to satisfy the linter, pls remove them
|
@tiagoevanp Just a suggestion to add a basic test case for this page to verify if this page is getting loaded or not - just so we can avoid this type of issue in future |
|
Yes, thanks for the comment @murtaza98. I know that we have different teams working on tests outside of our main team at rocket.chat... Probably this case will be covered by them. |
MartinSchoeler
approved these changes
Jun 7, 2022
gabriellsh
added a commit
that referenced
this pull request
Jun 8, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
gabriellsh
added a commit
that referenced
this pull request
Jun 8, 2022
… feat/custom-homepage-setting * 'new/homepage' of github.com:RocketChat/Rocket.Chat: Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
gabriellsh
added a commit
that referenced
this pull request
Jun 9, 2022
… feat/new-header * 'new/homepage' of github.com:RocketChat/Rocket.Chat: [NEW] Add Custom homepage Content Setting (#25777) Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments