Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Wrong argument name preventing Omnichannel Chat Forward to User #25723

Conversation

dudanogueira
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Wrong argument passed to users.info api (userName instead of username) that prevents forwarding chat to agents.

Further comments

@dudanogueira dudanogueira added this to the 4.8.1 milestone Jun 2, 2022
@dudanogueira dudanogueira requested a review from a team as a code owner June 2, 2022 13:18
@KevLehman
Copy link
Contributor

Hey, can you modify the typings for the endpoint users.info on packages/rest-typings/src/v1/users.ts too? That way, the build won't fail 😬
On L5 of that file, you have: GET: (params: { userId?: IUser['_id']; userName?: IUser['username'] }) => { that should be GET: (params: { userId?: IUser['_id']; username?: IUser['username'] }) => {

@dudanogueira dudanogueira requested a review from a team as a code owner June 2, 2022 17:06
@ggazzo ggazzo changed the title [FIX] Wrong argument name preventing Omnichannel Chat Forward to User [FIX] Wrong argument name preventing Omnichannel Chat Forward to User Jun 8, 2022
@ggazzo ggazzo merged commit d5367a7 into RocketChat:develop Jun 8, 2022
@ggazzo ggazzo mentioned this pull request Jun 9, 2022
gabriellsh added a commit that referenced this pull request Jun 10, 2022
…e/split-useUserInfoActions

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Fix apps wrong typing (#25824)
  Chore: Remove compose from main repo (#23426)
  [FIX] `You and @Yourusername reacted with`title on reactions (#25733)
  [FIX] AgentsPage pagination (#25820)
  Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160)
  [FIX] Access issue on chat.getThreadsList (#25750)
  Chore: Remove snap files from Houston config (#25819)
  [FIX] Voip endpoint permissions (#25783)
  [FIX] allow only livechat-agents to be contact manager for any omnichannel contact  (#25451)
  Chore: use params instead of URL building on livechat endpoints (#25810)
  Regression: fix apps path (#25809)
  [BREAK] Remove RDStation integration (#25774)
  Chore: RestApiClient as Package (#25469)
  [FIX] Wrong argument name preventing Omnichannel Chat Forward to User  (#25723)
  [FIX] AccountBox checks for condition (#25708)
  Chore: Fix CI (#25797)
  [FIX] Fix prom-client new promise usage (#25781)
  [FIX] Discussion alphabetical  ordering (#25788)
  Update .kodiak.toml
  Update .kodiak.toml
  ...
gabriellsh added a commit that referenced this pull request Jun 13, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits)
  [FIX] Client-generated sort parameters in channel directory  (#25768)
  Chore: Add tests for agents screens (#25637)
  Chore: Notification Preferences to TS (#25827)
  Chore: Convert MemoizedSetting, Setting, Section (#25572)
  Regression: Fix users.create call (#25834)
  Chore: Add auto label and improve Kodiak configuration (#25829)
  Regression: Fix apps wrong typing (#25824)
  Chore: Remove compose from main repo (#23426)
  [FIX] `You and @Yourusername reacted with`title on reactions (#25733)
  [FIX] AgentsPage pagination (#25820)
  Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160)
  [FIX] Access issue on chat.getThreadsList (#25750)
  Chore: Remove snap files from Houston config (#25819)
  [FIX] Voip endpoint permissions (#25783)
  [FIX] allow only livechat-agents to be contact manager for any omnichannel contact  (#25451)
  Chore: use params instead of URL building on livechat endpoints (#25810)
  Regression: fix apps path (#25809)
  [BREAK] Remove RDStation integration (#25774)
  Chore: RestApiClient as Package (#25469)
  [FIX] Wrong argument name preventing Omnichannel Chat Forward to User  (#25723)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants