Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Access issue on chat.getThreadsList #25750

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Jun 3, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Clickup task: https://app.clickup.com/t/201cbrc

@murtaza98 murtaza98 requested a review from a team June 3, 2022 16:13
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing. I think it's related to the new checks

@murtaza98 murtaza98 requested a review from gabriellsh June 6, 2022 06:57
@murtaza98
Copy link
Contributor Author

Tests failing. I think it's related to the new checks

Yups, indeed it was. It should be fixed now. Can you please check again :)

@murtaza98 murtaza98 dismissed gabriellsh’s stale review June 6, 2022 12:02

Changes done, Thanks Gabriel! :)

@murtaza98 murtaza98 requested a review from KevLehman June 7, 2022 06:17
@murtaza98 murtaza98 added stat: ready to merge PR tested and approved waiting for merge automerge and removed stat: ready to merge PR tested and approved waiting for merge automerge labels Jun 9, 2022
@kodiakhq kodiakhq bot merged commit 9f2c03c into develop Jun 9, 2022
@kodiakhq kodiakhq bot deleted the vul/chat.getThreadsList branch June 9, 2022 15:42
gabriellsh added a commit that referenced this pull request Jun 10, 2022
…e/split-useUserInfoActions

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Fix apps wrong typing (#25824)
  Chore: Remove compose from main repo (#23426)
  [FIX] `You and @Yourusername reacted with`title on reactions (#25733)
  [FIX] AgentsPage pagination (#25820)
  Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160)
  [FIX] Access issue on chat.getThreadsList (#25750)
  Chore: Remove snap files from Houston config (#25819)
  [FIX] Voip endpoint permissions (#25783)
  [FIX] allow only livechat-agents to be contact manager for any omnichannel contact  (#25451)
  Chore: use params instead of URL building on livechat endpoints (#25810)
  Regression: fix apps path (#25809)
  [BREAK] Remove RDStation integration (#25774)
  Chore: RestApiClient as Package (#25469)
  [FIX] Wrong argument name preventing Omnichannel Chat Forward to User  (#25723)
  [FIX] AccountBox checks for condition (#25708)
  Chore: Fix CI (#25797)
  [FIX] Fix prom-client new promise usage (#25781)
  [FIX] Discussion alphabetical  ordering (#25788)
  Update .kodiak.toml
  Update .kodiak.toml
  ...
gabriellsh added a commit that referenced this pull request Jun 13, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits)
  [FIX] Client-generated sort parameters in channel directory  (#25768)
  Chore: Add tests for agents screens (#25637)
  Chore: Notification Preferences to TS (#25827)
  Chore: Convert MemoizedSetting, Setting, Section (#25572)
  Regression: Fix users.create call (#25834)
  Chore: Add auto label and improve Kodiak configuration (#25829)
  Regression: Fix apps wrong typing (#25824)
  Chore: Remove compose from main repo (#23426)
  [FIX] `You and @Yourusername reacted with`title on reactions (#25733)
  [FIX] AgentsPage pagination (#25820)
  Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160)
  [FIX] Access issue on chat.getThreadsList (#25750)
  Chore: Remove snap files from Houston config (#25819)
  [FIX] Voip endpoint permissions (#25783)
  [FIX] allow only livechat-agents to be contact manager for any omnichannel contact  (#25451)
  Chore: use params instead of URL building on livechat endpoints (#25810)
  Regression: fix apps path (#25809)
  [BREAK] Remove RDStation integration (#25774)
  Chore: RestApiClient as Package (#25469)
  [FIX] Wrong argument name preventing Omnichannel Chat Forward to User  (#25723)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants