fix: New users are not automatically inserted in auto-join rooms inside default teams #31720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, whenever we had auto join teams, when the user joined, we would not look at the auto-join channels inside of it
🦋 Changeset detectedLatest commit: 91980e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31720 +/- ##
===========================================
- Coverage 54.61% 54.57% -0.05%
===========================================
Files 2283 2283
Lines 50279 50279
Branches 10255 10255
===========================================
- Hits 27461 27439 -22
- Misses 20331 20351 +20
- Partials 2487 2489 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Feb 12, 2024
apps/meteor/app/lib/server/functions/addUserToDefaultChannels.ts
Outdated
Show resolved
Hide resolved
MarcosSpessatto
requested changes
Feb 15, 2024
matheusbsilva137
changed the title
MarcosSpessatto
requested changes
Feb 26, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MarcosSpessatto
approved these changes
Mar 1, 2024
matheusbsilva137
approved these changes
Mar 4, 2024
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2024
…tMarkdown * 'develop' of github.com:RocketChat/Rocket.Chat: chore: improve useJumpToMessage (#31907) feat: Add `link` action to composer toolbar (#31679) chore: replace `PaletteStyleTag` in favor of fuselage component (#31839) fix: presence for mobiles with duplicated connections (#31895) fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720) fix: livechat agent status set to available after reactivation (#31651) chore: Deprecate `insertOrUpdateUser` method (#31884) chore: update ts version on recently merged package (#31885) chore: move utilitary functions out of ee folder (#31207) chore: Remove references to EE code from the app bridges (#31757) fix: Room import doesn't honor the specified owner (#31803) fix: message parser emphasis black hole (#31868) chore: remove hardcoded position for message date (#31866) feat: show date on message's scroll (#31572) chore: `RoomHeader` keyboard navigability (#31837) fix: Login page breaking when handling not expected errors (#31804)
ricardogarim
pushed a commit
that referenced
this pull request
Mar 6, 2024
…de default teams (#31720) Co-authored-by: Matheus Barbosa Silva <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Earlier, whenever we had auto join teams, when the user joined, we would not look at the auto-join channels inside of it.
The idea is, that when we are going to create the subscriptions between the team and the user, we check whether the team has a default channel, if so, fetch those and add the user to it as well
Issue(s)
Steps to test or reproduce
Expected Behavior: The user should be added to both the team and the channel
Current behavior: The user is being added only to the team
Further comments
CORE-58