feat: New users page deactivated tab and active tab ui #32032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2644f7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32032 +/- ##
===========================================
- Coverage 55.74% 55.70% -0.05%
===========================================
Files 2637 2637
Lines 57399 57404 +5
Branches 11892 11894 +2
===========================================
- Hits 31997 31976 -21
- Misses 22687 22715 +28
+ Partials 2715 2713 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
rique223
force-pushed
the
feat/new-user-panel-active
branch
from
5e31c7a
to
c6e5b7f
Compare
tassoevan
force-pushed
the
feat/new-user-panel-active
branch
from
66844ff
to
d315d45
Compare
rique223
force-pushed
the
feat/new-user-panel-deactivated
branch
from
8b92ea5
to
733c1a5
Compare
rique223
force-pushed
the
feat/new-user-panel-deactivated
branch
from
7cb7f3e
to
7d12186
Compare
rique223
force-pushed
the
feat/new-user-panel-deactivated
branch
from
733c1a5
to
7d12186
Compare
Implemented a new tab in the users page called 'deactivated' that will list all users who have logged in for the first time but are deactivated for any reason, also added a useMemo to the table action menu for optimization and added logic to only show the Status change and Delete options in the menus of the table and the contextual bar when inside the deactivated and pending tabs.
rique223
force-pushed
the
feat/new-user-panel-deactivated
branch
from
7cb7f3e
to
eced9c5
Compare
rique223
changed the title
Fixed an alignment problem in which the table menu would be shown a little higher than it should due to transforming the GenericTableCell into display flex. Also solved an issue with the pagination in which if you changed tabs the pagination offset would not be reset.
We should avoid add new types in core-typings that are only used for UI.
tassoevan
previously approved these changes
Jul 23, 2024
rique223
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
rique223
removed
stat: QA assured
tassoevan
approved these changes
Jul 30, 2024
rique223
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jul 31, 2024
…ove/threadMetrics * 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits) chore: Bump rocket.chat to 6.12.0-develop (#32936) test: Move Jest configuration to a package of presets (#32802) chore: bump turbo (#32938) feat: New users page deactivated tab and active tab ui (#32032) chore: bump traefik (#32892) test: fix flaky test `Archive department` (#32933) fix(Livechat): `After Registration Triggers` showing in wrong screen (#32928) refactor: Remove deprecated `Options.AvatarSize` constant (#32909) chore: improve `on login` cached collection (#32929) i18n: Rocket.Chat language update from Lingohub 🤖 on 2024-07-25Z (#32908) refactor: Circular imports (#32885) regression: notify user properly on logout (#32920) chore(client): stop replacing `Meteor.user` (#32910) regression: Messagebox sending message instead of just selecting popup suggestion (#32890) refactor: move broadcastMessageFromData to notifyListener (#32843) chore: prevent destructuring _id of deleted users (#32899) ci: increase kernel limits (#32902) ci: lint issues Release 6.10.1 fix: imported fixes (#32894) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Implemented a new tab on the users page labeled 'Deactivated', which displays all users who have logged in for the first time but are deactivated for any reason. Additionally, a useMemo hook was applied to optimize the table action menu options. Logic was also integrated to exclusively present the 'Status Change' and 'Delete' options within the table and contextual bar menus when navigating within the 'Deactivated' and 'Pending' tabs. Also added the active tab ui code back as it got lost during the merge process of the previous PR:
Demo images:
Issue(s)
Steps to test or reproduce
Further comments
Related to: #30236
Old Jira task: WM-87
New Jira task for Conn: CONN-264