refactor: move broadcastMessageFromData to notifyListener #32843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32843 +/- ##
===========================================
- Coverage 55.51% 55.23% -0.29%
===========================================
Files 2637 2443 -194
Lines 57439 54332 -3107
Branches 11903 11199 -704
===========================================
- Hits 31887 30008 -1879
+ Misses 22832 21799 -1033
+ Partials 2720 2525 -195
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardogarim
force-pushed
the
refactor/move-broadcastMessageFromData-to-notifyListener
branch
from
2589d0b
to
1bbef2c
Compare
MarcosSpessatto
requested changes
Jul 24, 2024
apps/meteor/tests/unit/app/lib/server/lib/notifyListener.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/app/lib/server/lib/notifyListener.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/app/lib/server/lib/notifyListener.spec.ts
Outdated
Show resolved
Hide resolved
…r' of github.com:RocketChat/Rocket.Chat into refactor/move-broadcastMessageFromData-to-notifyListener
MarcosSpessatto
approved these changes
Jul 25, 2024
KevLehman
approved these changes
Jul 25, 2024
ricardogarim
added
stat: ready to merge
kodiakhq
bot
deleted the
refactor/move-broadcastMessageFromData-to-notifyListener
branch
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
gabriellsh
added a commit
that referenced
this pull request
Jul 31, 2024
…ove/threadMetrics * 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits) chore: Bump rocket.chat to 6.12.0-develop (#32936) test: Move Jest configuration to a package of presets (#32802) chore: bump turbo (#32938) feat: New users page deactivated tab and active tab ui (#32032) chore: bump traefik (#32892) test: fix flaky test `Archive department` (#32933) fix(Livechat): `After Registration Triggers` showing in wrong screen (#32928) refactor: Remove deprecated `Options.AvatarSize` constant (#32909) chore: improve `on login` cached collection (#32929) i18n: Rocket.Chat language update from Lingohub 🤖 on 2024-07-25Z (#32908) refactor: Circular imports (#32885) regression: notify user properly on logout (#32920) chore(client): stop replacing `Meteor.user` (#32910) regression: Messagebox sending message instead of just selecting popup suggestion (#32890) refactor: move broadcastMessageFromData to notifyListener (#32843) chore: prevent destructuring _id of deleted users (#32899) ci: increase kernel limits (#32902) ci: lint issues Release 6.10.1 fix: imported fixes (#32894) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per CORE-575, the
broadcastMessageFromDatafunction has been moved to thenotifyListenerhandler file to align with existing functions that handle server-to-listener communication. This change does not affect any use cases, inputs, or outputs of the existing function.