fix: Team mention triggering bot message for users not in room #32112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 775a5ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32112 +/- ##
===========================================
- Coverage 54.90% 54.85% -0.05%
===========================================
Files 2307 2303 -4
Lines 50943 50877 -66
Branches 10423 10413 -10
===========================================
- Hits 27969 27910 -59
+ Misses 20463 20460 -3
+ Partials 2511 2507 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Apr 3, 2024
* origin: refactor: `TeamsChannels` to typescript (#32109) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
|
Looks like this PR is ready to merge! 🎉 |
MarcosSpessatto
approved these changes
Apr 5, 2024
jessicaschelly
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Check if mention is for a team
Issue(s)
CORE-121
Steps to test or reproduce
Further comments