-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Improve permissions check on roles endpoints #32347
chore!: Improve permissions check on roles endpoints #32347
Conversation
Co-authored-by: Diego Sampaio <[email protected]>
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32347 +/- ##
=================================================
- Coverage 55.56% 55.56% -0.01%
=================================================
Files 2408 2410 +2
Lines 53019 53074 +55
Branches 10902 10909 +7
=================================================
+ Hits 29460 29488 +28
- Misses 20941 20963 +22
- Partials 2618 2623 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Diego Sampaio <[email protected]>
* chore: Improve permission check on channels endpoints
Proposed changes (including videos or screenshots)
roles
endpoints by using thepermissionsRequired
property.Issue(s)
CORE-346
Steps to test or reproduce
Further comments
The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.