Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Users in role table not rendering the empty state properly #32412

Merged
merged 8 commits into from
May 31, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented May 10, 2024

Proposed changes (including videos or screenshots)

Depends on: #32320

It renders the error and empty state on the table instead of a wrong toast message when not finding users in role.
Also adds the proper fields validation

Issue(s)

Steps to test or reproduce

Further comments

CORE-465

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: e077ec0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented May 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 84.09091% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 55.95%. Comparing base (3fc12f6) to head (e077ec0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32412      +/-   ##
===========================================
- Coverage    56.32%   55.95%   -0.37%     
===========================================
  Files         2434     2424      -10     
  Lines        53712    53440     -272     
  Branches     11059    11024      -35     
===========================================
- Hits         30251    29903     -348     
- Misses       20816    20929     +113     
+ Partials      2645     2608      -37     
Flag Coverage Δ
unit 72.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the title fix: Users in role list not rendering properly fix: Users in role table not rendering properly May 10, 2024
@dougfabris dougfabris added this to the 6.9 milestone May 16, 2024
@dougfabris dougfabris marked this pull request as ready for review May 16, 2024 22:06
@dougfabris dougfabris requested a review from a team as a code owner May 16, 2024 22:06
@dougfabris dougfabris modified the milestones: 6.9, 6.10 May 21, 2024
@dougfabris dougfabris changed the title fix: Users in role table not rendering properly fix: Users in role table not rendering all states properly May 23, 2024
@dougfabris dougfabris changed the title fix: Users in role table not rendering all states properly fix: Users in role table not rendering the empty state properly May 23, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label May 31, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 31, 2024
@kodiakhq kodiakhq bot merged commit 8e4485b into develop May 31, 2024
45 of 47 checks passed
@kodiakhq kodiakhq bot deleted the fix/usersInRoleList branch May 31, 2024 18:29
gabriellsh added a commit that referenced this pull request Jun 3, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Release 6.9.0
  Release 6.9.0-rc.2
  fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500)
  fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500)
  regression: Hide prune section based on permission (#32531)
  fix: Users in role table not rendering the empty state properly (#32412)
  refactor: EmailInbox out of DB Watcher (#32501)
  ci: increase issue allowed stale time (#32523)
  regression: Remove impossible sorting from users table "registration status" column (#32506)
  feat: Add contentDisposition option to file storages (#31974)
  i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-05-28Z (#32508)
  Release 6.9.0-rc.1
  fix: Re-login same browser tab issues (#32479)
  regression: Replace read receipt single icon (#32486)
  regression: Incorrect retention policy banner's display rule for teams (#32483)
  chore: Publish npm packages again (#32463)
  ci: publish missing Omnichannel services to DockerHub (#32462)
  Release 6.9.0-rc.0
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants